WordPress/wp-admin
Sergey Biryukov 7f0fc452b1 Docs: Improve `@since` notes for some `WP_Filesystem_*` methods:
* `WP_Filesystem_FTPext::exists()`
* `WP_Filesystem_FTPext::size()`
* `WP_Filesystem_ftpsockets::exists()`

The `::exists()` methods were previously using the FTP `NLST` command, which works for directories, but is not intended to be applied to a file. This only worked most of the time due to many FTP servers being permissive and allowing to execute `NLST` on files, which cannot be guaranteed and appears to not be the case in newer versions of Pure-FTPd (1.0.48 or later).

With a recent change in [53860], both methods were updated for compatibility with RFC 959:

* Both methods check if the path is a directory that can be changed into (and therefore exists).
* `WP_Filesystem_FTPext` uses `ftp_rawlist()` (FTP `LIST` command) to check for file existence.
* `WP_Filesystem_ftpsockets` uses file size to check for file existence.

Reference: [https://www.ietf.org/rfc/rfc959.txt RFC 959: File Transfer Protocol (FTP)]

Follow-up to [6779], [11821], [25274], [33648], [34733], [35944], [35946], [53860].

See #51170.
Built from https://develop.svn.wordpress.org/trunk@53862


git-svn-id: http://core.svn.wordpress.org/trunk@53421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-08-08 17:14:13 +00:00
..
css Media: Prevent URLs from overflowing their container in the media editor. 2022-07-25 18:11:08 +00:00
images Administration: Update design of the Dashboard welcome panel. 2022-05-10 16:45:08 +00:00
includes Docs: Improve `@since` notes for some `WP_Filesystem_*` methods: 2022-08-08 17:14:13 +00:00
js Plugins: Properly encode query string `s` parameter in plugin search. 2022-08-05 14:12:11 +00:00
maint Database: Check the correct value for displaying the "Successfully repaired table" or "Failed to repair" messages on Database Repair screen. 2020-12-04 15:50:12 +00:00
network General: Replace all `esc_url_raw()` calls in core with `sanitize_url()`. 2022-06-01 18:14:10 +00:00
user Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
about.php Help/About: Add cache busting string to video thumbnail. 2022-05-25 02:19:17 +00:00
admin-ajax.php Coding Standards: Remove extra space in `wp-admin/admin-ajax.php`. 2022-05-07 16:21:18 +00:00
admin-footer.php Coding Standards: Simplify a condition in `wp-admin/admin-footer.php`. 2021-06-01 11:30:57 +00:00
admin-functions.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
admin-header.php Docs: Add missing description for `$typenow` global in various functions. 2022-04-04 18:39:01 +00:00
admin-post.php Administration: Require a valid action parameter to be set for `admin-ajax.php` requests. 2022-03-02 15:00:11 +00:00
admin.php Docs: Add missing description for `$taxnow` global in various functions. 2022-04-04 18:43:02 +00:00
async-upload.php Media: Remove target blank attribute from media uploader edit links. 2022-01-27 22:17:00 +00:00
authorize-application.php Docs: Various corrections and improvements to inline documentation. 2022-08-04 14:52:11 +00:00
comment.php Administration: Replace contracted verb forms for better consistency. 2022-03-22 16:25:03 +00:00
credits.php Help/About: WordPress 5.9 About Page. 2022-01-04 18:35:03 +00:00
custom-background.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
custom-header.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
customize.php Customizer: When a block theme is active, add an information about Site Editor in the Customizer. 2022-03-29 19:10:14 +00:00
edit-comments.php Docs: Explicitly declare some globals for clarity. 2022-05-29 15:35:11 +00:00
edit-form-advanced.php Administration: Remove self-reference ("we") in WordPress Admin. 2022-04-11 11:42:04 +00:00
edit-form-blocks.php Editor: Return additional block patterns to server-generated settings 2022-05-17 14:38:14 +00:00
edit-form-comment.php Docs: Explicitly declare some globals for clarity. 2022-05-29 15:35:11 +00:00
edit-link-form.php Administration: Replace contracted verb forms for better consistency. 2022-03-22 16:25:03 +00:00
edit-tag-form.php General: Replace all `esc_url_raw()` calls in core with `sanitize_url()`. 2022-06-01 18:14:10 +00:00
edit-tags.php Docs: Various corrections and improvements to inline documentation. 2022-08-04 14:52:11 +00:00
edit.php Docs: Explicitly declare some globals for clarity. 2022-05-29 15:35:11 +00:00
erase-personal-data.php Help/about: Improve text in help tabs of the Personal Data Exporter/Eraser. 2022-04-14 14:46:07 +00:00
export-personal-data.php Help/about: Improve text in help tabs of the Personal Data Exporter/Eraser. 2022-04-14 14:46:07 +00:00
export.php Administration: Remove self-reference ("we") in WordPress Admin. 2022-04-11 11:42:04 +00:00
freedoms.php Administration: Remove self-reference ("we") in WordPress Admin. 2022-04-11 11:42:04 +00:00
import.php Docs: Add a comment about the `$title` global usage in various admin files. 2021-07-22 13:53:00 +00:00
index.php Help/About: Improve typography in the `Welcome to your WordPress Dashboard!` text. 2021-11-03 03:16:57 +00:00
install-helper.php Code Modernization: Rename parameters that use reserved keywords in `wp-admin/install-helper.php`. 2022-04-20 11:19:12 +00:00
install.php Coding Standards: Move `wp-includes/wp-db.php` to `wp-includes/class-wpdb.php`. 2022-07-21 16:00:15 +00:00
link-add.php Docs: Add a comment about the `$title` global usage in various admin files. 2021-07-22 13:53:00 +00:00
link-manager.php Docs: Add a comment about the `$title` global usage in various admin files. 2021-07-22 13:53:00 +00:00
link-parse-opml.php XML-RPC: Explicitly unset the reference to the parser resource after calling `xml_parser_free()` to avoid memory leaks in PHP 7.0.0 or higher. 2020-07-05 15:22:01 +00:00
link.php Coding Standards: Apply some alignment fixes from `composer format`. 2021-07-27 19:01:59 +00:00
load-scripts.php Docs: Update a comment in `wp-admin/load-styles.php` per the documentation standards. 2021-12-12 14:52:02 +00:00
load-styles.php Docs: Update a comment in `wp-admin/load-styles.php` per the documentation standards. 2021-12-12 14:52:02 +00:00
media-new.php Docs: Add a comment about the `$title` global usage in various admin files. 2021-07-22 13:53:00 +00:00
media-upload.php Docs: Add examples of possible names for various hooks whose name contains a dynamic portion. 2021-03-07 12:32:09 +00:00
media.php Administration: Replace contracted verb forms for better consistency. 2022-03-22 16:25:03 +00:00
menu-header.php Administration: Restore the correct escaping function for base64-encoded SVG icons in the admin menu. 2022-04-07 12:54:03 +00:00
menu.php Administration: Make sure the `$customize_url` variable is always defined in the admin menu. 2021-12-25 03:32:03 +00:00
moderation.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-admin.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-delete-site.php Docs: Add a comment about the `$title` global usage in various admin files. 2021-07-22 13:53:00 +00:00
ms-edit.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-options.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-sites.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-themes.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-upgrade-network.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-users.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
my-sites.php Docs: Add a comment about the `$title` global usage in various admin files. 2021-07-22 13:53:00 +00:00
nav-menus.php Text Changes: Improve consistency of punctuation in some strings. 2022-07-14 14:10:11 +00:00
network.php Docs: Add a comment about the `$title` global usage in various admin files. 2021-07-22 13:53:00 +00:00
options-discussion.php Options, Meta APIs: Rephrase the description of the "Avatars" section. 2022-03-28 10:56:04 +00:00
options-general.php Administration: Change default site tagline to an empty string. 2022-08-03 12:20:16 +00:00
options-head.php Administration: Replace legacy `updated` message type in `add_settings_error()` calls with `success`. 2019-08-16 00:39:55 +00:00
options-media.php Docs: Add a comment about the `$title` global usage in various admin files. 2021-07-22 13:53:00 +00:00
options-permalink.php Coding Standards: Use `MINUTE_IN_SECONDS` where appropriate. 2022-07-17 02:18:09 +00:00
options-privacy.php Administration: Clarify some sentences after [53131]. 2022-04-12 13:43:16 +00:00
options-reading.php Coding Standards: Use strict comparison in `wp-admin/options-reading.php`. 2022-01-02 16:47:05 +00:00
options-writing.php Docs: Add a comment about the `$title` global usage in various admin files. 2021-07-22 13:53:00 +00:00
options.php Coding Standards: Use `MINUTE_IN_SECONDS` where appropriate. 2022-07-17 02:18:09 +00:00
plugin-editor.php Administration: Correct the escaping in documentation lookup for plugin and theme editor. 2022-07-22 11:33:10 +00:00
plugin-install.php Administration: Replace contracted verb forms for better consistency. 2022-03-22 16:25:03 +00:00
plugins.php Coding standards: Properly escape URLs returned by `self_admin_url()` calls. 2022-08-05 06:00:09 +00:00
post-new.php Coding Standards: Use strict comparison where static strings are involved. 2020-05-16 18:42:12 +00:00
post.php Administration: Replace contracted verb forms for better consistency. 2022-03-22 16:25:03 +00:00
press-this.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
privacy-policy-guide.php Administration: Remove self-reference ("we") in WordPress Admin. 2022-04-11 11:42:04 +00:00
privacy.php Docs: Add a comment about the `$title` global usage in various admin files. 2021-07-22 13:53:00 +00:00
profile.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
revision.php Coding Standards: Use strict comparison in `wp-admin/revision.php`. 2022-01-07 16:47:00 +00:00
setup-config.php Database: Suppress errors when checking the validity of table prefix during installation. 2022-08-02 16:34:13 +00:00
site-editor.php Site Editor: Pass correct context into get_block_categories 2022-07-27 12:27:16 +00:00
site-health-info.php Site Health: Internationalizes count in the info section headings. 2021-11-01 22:36:59 +00:00
site-health.php Site Health: Typo correction in Site Health help tab. 2021-12-18 21:02:04 +00:00
term.php General: Replace all `esc_url_raw()` calls in core with `sanitize_url()`. 2022-06-01 18:14:10 +00:00
theme-editor.php Administration: Correct the escaping in documentation lookup for plugin and theme editor. 2022-07-22 11:33:10 +00:00
theme-install.php Themes: Use consistent thumbnail sizes in Customizer preview screen. 2022-04-16 06:15:09 +00:00
themes.php Themes: Properly escape `home_url()` when changing and updating themes. 2022-07-06 19:46:10 +00:00
tools.php Docs: Add a comment about the `$title` global usage in various admin files. 2021-07-22 13:53:00 +00:00
update-core.php Coding standards: Properly escape URLs returned by `self_admin_url()` calls. 2022-08-05 06:12:10 +00:00
update.php Docs: Add a comment about the `$title` global usage in various admin files. 2021-07-22 13:53:00 +00:00
upgrade-functions.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
upgrade.php General: Replace all `esc_url_raw()` calls in core with `sanitize_url()`. 2022-06-01 18:14:10 +00:00
upload.php Help/About: Typo correction in the Media Library help tab text. 2022-06-29 13:39:14 +00:00
user-edit.php Application Passwords: Link a more accurate documentation page in User profile edit screen. 2022-07-21 19:32:12 +00:00
user-new.php Users: Use autocomplete values on user profiles. 2022-04-08 17:40:07 +00:00
users.php Help/About: Add help tab info for the "Send password reset" row action on Users screen. 2022-07-05 00:25:13 +00:00
widgets-form-blocks.php Editor: Update preload paths for post, site and widgets editors 2022-04-07 13:40:04 +00:00
widgets-form.php Widgets: Revert [51705]. 2021-09-09 21:40:57 +00:00
widgets.php Administration: Replace contracted verb forms for better consistency. 2022-03-22 19:59:04 +00:00