WordPress/wp-admin/includes
davidbaumwald aeb5d2ef17 Upgrade/Install: Fix parameter count in `error` call when an automatic core upgrade fails.
During automatic core upgrades, if installation results in a `WP_Error`, the `error` method is called on the skin with the details.  However, in this case, two parameters are passed to `$skin->error`, but only one is accepted.  This change passes only the running `WP_Error` instance as the sole parameter to `$skin->error`.

Also, this change adds an additional error to `$upgrade_result` before finally being passed to `$skin->error`, indicating that the installation failed.  This adds additional context to the failure.

Props desrosj, sainthkh, devutpol, SergeyBiryukov.
Fixes #53284.
Built from https://develop.svn.wordpress.org/trunk@52539


git-svn-id: http://core.svn.wordpress.org/trunk@52129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-01-07 17:55:01 +00:00
..
admin-filters.php Upgrade/Install: Notify users of deactivated plugins during upgrade. 2021-06-30 00:21:58 +00:00
admin.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ajax-actions.php Taxonomy: Display update notices when adding terms. 2021-11-15 22:24:01 +00:00
bookmark.php Administration: Improve the message about installing the Link Manager plugin to use legacy Links screen. 2021-05-25 20:14:59 +00:00
class-automatic-upgrader-skin.php Code Modernization: Fix reserved keyword and parameter name mismatches for parent/child classes in `WP_Upgrader_Skin::feedback()`. 2021-09-09 13:48:56 +00:00
class-bulk-plugin-upgrader-skin.php Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings. 2020-11-09 10:53:10 +00:00
class-bulk-theme-upgrader-skin.php Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings. 2020-11-09 10:53:10 +00:00
class-bulk-upgrader-skin.php Code Modernization: Fix parameter name mismatches for parent/child classes in `WP_Upgrader_Skin::error()`. 2021-09-09 13:59:56 +00:00
class-core-upgrader.php Docs: Correct DocBlock formatting for `Core_Upgrader::upgrade()`. 2021-06-19 21:37:57 +00:00
class-custom-background.php Customize: Hide native control on background position field. 2021-08-19 02:07:56 +00:00
class-custom-image-header.php External Libraries: Further fix jQuery deprecations in WordPress core. 2021-11-30 17:18:01 +00:00
class-file-upload-upgrader.php Docs: Improve inline comments per the documentation standards. 2020-01-29 00:45:18 +00:00
class-ftp-pure.php Docs: Update URLs in some `@link` tags and switch them to HTTPS. 2019-11-01 14:57:02 +00:00
class-ftp-sockets.php Docs: Update URLs in some `@link` tags and switch them to HTTPS. 2019-11-01 14:57:02 +00:00
class-ftp.php General: Continuing to work towards a passing PHP Compatibility scan. 2020-06-03 17:40:12 +00:00
class-language-pack-upgrader-skin.php Code Modernization: Fix parameter name mismatches for parent/child classes in `WP_Upgrader_Skin::error()`. 2021-09-09 13:59:56 +00:00
class-language-pack-upgrader.php Docs: Add missing `@return` tag to `Language_Pack_Upgrader::check_package()`. 2020-10-05 13:44:11 +00:00
class-pclzip.php Filesystem API: Make sure to only call `fread()` on non-empty files in `PclZip::privAddFile()`. 2021-08-29 01:33:58 +00:00
class-plugin-installer-skin.php I18N: Combine escaping and translation functions. 2021-05-19 18:10:59 +00:00
class-plugin-upgrader-skin.php Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings. 2020-11-09 10:53:10 +00:00
class-plugin-upgrader.php Upgrade/install: Revert upgrader rollback features. 2021-12-10 00:06:04 +00:00
class-theme-installer-skin.php Docs: Various corrections and improvements relating to types used in inline documentation. 2021-11-18 13:50:05 +00:00
class-theme-upgrader-skin.php Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings. 2020-11-09 10:53:10 +00:00
class-theme-upgrader.php Upgrade/install: Revert upgrader rollback features. 2021-12-10 00:06:04 +00:00
class-walker-category-checklist.php Code Modernization: Fix reserved keyword and parameter name mismatches for parent/child classes in `Walker::end_el()`. 2021-09-09 13:03:55 +00:00
class-walker-nav-menu-checklist.php Code Modernization: Fix last parameter name mismatches for parent/child classes in `Walker::start_el()`. 2021-09-09 12:39:59 +00:00
class-walker-nav-menu-edit.php Docs: Various corrections and improvements relating to types used in inline documentation. 2021-11-18 13:50:05 +00:00
class-wp-ajax-upgrader-skin.php Code Modernization: Fix reserved keyword and parameter name mismatches for parent/child classes in `WP_Upgrader_Skin::feedback()`. 2021-09-09 13:48:56 +00:00
class-wp-application-passwords-list-table.php Application Passwords: Allow enter key to submit profile form. 2021-06-07 23:49:58 +00:00
class-wp-automatic-updater.php Upgrade/Install: Fix parameter count in `error` call when an automatic core upgrade fails. 2022-01-07 17:55:01 +00:00
class-wp-comments-list-table.php Docs: Corrections relating to types used in inline documentation for comment ID and site ID proprties. 2021-11-18 13:57:01 +00:00
class-wp-community-events.php Coding Standards: Use static closures when not using `$this`. 2021-08-26 12:59:02 +00:00
class-wp-debug-data.php Site Health: Add the constant `WP_ENVIRONMENT_TYPE` for debug data. 2021-11-05 21:05:00 +00:00
class-wp-filesystem-base.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
class-wp-filesystem-direct.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
class-wp-filesystem-ftpext.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
class-wp-filesystem-ftpsockets.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
class-wp-filesystem-ssh2.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
class-wp-importer.php Coding Standards: Remove unnecessary `unset()` calls in `WP_Importer` methods. 2021-04-08 11:12:08 +00:00
class-wp-internal-pointers.php External Libraries: Further fix jQuery deprecations in WordPress core. 2021-11-30 17:18:01 +00:00
class-wp-links-list-table.php Code Modernization: Fix parameter name mismatches for parent/child classes in `WP_List_Table::handle_row_actions()`. 2021-09-07 19:24:53 +00:00
class-wp-list-table-compat.php Docs: Add missing descriptions for `_WP_List_Table_Compat` methods. 2020-11-14 16:54:08 +00:00
class-wp-list-table.php Administration: Enable first and last page buttons in `WP_List_Table::pagination()`. 2021-10-01 18:39:58 +00:00
class-wp-media-list-table.php I18N: Add context for some Media Library filter strings: 2021-10-12 16:44:01 +00:00
class-wp-ms-sites-list-table.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
class-wp-ms-themes-list-table.php Accessibility: Administration: Improve `aria-label` on network admin Themes screen. 2021-09-10 14:49:00 +00:00
class-wp-ms-users-list-table.php Code Modernization: Fix parameter name mismatches for parent/child classes in `WP_List_Table::handle_row_actions()`. 2021-09-07 19:24:53 +00:00
class-wp-plugin-install-list-table.php Docs: Document some more common names for dynamic hooks and standardise the phrasing used. 2021-09-21 18:21:00 +00:00
class-wp-plugins-list-table.php Docs: Update documentation for the `$plugin_data` parameter of various hooks: 2021-11-20 02:23:02 +00:00
class-wp-post-comments-list-table.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
class-wp-posts-list-table.php Docs: Remove instances of the “eg.” abbreviation in favor of “example” or “for example”. 2021-11-19 14:44:01 +00:00
class-wp-privacy-data-export-requests-list-table.php Coding Standards: Fix WPCS issues in [49258]. 2020-10-20 21:20:07 +00:00
class-wp-privacy-data-removal-requests-list-table.php Coding Standards: Fix WPCS issues in [49258]. 2020-10-20 21:20:07 +00:00
class-wp-privacy-policy-content.php Docs: Document the globals used in some Privacy API methods. 2021-11-24 11:41:03 +00:00
class-wp-privacy-requests-table.php Docs: Document the globals used in some Privacy API methods. 2021-11-24 11:41:03 +00:00
class-wp-screen.php Docs: Remove inaccurate part of the `screen_settings` filter description. 2021-11-27 02:07:00 +00:00
class-wp-site-health-auto-updates.php Coding Standards: Add `public` visibility to methods in `src` directory. 2021-10-18 17:52:58 +00:00
class-wp-site-health.php Upgrade/install: Revert upgrader rollback features. 2021-12-10 00:06:04 +00:00
class-wp-site-icon.php Media: Avoid suppressing errors when using `getimagesize()`. 2021-02-02 16:53:04 +00:00
class-wp-terms-list-table.php Taxonomy: Allow `get_*_*_link()` and `edit_term_link()` functions to accept a term ID, `WP_Term`, or term object. 2021-11-16 14:57:02 +00:00
class-wp-theme-install-list-table.php Docs: Various corrections and improvements relating to types used in inline documentation. 2021-11-18 13:50:05 +00:00
class-wp-themes-list-table.php I18N: Add context to some theme strings for consistency. 2020-07-21 16:33:05 +00:00
class-wp-upgrader-skin.php Code Modernization: Fix parameter name mismatches for parent/child classes in `WP_Upgrader_Skin::error()`. 2021-09-09 13:59:56 +00:00
class-wp-upgrader-skins.php Docs: Add missing `@deprecated` tags in the file docblock of some deprecated files. 2019-10-08 17:19:04 +00:00
class-wp-upgrader.php Upgrade/install: Revert upgrader rollback features. 2021-12-10 00:06:04 +00:00
class-wp-users-list-table.php Users: Use the "Posts" post type general name to contextualize the string used in Users posts count column label. 2021-12-31 15:30:01 +00:00
comment.php Coding Standards: Use strict comparison in `wp-admin/includes/comment.php`. 2021-04-06 13:45:09 +00:00
continents-cities.php I18N: Update list of continents and cities for the timezone selection. 2021-03-19 15:42:04 +00:00
credits.php Help/About: Don't output empty `<span>` tags on Credits screen. 2021-10-19 23:09:00 +00:00
dashboard.php Administration: Refresh the Dashboard Welcome panel. 2022-01-04 19:13:02 +00:00
deprecated.php Administration: Add "File" to Theme/Plugin Editor menu names and relocate "Plugin File Editor" to Tools for block themes. 2021-12-21 20:06:02 +00:00
edit-tag-messages.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
export.php Coding Standards: Simplify the check for parent terms in `export_wp()`. 2021-04-11 13:44:13 +00:00
file.php Build/Test Tools: Update PHPCompatibilityWP to version 2.1.3. 2021-12-31 13:55:03 +00:00
image-edit.php Docs: Correct description for the `$image` parameter of the `wp_save_image_file` filter. 2021-07-02 07:11:58 +00:00
image.php Build/Test Tools: Update PHPCompatibilityWP to version 2.1.3. 2021-12-31 13:55:03 +00:00
import.php Docs: Corrections and improvements to types used in various docblocks. 2021-01-05 17:16:11 +00:00
list-table.php Docs: Promote many `bool` types to `true` or `false` where only that value is used. 2021-01-03 22:04:04 +00:00
media.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
menu.php Coding Standards: Use strict comparison for `count()` calls. 2020-05-23 11:38:08 +00:00
meta-boxes.php External Libraries: Further fix jQuery deprecations in WordPress core. 2021-11-30 17:18:01 +00:00
misc.php Administration: Add "File" to Theme/Plugin Editor menu names and relocate "Plugin File Editor" to Tools for block themes. 2021-12-21 20:06:02 +00:00
ms-admin-filters.php Docs: Improve comments in some `wp-admin` files per the documentation standards. 2020-01-29 00:35:08 +00:00
ms-deprecated.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
ms.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
nav-menu.php General: Avoid unnecessary calls to `update_user_option()`. 2021-05-24 19:59:57 +00:00
network.php Admin/UI-Copy: reword some "we" usages. 2021-11-02 17:37:57 +00:00
noop.php Code Modernization: Remove conditional use of PHP `realpath()`. 2019-09-20 20:46:56 +00:00
options.php External Libraries: Further fix jQuery deprecations in WordPress core. 2021-11-30 17:18:01 +00:00
plugin-install.php Docs: Miscellaneous inline documentation improvements. 2021-12-29 17:28:00 +00:00
plugin.php Docs: Correct the format of some comments per the documentation standards. 2021-12-10 20:30:05 +00:00
post.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
privacy-tools.php Coding Standards: Fix indentation and remove `ignore` annotation in `wp_privacy_send_personal_data_export_email()`. 2021-08-26 14:05:58 +00:00
revision.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
schema.php Docs: Remove instances of the “eg.” abbreviation in favor of “example” or “for example”. 2021-11-19 14:44:01 +00:00
screen.php Coding Standards: Use strict comparison in `wp-admin/includes/screen.php`. 2021-05-09 20:27:02 +00:00
taxonomy.php Docs: Various docblock corrections and improvements. 2021-11-23 21:37:01 +00:00
template.php External Libraries: Further fix jQuery deprecations in WordPress core. 2021-11-30 17:18:01 +00:00
theme-install.php Coding Standards: Add a space before `/` character in some self-closing HTML tags. 2021-03-20 18:30:08 +00:00
theme.php Docs: Miscellaneous inline documentation improvements. 2021-12-29 17:28:00 +00:00
translation-install.php Docs: Promote many `bool` types to `true` or `false` where only that value is used. 2021-01-03 22:04:04 +00:00
update-core.php Upgrade/Install: Remove 5.8 function and fix deactivate Gutenberg plugin version compare < 11.9. 2021-11-17 17:45:00 +00:00
update.php Docs: Update documentation for the `$plugin_data` parameter of various hooks: 2021-11-20 02:23:02 +00:00
upgrade.php Upgrade/Install: Avoid using `unserialize()` unnecessarily. 2022-01-06 17:07:03 +00:00
user.php External Libraries: Further fix jQuery deprecations in WordPress core. 2021-11-30 17:18:01 +00:00
widgets.php Docs: Capitalize "ID", when referring to a widget ID or sidebar ID, in a more consistent way. 2021-12-13 10:21:07 +00:00