WordPress/wp-admin/includes
Sergey Biryukov df4ed4015a Coding Standards: Escape the whole attributes in `wp-admin/includes/nav-menu.php`.
It is best to always escape the complete value of an attribute, not a partial value, as otherwise the escaping could be (partially) undone when the values are joined together.

While the hardcoded prefix/suffix values in this case don't necessarily create that risk, those may change to values which could be problematic, so making it a habit to escape the value in one go is best practice.

Includes:
* Moving a few `esc_url()` calls closer to the actual output and escaping the hash parts too.
* Wrapping a few long lines for better readability.

Follow-up to [14248], [23707], [42217], [55615].

Props jrf, SergeyBiryukov.
Fixes #57110.
Built from https://develop.svn.wordpress.org/trunk@55616


git-svn-id: http://core.svn.wordpress.org/trunk@55128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-04-01 08:37:20 +00:00
..
admin-filters.php Editor: Refresh nones for metaboxes after reauthentication. 2022-09-11 20:46:10 +00:00
admin.php I18N: Always pass `$locale` to `load_textdomain()`. 2022-11-10 19:40:11 +00:00
ajax-actions.php Media: Revert `wp_ajax_save_attachment_updated` hook. 2023-03-07 13:13:22 +00:00
bookmark.php Coding Standards: Always use parentheses when instantiating an object. 2022-11-29 15:51:14 +00:00
class-automatic-upgrader-skin.php Code Modernization: Fix reserved keyword and parameter name mismatches for parent/child classes in `WP_Upgrader_Skin::feedback()`. 2021-09-09 13:48:56 +00:00
class-bulk-plugin-upgrader-skin.php Code Modernization: Explicitly declare all properties in `WP_Ajax_Upgrader_Skin`. 2022-08-29 12:46:10 +00:00
class-bulk-theme-upgrader-skin.php Code Modernization: Explicitly declare all properties in `WP_Ajax_Upgrader_Skin`. 2022-08-29 12:46:10 +00:00
class-bulk-upgrader-skin.php Code Modernization: Fix parameter name mismatches for parent/child classes in `WP_Upgrader_Skin::error()`. 2021-09-09 13:59:56 +00:00
class-core-upgrader.php Administration: Replace "can not" with "cannot" after [53131]. 2022-04-11 11:50:01 +00:00
class-custom-background.php Help/About: Use the new `/documentation/` URLs for HelpHub links in WordPress Admin. 2023-02-23 10:38:21 +00:00
class-custom-image-header.php Help/About: Use the new `/documentation/` URLs for HelpHub links in WordPress Admin. 2023-02-23 10:38:21 +00:00
class-file-upload-upgrader.php Code Modernization: Add `AllowDynamicProperties` attribute to all (parent) classes. 2022-09-12 15:47:14 +00:00
class-ftp-pure.php
class-ftp-sockets.php Administration: Replace contracted verb forms for better consistency. 2022-03-22 16:25:03 +00:00
class-ftp.php Code Modernization: Rename parameters that use reserved keywords in `wp-admin/includes/class-ftp.php`. 2022-03-26 15:28:08 +00:00
class-language-pack-upgrader-skin.php Code Modernization: Fix parameter name mismatches for parent/child classes in `WP_Upgrader_Skin::error()`. 2021-09-09 13:59:56 +00:00
class-language-pack-upgrader.php Coding Standards: Always use parentheses when instantiating an object. 2022-11-29 15:51:14 +00:00
class-pclzip.php Filesystem API: Make sure to only call `fread()` on non-empty files in `PclZip::privAddFile()`. 2021-08-29 01:33:58 +00:00
class-plugin-installer-skin.php Docs: Clarify the `::hide_process_failed()` return value in plugin and theme installer. 2023-03-27 15:11:20 +00:00
class-plugin-upgrader-skin.php
class-plugin-upgrader.php Code Modernization: Replace `phpversion()` function calls with `PHP_VERSION` constant. 2022-05-20 17:38:14 +00:00
class-theme-installer-skin.php Docs: Clarify the `::hide_process_failed()` return value in plugin and theme installer. 2023-03-27 15:11:20 +00:00
class-theme-upgrader-skin.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
class-theme-upgrader.php Code Modernization: Replace `phpversion()` function calls with `PHP_VERSION` constant. 2022-05-20 17:38:14 +00:00
class-walker-category-checklist.php Code Modernization: Fix reserved keyword and parameter name mismatches for parent/child classes in `Walker::end_el()`. 2021-09-09 13:03:55 +00:00
class-walker-nav-menu-checklist.php Code Modernization: Fix last parameter name mismatches for parent/child classes in `Walker::start_el()`. 2021-09-09 12:39:59 +00:00
class-walker-nav-menu-edit.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
class-wp-ajax-upgrader-skin.php Code Modernization: Explicitly declare all properties in `WP_Ajax_Upgrader_Skin`. 2022-08-29 12:46:10 +00:00
class-wp-application-passwords-list-table.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
class-wp-automatic-updater.php Docs: Add missing `@return` tag for `WP_Automatic_Updater::is_disabled()`. 2023-03-27 14:13:22 +00:00
class-wp-comments-list-table.php Comments: Prime post caches in WP_Comments_List_Table. 2023-03-10 15:26:22 +00:00
class-wp-community-events.php Administration: Guard against `false` transient key in `get_cached_events()`. 2022-09-27 18:57:13 +00:00
class-wp-debug-data.php Media: Add `WP_Image_Editor_Imagick::set_imagick_time_limit()` method. 2023-02-22 14:25:25 +00:00
class-wp-filesystem-base.php Code Modernization: Add `AllowDynamicProperties` attribute to all (parent) classes. 2022-09-12 15:47:14 +00:00
class-wp-filesystem-direct.php Filesystem API: Use `trailingslashit( $path )` instead of `$path . '/'`. Fixes a warning when `$path` already ends with a slash. 2023-02-16 22:13:28 +00:00
class-wp-filesystem-ftpext.php Filesystem API: Return `false` for empty paths in FTP `::exists()` methods. 2023-03-16 16:14:22 +00:00
class-wp-filesystem-ftpsockets.php Filesystem API: Return `false` for empty paths in FTP `::exists()` methods. 2023-03-16 16:14:22 +00:00
class-wp-filesystem-ssh2.php Filesystem API: Use `trailingslashit( $path )` instead of `$path . '/'`. Fixes a warning when `$path` already ends with a slash. 2023-02-16 22:13:28 +00:00
class-wp-importer.php Code Modernization: Add `AllowDynamicProperties` attribute to all (parent) classes. 2022-09-12 15:47:14 +00:00
class-wp-internal-pointers.php Code Modernization: Add `AllowDynamicProperties` attribute to all (parent) classes. 2022-09-12 15:47:14 +00:00
class-wp-links-list-table.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
class-wp-list-table-compat.php
class-wp-list-table.php Docs: Miscellaneous improvements and corrections to docblocks. 2023-02-07 21:21:18 +00:00
class-wp-media-list-table.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
class-wp-ms-sites-list-table.php Administration: Remove private delegation from list tables. 2022-10-04 03:47:15 +00:00
class-wp-ms-themes-list-table.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
class-wp-ms-users-list-table.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
class-wp-plugin-install-list-table.php Administration: Remove private delegation from list tables. 2022-10-04 03:47:15 +00:00
class-wp-plugins-list-table.php Coding Standards: Remove unused variable in `WP_Plugins_List_Table::single_row()`. 2023-03-21 13:27:21 +00:00
class-wp-post-comments-list-table.php Administration: Remove private delegation from list tables. 2022-10-04 03:47:15 +00:00
class-wp-posts-list-table.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
class-wp-privacy-data-export-requests-list-table.php Privacy: Fix "Retry" action after a personal data export failure. 2022-03-10 19:22:01 +00:00
class-wp-privacy-data-removal-requests-list-table.php
class-wp-privacy-policy-content.php Docs: Add `www.` prefix to some PHP manual links in code comments. 2023-02-18 14:23:21 +00:00
class-wp-privacy-requests-table.php Administration: Add new `get_views_links` method to `WP_List_Table`. 2022-09-19 21:08:10 +00:00
class-wp-screen.php Docs: Miscellaneous improvements and corrections to docblocks. 2023-02-07 21:21:18 +00:00
class-wp-site-health-auto-updates.php Coding Standards: Always use parentheses when instantiating an object. 2022-11-29 15:51:14 +00:00
class-wp-site-health.php Help/About: Use the new `/documentation/` URLs for HelpHub links in WordPress Admin. 2023-02-23 10:38:21 +00:00
class-wp-site-icon.php Code Modernization: Add `AllowDynamicProperties` attribute to all (parent) classes. 2022-09-12 15:47:14 +00:00
class-wp-terms-list-table.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
class-wp-theme-install-list-table.php Administration: Remove private delegation from list tables. 2022-10-04 03:47:15 +00:00
class-wp-themes-list-table.php Administration: Remove private delegation from list tables. 2022-10-04 03:47:15 +00:00
class-wp-upgrader-skin.php Docs: Clarify the `::hide_process_failed()` return value in plugin and theme installer. 2023-03-27 15:11:20 +00:00
class-wp-upgrader-skins.php
class-wp-upgrader.php General: Check that `set_time_limit()` function is available before using it in core. 2023-02-07 13:28:18 +00:00
class-wp-users-list-table.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
comment.php Docs: Use third-person singular verbs for function descriptions in `wp-admin/includes/comment.php`, as per docblocks standards. 2022-07-20 22:15:10 +00:00
continents-cities.php I18N: Update list of continents and cities for the timezone selection. 2022-09-19 23:24:11 +00:00
credits.php Help/About: Don't output empty `<span>` tags on Credits screen. 2021-10-19 23:09:00 +00:00
dashboard.php Administration: Update dashboard welcome panel colors, remove broken link 2023-03-21 15:37:21 +00:00
deprecated.php Docs: Improve various globals documentation, as per documentation standards. 2022-12-09 11:54:13 +00:00
edit-tag-messages.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
export.php Docs: Improve various globals documentation, as per documentation standards. 2022-12-09 11:54:13 +00:00
file.php Filesystem API: Return correct error data from `copy_dir()` if the directory listing failed. 2023-03-11 11:34:24 +00:00
image-edit.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
image.php Media: Revert WebP generation. 2022-09-19 22:53:10 +00:00
import.php Docs: Various docblock improvements in Importer Administration API, as per docs standards. 2022-07-29 09:22:10 +00:00
list-table.php Administration: Remove private delegation from list tables. 2022-10-04 03:47:15 +00:00
media.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
menu.php Coding Standards: Correct the `$items_count` variable in `add_menu_classes()`. 2022-04-17 14:44:07 +00:00
meta-boxes.php Help/About: Avoid extra redirections on HelpHub Links. 2023-02-23 11:06:19 +00:00
misc.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
ms-admin-filters.php Networks and Sites: Officially remove global terms. 2022-09-20 02:51:09 +00:00
ms-deprecated.php Networks and Sites: Officially remove global terms. 2022-09-20 02:51:09 +00:00
ms.php Help/About: Use a consistent capitalization for "Support forums" links across WP Admin. 2023-02-23 11:13:22 +00:00
nav-menu.php Coding Standards: Escape the whole attributes in `wp-admin/includes/nav-menu.php`. 2023-04-01 08:37:20 +00:00
network.php Help/About: Use the new `/documentation/` URLs for HelpHub links in WordPress Admin. 2023-02-23 10:38:21 +00:00
noop.php Coding Standards: Fix brace indentation in `wp-align/includes/noop.php`. 2022-11-26 09:12:17 +00:00
options.php Help/About: Avoid extra redirections on HelpHub Links. 2023-02-23 11:06:19 +00:00
plugin-install.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
plugin.php Docs: Remove code tags from WordPress function names within inline documentation. 2022-08-11 13:55:08 +00:00
post.php Coding Standards: Rename `$post_ID` variable to `$post_id` in various files. 2023-02-19 15:05:22 +00:00
privacy-tools.php I18N: Introduce `switch_to_user_locale()`. 2023-01-30 10:27:16 +00:00
revision.php Revisions: Use `update_post_author_caches` in `wp_prepare_revisions_for_js` function. 2022-12-06 13:42:13 +00:00
schema.php Coding Standards: Always use parentheses when instantiating an object. 2022-11-29 15:51:14 +00:00
screen.php Coding Standards: Use strict comparison in `wp-admin/includes/screen.php`. 2021-05-09 20:27:02 +00:00
taxonomy.php Coding Standards: Use strict comparison in `wp-admin/includes/taxonomy.php`. 2023-03-10 07:04:20 +00:00
template.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
theme-install.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
theme.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
translation-install.php Coding Standards: Always use parentheses when instantiating an object. 2022-11-29 15:51:14 +00:00
update-core.php Upgrade/Install: Skip preloading Requests for WordPress versions before 4.6. 2023-02-08 15:03:19 +00:00
update.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
upgrade.php HTTP API: Restore one instance of the `X-Pingback` header capitalization. 2023-02-03 14:41:26 +00:00
user.php Coding Standards: Use strict comparison in `wp-admin/includes/user.php`. 2023-03-25 15:25:26 +00:00
widgets.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00