WordPress/wp-includes
Scott Taylor e49980bdc1 `get_comment_count()` currently increments `awaiting_moderation` when comments are in the trash. This occurs because `case 0:` will match any value passed to `switch` that is a string that isn't specified in the list of cases. This is terrifying.
* Cases for `0` and `1` should be `'1'` and `'0'`
* Add unit tests for `get_comment_count()`. Currently, there are none.

See #33414.

Built from https://develop.svn.wordpress.org/trunk@33806


git-svn-id: http://core.svn.wordpress.org/trunk@33774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 02:19:21 +00:00
..
ID3 Update getID3 to 1.9.9 2015-06-28 00:17:25 +00:00
SimplePie
Text Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
certificates WP_HTTP: Revert r30491 which updated the bundled root certificates. There's a report that this is breaking under certain PHP/OpenSSL versions (which we've encountered before), and we're safer with a slighty out of date CA bundle than breaking HTTPS communication on affected sites. 2014-12-07 03:13:22 +00:00
css TinyMCE: fix accessibility for the keyboard shortcuts help dialog. 2015-07-26 19:14:26 +00:00
fonts Dashicons: Fix font ID in SVG file. 2015-07-23 10:03:24 +00:00
images Smilies: Update our few remaining smilies to better align with Twemoji, and add frownie.png until Twemoji provide a build containing it. 2015-04-10 06:20:26 +00:00
js Media: 2015-08-25 12:13:23 +00:00
pomo Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
theme-compat Drop the hyphen from e-mail and standardize on email. 2015-08-28 03:17:21 +00:00
admin-bar.php Fix the summary and parameter description for `wp_admin_bar_customize_menu()` added in 4.3. 2015-07-13 19:58:25 +00:00
atomlib.php Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
author-template.php Pass the original `$user_id` variable to the filter in `get_the_author_meta()`. 2015-05-25 13:06:25 +00:00
bookmark-template.php Sanitize the class passed to `wp_list_bookmarks()` and allow passing an array. 2015-06-22 20:55:28 +00:00
bookmark.php In `bookmark.php`, clarify some `return` docs. 2015-05-21 20:13:25 +00:00
cache.php Docs: Standardize `@deprecated` tag formatting in the DocBlock for `WP_Object_Cache:reset()`. 2015-08-20 22:39:24 +00:00
canonical.php Avoid PHP notices in `redirect_canonical()` and `_wp_menu_item_classes_by_context()` if `$_SERVER['HTTP_HOST']` is not set. 2015-08-28 03:31:20 +00:00
capabilities-functions.php Roles: move classes into their own file. `capbilities.php` loads the new files, so this is 100% BC if someone is loading `capbilities.php` directly. New files created using `svn cp`. 2015-08-26 04:58:21 +00:00
capabilities.php Roles: move classes into their own file. `capbilities.php` loads the new files, so this is 100% BC if someone is loading `capbilities.php` directly. New files created using `svn cp`. 2015-08-26 04:58:21 +00:00
category-template.php In `wp_list_categories()`, 'current_category' should accept an array of values. 2015-08-29 19:46:23 +00:00
category.php Use `void` instead of `null` where appropriate when pipe-delimiting `@return` types. If a `@return` only contains `void`, remove it. 2015-05-24 05:40:25 +00:00
class-IXR.php Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
class-feed.php After [32656], add `@access` annotations to methods that have no doc block in `wp-includes/*`. 2015-05-29 21:37:24 +00:00
class-http.php HTTP: move classes into their own files, `http.php` loads the new files, so this is 100% BC if someone is loading `http.php` directly. New files created using `svn cp`. 2015-08-26 03:55:21 +00:00
class-json.php Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
class-oembed.php Add oEmbed support for ReverbNation. 2015-08-26 00:29:21 +00:00
class-phpass.php Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
class-phpmailer.php Remove debug cruft from [33124]. 2015-07-09 07:56:24 +00:00
class-pop3.php Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
class-simplepie.php Fix some documentation typos in various core files. 2014-08-13 03:56:17 +00:00
class-smtp.php Update PHPMailer to 5.2.10 from 5.2.7. 2015-07-08 17:16:25 +00:00
class-snoopy.php
class-wp-admin-bar.php Toolbar: Disambiguate links to the dashboard vs. to the customizer. 2015-07-08 20:03:24 +00:00
class-wp-ajax-response.php `WP_Ajax_Response` has one property only, `$responses`. It was public until [28508], when it became `private` in name only. Is it worth 4 magic methods to pretend that this property is `private`? It is not. 2015-01-11 00:13:23 +00:00
class-wp-comment-query.php Comments: move `WP_Comment_Query` into its own file. `comment.php` loads the new files, so this is 100% BC if someone is loading `comment.php` directly. New files created using `svn cp`. 2015-08-26 04:27:21 +00:00
class-wp-customize-control.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
class-wp-customize-manager.php Site Icon: Add crop preview to the media modal. 2015-07-20 15:57:25 +00:00
class-wp-customize-nav-menus.php Customizer: Use existing decoupled strings in Menu Locations section. See [31941] and [31951]. 2015-08-25 21:53:20 +00:00
class-wp-customize-panel.php Customizer: Switch buttons to match the focus order with the visual order. 2015-07-29 22:10:24 +00:00
class-wp-customize-section.php Customizer: Hide the transport list when it's empty, especially for screen readers. 2015-07-15 19:59:25 +00:00
class-wp-customize-setting.php Customizer: Ensure that all existing menus are shown in the Custom Menu widget's dropdown. 2015-07-29 16:03:24 +00:00
class-wp-customize-widgets.php Customizer: Use `hash_equals()` for widgets. 2015-08-04 04:51:50 +00:00
class-wp-editor.php In `_WP_Editors::editor_settings()`, `$first_run` is unused. 2015-08-21 18:30:24 +00:00
class-wp-embed.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
class-wp-error.php Use `void` instead of `null` where appropriate when pipe-delimiting `@return` types. If a `@return` only contains `void`, remove it. 2015-05-24 05:40:25 +00:00
class-wp-http-cookie.php HTTP: move classes into their own files, `http.php` loads the new files, so this is 100% BC if someone is loading `http.php` directly. New files created using `svn cp`. 2015-08-26 03:55:21 +00:00
class-wp-http-curl.php HTTP: move classes into their own files, `http.php` loads the new files, so this is 100% BC if someone is loading `http.php` directly. New files created using `svn cp`. 2015-08-26 03:55:21 +00:00
class-wp-http-encoding.php HTTP: move classes into their own files, `http.php` loads the new files, so this is 100% BC if someone is loading `http.php` directly. New files created using `svn cp`. 2015-08-26 03:55:21 +00:00
class-wp-http-ixr-client.php Add missing doc blocks to `wp-image-editor*.php`. 2015-05-22 06:18:25 +00:00
class-wp-http-proxy.php HTTP: move classes into their own files, `http.php` loads the new files, so this is 100% BC if someone is loading `http.php` directly. New files created using `svn cp`. 2015-08-26 03:55:21 +00:00
class-wp-http-streams.php HTTP: move classes into their own files, `http.php` loads the new files, so this is 100% BC if someone is loading `http.php` directly. New files created using `svn cp`. 2015-08-26 03:55:21 +00:00
class-wp-image-editor-gd.php Replace `@returns` with `@return` in PHP docblocks. 2015-07-02 21:05:24 +00:00
class-wp-image-editor-imagick.php Replace `@returns` with `@return` in PHP docblocks. 2015-07-02 21:05:24 +00:00
class-wp-image-editor.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
class-wp-meta-query.php Meta: move `WP_Meta_Query` into its own file. `meta.php` loads the new files, so this is 100% BC if someone is loading `meta.php` directly. New files created using `svn cp`. 2015-08-26 13:02:21 +00:00
class-wp-post.php Posts: move `WP_Post` into its own file. `post.php` loads the new files, so this is 100% BC if someone is loading `post.php` directly. New files created using `svn cp`. 2015-08-26 12:40:21 +00:00
class-wp-rewrite.php Rewrite: move `WP_Rewrite` into its own file. `rewrite.php` loads the new files, so this is 100% BC if someone is loading `rewrite.php` directly. New files created using `svn cp`. 2015-08-26 04:42:20 +00:00
class-wp-role.php Roles: move classes into their own file. `capbilities.php` loads the new files, so this is 100% BC if someone is loading `capbilities.php` directly. New files created using `svn cp`. 2015-08-26 04:58:21 +00:00
class-wp-roles.php Roles: move classes into their own file. `capbilities.php` loads the new files, so this is 100% BC if someone is loading `capbilities.php` directly. New files created using `svn cp`. 2015-08-26 04:58:21 +00:00
class-wp-tax-query.php Taxonomy: move `WP_Tax_Query` into its own file. `taxonomy.php` loads the new files, so this is 100% BC if someone is loading `taxonomy.php` directly. New files created using `svn cp`. 2015-08-26 12:49:21 +00:00
class-wp-theme.php Add `@static*` annotations where they are missing. 2015-05-29 15:43:29 +00:00
class-wp-user-query.php Users: move `WP_User_Query` into its own file. `user.php` loads the new files, so this is 100% BC if someone is loading `user.php` directly (a lot of plugins do). New files created using `svn cp`. 2015-08-26 04:20:21 +00:00
class-wp-user.php Roles: move classes into their own file. `capbilities.php` loads the new files, so this is 100% BC if someone is loading `capbilities.php` directly. New files created using `svn cp`. 2015-08-26 04:58:21 +00:00
class-wp-walker.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
class-wp-widget-factory.php Docs: Add a file header to wp-includes/class-wp-widget-factory.php, created when the `WP_Widget_Factory` class was moved to its own file in [33746]. 2015-08-26 07:53:21 +00:00
class-wp-widget.php Docs: Add a file header to wp-includes/class-wp-widget.php, created when the `WP_Widget` class was moved to its own file in [33746]. 2015-08-26 07:45:21 +00:00
class-wp-xmlrpc-server.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
class-wp.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
class.wp-dependencies.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
class.wp-scripts.php After [32656], add `@access` annotations to methods that have no doc block in `wp-includes/*`. 2015-05-29 21:37:24 +00:00
class.wp-styles.php Add a missing `$html` parameter variable in the hook docs for the `style_loader_tag` filter. 2015-07-13 21:03:24 +00:00
comment-functions.php `get_comment_count()` currently increments `awaiting_moderation` when comments are in the trash. This occurs because `case 0:` will match any value passed to `switch` that is a string that isn't specified in the list of cases. This is terrifying. 2015-08-30 02:19:21 +00:00
comment-template.php Restore `rel='nofollow'` for comment reply links to reduce extra crawling by search engines. 2015-07-02 11:09:25 +00:00
comment.php Comments: move `WP_Comment_Query` into its own file. `comment.php` loads the new files, so this is 100% BC if someone is loading `comment.php` directly. New files created using `svn cp`. 2015-08-26 04:27:21 +00:00
compat.php Add doc blocks to functions that are missing them. 2015-05-31 03:18:25 +00:00
cron.php Fix inline documentation syntax in `wp_xmlrpc_server`. 2015-05-25 06:25:25 +00:00
date.php Simplify the weeks-per-year calculation `WP_Date_Query::validate_date_values()`. 2015-08-29 01:47:21 +00:00
default-constants.php After [33698], wrap the time constants in a DocBlock template. 2015-08-25 21:21:21 +00:00
default-filters.php Term splitting routine should be run in a separate process, triggered via wp-cron. 2015-08-14 03:59:26 +00:00
default-widgets.php Customizer: Ensure that all existing menus are shown in the Custom Menu widget's dropdown. 2015-07-29 16:03:24 +00:00
deprecated.php Docs: Standardize `@deprecated` tag formatting and add missing DocBlock summaries to deprecated functions in wp-includes/deprecated.php. 2015-08-20 22:11:26 +00:00
feed-atom-comments.php `if` is a statment, not a function. 2015-06-16 20:01:25 +00:00
feed-atom.php Introduce 'rss_tag_pre' action, which fires between the xml and rss tags in a feed. 2014-07-07 10:18:15 +00:00
feed-rdf.php Improve various hook and filter docs so they are correctly parsed for the code reference. 2014-12-06 21:32:24 +00:00
feed-rss.php Serve RSS feeds with the proper mime-type: `application/rss+xml`. The reason for hacking around browsers by using `text/xml` appears to no longer be relevant. 2015-05-09 06:39:24 +00:00
feed-rss2-comments.php Feeds: Revert [32765] because of objections raised in #4575. 2015-07-15 19:58:24 +00:00
feed-rss2.php Feeds: Revert [32765] because of objections raised in #4575. 2015-07-15 19:58:24 +00:00
feed.php Site icon: Rearrange function parameters to avoid frequently passing empty values. 2015-08-10 20:15:26 +00:00
formatting.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
functions.php When `wp_json_encode()` calls `json_encode()`, the latter will generate warnings if the string contains non-UTF-8 characters. No-one likes warnings, so we need to do something about that. 2015-08-26 03:26:21 +00:00
functions.wp-scripts.php After [32596] and [32597], ensure that `wp_scripts|styles()` is called to ensure an instance is created of `WP_Scripts|Styles()` before calling `->do_items()`. 2015-06-12 16:54:24 +00:00
functions.wp-styles.php After [32596] and [32597], ensure that `wp_scripts|styles()` is called to ensure an instance is created of `WP_Scripts|Styles()` before calling `->do_items()`. 2015-06-12 16:54:24 +00:00
general-template.php Site Icon: Improvements to Site Icon API. 2015-08-11 16:25:27 +00:00
http-functions.php HTTP: move classes into their own files, `http.php` loads the new files, so this is 100% BC if someone is loading `http.php` directly. New files created using `svn cp`. 2015-08-26 03:55:21 +00:00
http.php HTTP: move classes into their own files, `http.php` loads the new files, so this is 100% BC if someone is loading `http.php` directly. New files created using `svn cp`. 2015-08-26 03:55:21 +00:00
kses.php Allow these CSS properties in KSES: `min-height', 'max-height', 'min-width', 'max-width'` 2015-08-25 21:46:20 +00:00
l10n.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
link-template.php Pass taxonomy name to filters in `get_adjacent_post()`. 2015-08-29 19:59:21 +00:00
load.php Pinking shears. 2015-08-17 21:39:25 +00:00
locale.php Make `WP_Locale::rtl_src_admin_notice()` translatable. 2015-06-30 20:21:24 +00:00
media-template.php Media: 2015-08-25 12:13:23 +00:00
media.php Ensure that `attachment_url_to_postid()` matches cross-scheme when front-end and back-end schemes are different. 2015-08-22 16:39:25 +00:00
meta-functions.php Meta: move `WP_Meta_Query` into its own file. `meta.php` loads the new files, so this is 100% BC if someone is loading `meta.php` directly. New files created using `svn cp`. 2015-08-26 13:02:21 +00:00
meta.php Meta: move `WP_Meta_Query` into its own file. `meta.php` loads the new files, so this is 100% BC if someone is loading `meta.php` directly. New files created using `svn cp`. 2015-08-26 13:02:21 +00:00
ms-blogs.php Fix doc blocks for `ms-*.php` files. 2015-05-26 21:51:31 +00:00
ms-default-constants.php Fix doc blocks for `ms-*.php` files. 2015-05-26 21:51:31 +00:00
ms-default-filters.php Fix doc blocks for `ms-*.php` files. 2015-05-26 21:51:31 +00:00
ms-deprecated.php Docs: Standardize `@deprecated` tag formatting and add missing summaries to deprecated functions in wp-includes/ms-deprecated.php. 2015-08-20 22:36:25 +00:00
ms-files.php `if` is a statment, not a function. 2015-06-16 20:01:25 +00:00
ms-functions.php Exclude individual site directories when calculating space used for the main site. 2015-07-13 00:07:24 +00:00
ms-load.php Fix doc blocks for `ms-*.php` files. 2015-05-26 21:51:31 +00:00
ms-settings.php Move ms-load.php and ms-default-constants.php inclusion back to ms-settings.php to avoid breaking WP-CLI. 2014-06-30 23:50:15 +00:00
nav-menu-template.php Avoid PHP notices in `redirect_canonical()` and `_wp_menu_item_classes_by_context()` if `$_SERVER['HTTP_HOST']` is not set. 2015-08-28 03:31:20 +00:00
nav-menu.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
option.php Docs: Add a changelog entry to the `set_site_transient_$transient` hook doc for the `$transient` parameter, added in [33738]. 2015-08-28 15:41:21 +00:00
pluggable-deprecated.php Docs: Standardize `@deprecated` tag formatting for deprecated functions in wp-includes/pluggable-deprecated.php. 2015-08-20 22:15:25 +00:00
pluggable.php Drop the hyphen from e-mail and standardize on email. 2015-08-28 03:17:21 +00:00
plugin.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
post-formats.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
post-functions.php In `get_post_type_labels()`, ensure that filtered labels contain all required default values. 2015-08-28 03:39:21 +00:00
post-template.php In `wp_get_attachment_link()`, accept an `id` or `WP_Post` as the first parameter. 2015-08-20 20:32:26 +00:00
post-thumbnail-template.php Add missing doc blocks to `post-thumbnail-template.php`. 2015-05-27 16:29:28 +00:00
post.php Posts: move `WP_Post` into its own file. `post.php` loads the new files, so this is 100% BC if someone is loading `post.php` directly. New files created using `svn cp`. 2015-08-26 12:40:21 +00:00
query.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
registration-functions.php
registration.php
revision.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
rewrite-constants.php Rewrite: move `WP_Rewrite` into its own file. `rewrite.php` loads the new files, so this is 100% BC if someone is loading `rewrite.php` directly. New files created using `svn cp`. 2015-08-26 04:42:20 +00:00
rewrite-functions.php Rewrite: move `WP_Rewrite` into its own file. `rewrite.php` loads the new files, so this is 100% BC if someone is loading `rewrite.php` directly. New files created using `svn cp`. 2015-08-26 04:42:20 +00:00
rewrite.php Rewrite: move `WP_Rewrite` into its own file. `rewrite.php` loads the new files, so this is 100% BC if someone is loading `rewrite.php` directly. New files created using `svn cp`. 2015-08-26 04:42:20 +00:00
rss-functions.php
rss.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
script-loader.php Editor: word count: Remove indentation from the translator comment. 2015-07-30 17:08:24 +00:00
session.php Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions: 2015-01-16 22:51:21 +00:00
shortcodes.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
taxonomy-functions.php Taxonomy: move `WP_Tax_Query` into its own file. `taxonomy.php` loads the new files, so this is 100% BC if someone is loading `taxonomy.php` directly. New files created using `svn cp`. 2015-08-26 12:49:21 +00:00
taxonomy.php Taxonomy: move `WP_Tax_Query` into its own file. `taxonomy.php` loads the new files, so this is 100% BC if someone is loading `taxonomy.php` directly. New files created using `svn cp`. 2015-08-26 12:49:21 +00:00
template-loader.php Add singular.php to template hierarchy 2015-06-18 19:01:26 +00:00
template.php Docs: Update the DocBlock descriptions for a variety of template functions to better reflect that the dynamic `$type_template` hook can be used to filter the template path. 2015-07-14 22:27:24 +00:00
theme.php Clarify doc entry for `_wp_customize_include()` 2015-08-21 17:45:25 +00:00
update.php Add missing doc blocks to `update.php`: 2015-05-28 15:29:28 +00:00
user-functions.php Drop the hyphen from e-mail and standardize on email. 2015-08-28 03:17:21 +00:00
user.php Users: move `WP_User_Query` into its own file. `user.php` loads the new files, so this is 100% BC if someone is loading `user.php` directly (a lot of plugins do). New files created using `svn cp`. 2015-08-26 04:20:21 +00:00
vars.php Some doc blocks should use `bool` instead of `true|false` 2015-06-27 00:45:24 +00:00
version.php `get_comment_count()` currently increments `awaiting_moderation` when comments are in the trash. This occurs because `case 0:` will match any value passed to `switch` that is a string that isn't specified in the list of cases. This is terrifying. 2015-08-30 02:19:21 +00:00
widget-functions.php Docs: Add a file header description and `@since` version to wp-includes/widget-functions.php, introduced in [33746]. 2015-08-26 07:57:20 +00:00
widgets.php Docs: Add inline-docblocks for the `require_once()` calls that now bring in the `WP_Widget` and `WP_Widget_Factory` classes, as well as general core widgets functionality, as of [33746]. 2015-08-26 08:01:20 +00:00
wlwmanifest.xml
wp-db.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
wp-diff.php Add a missing description for the `$_diff_threshold` property in the `WP_Text_Diff_Renderer_Table` class. 2015-01-29 11:36:22 +00:00