Scott Taylor 2f513d3320 Fix some hackificator odds and ends in wp-admin: ...

* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28500


git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd

2014-05-19 05:04:16 +00:00

..

css

Widgets: Toggle widget arrow when widget is open/closed.

2014-05-01 14:09:16 +00:00

images

Convert the post lock icon to a dashicon.

2014-03-04 06:53:14 +00:00

includes

Fix some hackificator odds and ends in wp-admin:

2014-05-19 05:04:16 +00:00

js

DFW: fix closing only the wpLink or media modal when pressing Esc.

2014-05-16 18:17:14 +00:00

maint

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

network

Fix some hackificator odds and ends in wp-admin:

2014-05-19 05:04:16 +00:00

user

Add missing Dashicons classes to User Admin menu.

2014-05-06 07:58:15 +00:00

about.php

The About page has a <div> that doesn't close. Also, <hr>s should self-close. hackificator complains about these things.

2014-05-18 20:33:15 +00:00

admin-ajax.php

Because the WP_ADMIN constant name can be bound in multiple files, all instances should check ! defined first. wp-admin/admin.php already has this check.

2014-05-18 20:42:16 +00:00

admin-footer.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

admin-functions.php

First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.

2013-12-24 18:57:12 +00:00

admin-header.php

Correct misleading verbiage in 'print' hook docs.

2014-03-25 08:05:15 +00:00

admin-post.php

Because the WP_ADMIN constant name can be bound in multiple files, all instances should check ! defined first. wp-admin/admin.php already has this check.

2014-05-18 20:42:16 +00:00

admin.php

Because the WP_ADMIN constant name can be bound in multiple files, all instances should check ! defined first. wp-admin/admin.php already has this check.

2014-05-18 20:42:16 +00:00

async-upload.php

hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' )

2014-05-18 20:52:15 +00:00

comment.php

hackificator bails on this file because of mixed quote styles on some HTML attributes.

2014-05-18 21:47:14 +00:00

credits.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

custom-background.php

Use proper access modifiers and add a magic __get() method to Custom_Background and Custom_Image_Header.

2014-05-18 21:31:16 +00:00

custom-header.php

Remove public keyword from some JS functions. Sorry.

2014-05-18 21:43:14 +00:00

customize.php

hackificator bails on this file because the <meta> isn't self-closing.

2014-05-18 21:36:15 +00:00

edit-comments.php

Comments: Update border color and help text.

2014-03-27 05:08:14 +00:00

edit-form-advanced.php

Don't show featured images for image attachments. Remove abstractions for now.

2014-04-08 17:40:28 +00:00

edit-form-comment.php

hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.

2014-05-19 01:59:15 +00:00

edit-link-form.php

In edit-link-form.php, hackificator bails because there is a </form> with no open <form>. It exists, but is needlessly constructed with PHP. It always returns a <form>, only the id and name are different. The dynamic piece just returns the ID now.

2014-05-18 22:07:15 +00:00

edit-tag-form.php

Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712.

2014-01-24 19:06:15 +00:00

edit-tags.php

Remove unreachable break statements in wp-admin/edit-tags.php. break is unnecessary after die, exit, and wp_die.

2014-05-06 14:52:16 +00:00

edit.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

export.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

freedoms.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

import.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

index.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

install-helper.php

Remove all @package and @subpackage PHPDoc tags not at the file- or class-levels in core.

2014-02-25 17:14:14 +00:00

install.php

Eliminate use of extract() in display_setup_form(). Only needs to read password and password_message.

2014-05-14 16:43:15 +00:00

link-add.php

…

link-manager.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

link-parse-opml.php

Remove all @package and @subpackage PHPDoc tags not at the file- or class-levels in core.

2014-02-25 17:14:14 +00:00

link.php

In wp-admin/link.php, break is unreachabled after exit.

2014-05-06 18:06:14 +00:00

load-scripts.php

…

load-styles.php

Force UTF-8 in load-styles.php, like we do in load-scripts.php.

2014-02-25 01:28:15 +00:00

media-new.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

media-upload.php

Inline documentation for hooks in wp-admin/media-upload.php.

2014-01-08 04:00:11 +00:00

media.php

Fix some hackificator odds and ends in wp-admin:

2014-05-19 05:04:16 +00:00

menu-header.php

Admin Menu: Use .dashicons-before as default $img_class.

2014-03-05 23:22:15 +00:00

menu.php

Introduce a .dashicons-before CSS class.

2014-03-05 20:04:14 +00:00

moderation.php

…

ms-admin.php

…

ms-delete-site.php

Always decode special characters for email subjects.

2014-03-28 02:44:15 +00:00

ms-edit.php

…

ms-options.php

…

ms-sites.php

…

ms-themes.php

…

ms-upgrade-network.php

…

ms-users.php

…

my-sites.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

nav-menus.php

Use '— Select —' instead of '-- Select --' for nav menus. Looks nicer.

2014-04-25 00:35:25 +00:00

network.php

hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.

2014-05-19 01:59:15 +00:00

options-discussion.php

Priority fixes for various existing hook documentation.

2014-04-12 00:01:15 +00:00

options-general.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

options-head.php

…

options-media.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

options-permalink.php

Permalink Settings: Don't show "update your .htaccess now" if nothing needs to change.

2014-03-15 04:35:16 +00:00

options-reading.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

options-writing.php

Priority fixes for various existing hook documentation.

2014-04-12 00:01:15 +00:00

options.php

Fix some hackificator odds and ends in wp-admin:

2014-05-19 05:04:16 +00:00

plugin-editor.php

In wp-admin/plugin-editor.php, break is unreachabled after exit.

2014-05-06 18:12:14 +00:00

plugin-install.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

plugins.php

In wp-admin/plugins.php, break is unreachabled after exit.

2014-05-06 18:13:14 +00:00

post-new.php

…

post.php

In wp-admin/post.php, break is unreachabled after exit.

2014-05-06 18:15:15 +00:00

press-this.php

Make sure inputs in Press This have a type so they are styled appropriately. see #18380.

2014-03-27 02:39:14 +00:00

profile.php

…

revision.php

Fix some hackificator odds and ends in wp-admin:

2014-05-19 05:04:16 +00:00

setup-config.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

theme-editor.php

Fix some hackificator odds and ends in wp-admin:

2014-05-19 05:04:16 +00:00

theme-install.php

Update help text on Add Themes screen.

2014-05-17 23:44:15 +00:00

themes.php

Fix some hackificator odds and ends in wp-admin:

2014-05-19 05:04:16 +00:00

tools.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

update-core.php

Fix some hackificator odds and ends in wp-admin:

2014-05-19 05:04:16 +00:00

update.php

Fix some hackificator odds and ends in wp-admin:

2014-05-19 05:04:16 +00:00

upgrade-functions.php

First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.

2013-12-24 18:57:12 +00:00

upgrade.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

upload.php

Use SSL when linking to WordPress.org. see #27115.

2014-03-08 04:14:15 +00:00

user-edit.php

hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' )

2014-05-18 20:52:15 +00:00

user-new.php

Add a value to the password checkbox when creating a new user so the toggle is remembered.

2014-03-29 06:23:17 +00:00

users.php

Fix some hackificator odds and ends in wp-admin:

2014-05-19 05:04:16 +00:00

widgets.php

The sidebar_admin_setup hook should only be documented once in wp-admin/widgets.php. All others are duplicates.

2014-03-28 19:47:15 +00:00