WordPress/wp-admin/includes
hellofromTonya 4cbe355f0b Plugins: Ensure wp_get_plugin_action_button() returns a string.
[57545] introduced `wp_get_plugin_action_button()`. This function is documented to return a `string`. However, if the user does not have the appropriate capabilities, it returned `void`, which is unexpected.

Resolves the issue by moving the `return $button` to the bottom of the function to ensure it always returns a `string` type. On success, the button's HTML string is returned; else, an empty string is returned.

Unit tests are included.

Follow-up to [57545].

Props costdev, rajinsharwar, hellofromTonya.
Fixes #61400.
Built from https://develop.svn.wordpress.org/trunk@58396


git-svn-id: http://core.svn.wordpress.org/trunk@57845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-06-12 18:17:13 +00:00
..
admin-filters.php Script Loader: Replace hardcoded output of style tags with calls to `wp_add_inline_style`. 2023-09-25 17:06:34 +00:00
admin.php General: add nonce for block theme preview activation. 2023-07-11 05:03:23 +00:00
ajax-actions.php Coding Standards: Use strict comparison in `wp-admin/includes/ajax-actions.php`. 2024-06-02 22:10:11 +00:00
bookmark.php Docs: Various improvements in Bookmark Administration API function descriptions, as per docblocks standards. 2023-05-03 10:03:21 +00:00
class-automatic-upgrader-skin.php Code Modernization: Replace usage of `strpos()` with `str_contains()`. 2023-06-22 14:36:26 +00:00
class-bulk-plugin-upgrader-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-bulk-theme-upgrader-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-bulk-upgrader-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-core-upgrader.php Upgrade/Install: Remove the download authenticity message from Core/Plugins/Themes updates. 2024-06-04 06:30:16 +00:00
class-custom-background.php Docs: Improve documentation for `Custom_Image_Header` and `Custom_Background` constructors. 2023-12-07 15:14:27 +00:00
class-custom-image-header.php Media: Accessibility: Copy attachment properties on site icon crop. 2024-03-02 20:15:13 +00:00
class-file-upload-upgrader.php Upload: Add links back to installer pages. 2024-03-07 05:58:15 +00:00
class-ftp-pure.php
class-ftp-sockets.php
class-ftp.php Filesystem API: Fix typo in `ftp_base::restore()`. 2024-02-12 12:07:10 +00:00
class-language-pack-upgrader-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-language-pack-upgrader.php I18N: Actually add all the files for [58061], not just the test fixtures. 2024-04-30 08:39:07 +00:00
class-pclzip.php Docs: Fix a few typos in `wp-admin/includes/class-pclzip.php`. 2024-03-31 05:52:15 +00:00
class-plugin-installer-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-plugin-upgrader-skin.php Docs: Use third-person singular verbs in various function descriptions, as per docblocks standards. 2023-06-14 06:34:27 +00:00
class-plugin-upgrader.php Plugin Dependencies: Remove auto-deactivation and bootstrapping logic. 2024-02-20 07:27:06 +00:00
class-theme-installer-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-theme-upgrader-skin.php Upgrade/Install: Improve localized strings related to plugin/theme installation and activation. 2024-02-26 20:35:08 +00:00
class-theme-upgrader.php Upgrade/Install: Check theme compatibility during bulk upgrades. 2024-01-08 23:19:16 +00:00
class-walker-category-checklist.php Docs: Wrap inline `@see` tags in curly braces. 2023-08-24 09:01:16 +00:00
class-walker-nav-menu-checklist.php Coding Standards: Remove superfluous blank lines at the end of various classes. 2023-09-08 09:32:23 +00:00
class-walker-nav-menu-edit.php Coding Standards: Restore more descriptive variable names in a few class methods. 2023-09-14 12:46:20 +00:00
class-wp-ajax-upgrader-skin.php Code Modernization: Replace usage of `strpos()` with `str_contains()`. 2023-06-22 14:36:26 +00:00
class-wp-application-passwords-list-table.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
class-wp-automatic-updater.php Upgrade/Install: Make `$is_debug` consistent in `WP_Automatic_Updater`. 2024-06-03 21:39:08 +00:00
class-wp-comments-list-table.php Posts, Post Types: Use a consistent plural form of “status” in variable names. 2024-05-10 18:09:15 +00:00
class-wp-community-events.php Coding Standards: Include one space after `function` keyword for closures. 2023-09-12 15:23:18 +00:00
class-wp-debug-data.php Site Health: Add a `wp_is_writable()` for fonts directory. 2024-06-03 21:57:07 +00:00
class-wp-filesystem-base.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
class-wp-filesystem-direct.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
class-wp-filesystem-ftpext.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
class-wp-filesystem-ftpsockets.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
class-wp-filesystem-ssh2.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
class-wp-importer.php Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-importer.php`. 2023-08-14 09:59:20 +00:00
class-wp-internal-pointers.php Docs: Use third-person singular verbs in various function descriptions, as per docblocks standards. 2023-06-14 12:57:20 +00:00
class-wp-links-list-table.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
class-wp-list-table-compat.php
class-wp-list-table.php Administration: Remove redundant type casting in `WP_List_Table::search_box()`. 2024-06-11 12:38:14 +00:00
class-wp-media-list-table.php Administration: Switch order of label/checkbox in `WP_List_Table`. 2023-09-22 19:58:16 +00:00
class-wp-ms-sites-list-table.php Upgrade/Install: Improve localized strings related to plugin/theme installation and activation. 2024-02-26 20:35:08 +00:00
class-wp-ms-themes-list-table.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
class-wp-ms-users-list-table.php Docs: Fix typo in the `ms_user_list_site_class` filter description. 2023-11-15 09:33:26 +00:00
class-wp-plugin-install-list-table.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
class-wp-plugins-list-table.php Administration: A11y: Replace placeholders with visible labels. 2024-05-14 16:49:09 +00:00
class-wp-post-comments-list-table.php
class-wp-posts-list-table.php Administration: Switch order of label/checkbox in `WP_List_Table`. 2023-09-22 19:58:16 +00:00
class-wp-privacy-data-export-requests-list-table.php
class-wp-privacy-data-removal-requests-list-table.php Coding Standards: Remove superfluous blank lines at the end of various classes. 2023-09-08 09:32:23 +00:00
class-wp-privacy-policy-content.php Privacy: Update default privacy page content to use latest block markup. 2024-02-29 12:17:08 +00:00
class-wp-privacy-requests-table.php Administration: Switch order of label/checkbox in `WP_List_Table`. 2023-09-22 19:58:16 +00:00
class-wp-screen.php Administration: Remove invalid attribute `maxlength` on `number` input. 2024-01-11 17:44:12 +00:00
class-wp-site-health-auto-updates.php Coding Standards: Upgrade WPCS to version 3.0.0. 2023-09-26 00:27:12 +00:00
class-wp-site-health.php Site Health: Ensure each alloptions value is serialized. 2024-06-04 19:34:16 +00:00
class-wp-site-icon.php Media: Accessibility: Copy attachment properties on site icon crop. 2024-03-02 20:15:13 +00:00
class-wp-terms-list-table.php Administration: Switch order of label/checkbox in `WP_List_Table`. 2023-09-22 19:58:16 +00:00
class-wp-theme-install-list-table.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
class-wp-themes-list-table.php Upgrade/Install: Improve localized strings related to plugin/theme installation and activation. 2024-02-26 20:35:08 +00:00
class-wp-upgrader-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-wp-upgrader-skins.php
class-wp-upgrader.php Upgrade/Install: Remove the download authenticity message from Core/Plugins/Themes updates. 2024-06-04 06:30:16 +00:00
class-wp-users-list-table.php Docs: Correct some typos in docblocks and inline comments. 2024-01-10 11:57:15 +00:00
comment.php
continents-cities.php
credits.php Code Modernization: Replace usage of `strpos()` with `str_contains()`. 2023-06-22 14:36:26 +00:00
dashboard.php I18N: Add Translator comments for Planet URLs. 2024-02-08 20:36:14 +00:00
deprecated.php Docs: Correct some typos in docblocks and inline comments. 2024-01-10 11:57:15 +00:00
edit-tag-messages.php
export.php Code Modernization: Fix implicit nullable parameter type deprecation on PHP 8.4. 2024-04-15 20:03:09 +00:00
file.php HTTP API: Improve `download_url()` error message. 2024-05-27 13:55:12 +00:00
image-edit.php Media: Improve scale/crop layout in image editor medium breakpoints. 2024-05-27 18:03:13 +00:00
image.php Media: Accessibility: Copy attachment properties on site icon crop. 2024-03-02 20:15:13 +00:00
import.php
list-table.php
media.php Docs: Correct DocBlock formatting for `activate_tinymce_for_media_description`. 2024-06-09 22:53:14 +00:00
menu.php Docs: Replace incorrect `@private` tags. 2023-11-06 09:27:23 +00:00
meta-boxes.php I18n: Add more context to the overall use of `none` in translatable strings. 2024-06-02 21:07:13 +00:00
misc.php Docs: Various docblock improvements. 2024-05-02 13:19:14 +00:00
ms-admin-filters.php
ms-deprecated.php
ms.php Docs: Update a HelpHub link on Edit Site screen to avoid unnecessary redirection. 2024-05-11 14:47:06 +00:00
nav-menu.php General: Consistently cast return value to `int` in functions that use `ceil()`. 2024-02-17 15:24:08 +00:00
network.php Bootstrap/Load: Take the port number into consideration when determining whether a subdomain installation of Multisite is allowed. 2024-05-09 23:09:13 +00:00
noop.php Themes: Fix fatal error in `load-styles.php`. 2023-09-21 01:27:26 +00:00
options.php Site icon: Polish up Site Icon on the general settings screen. 2024-02-26 20:18:09 +00:00
plugin-install.php Plugins: Ensure wp_get_plugin_action_button() returns a string. 2024-06-12 18:17:13 +00:00
plugin.php Coding Standards: Remove extra conditional in `get_plugins()`. 2024-04-30 16:45:14 +00:00
post.php Coding Standards: Use strict comparison in `wp-admin/includes/post.php`. 2024-06-07 12:29:15 +00:00
privacy-tools.php Code Modernization: Replace usage of `strpos()` with `str_contains()`. 2023-06-22 14:36:26 +00:00
revision.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
schema.php Options: Update default autoload values used in core. 2024-05-06 16:35:19 +00:00
screen.php
taxonomy.php
template.php Docs: Consistently document the `$body_id` global as a string. 2023-12-11 12:11:22 +00:00
theme-install.php Upgrade/Install: Improve localized strings related to plugin/theme installation and activation. 2024-02-26 20:35:08 +00:00
theme.php Coding Standards: Remove some extra trailing spaces. 2024-03-05 11:54:13 +00:00
translation-install.php
update-core.php Upgrade/Install: Update the `$_old_files` array for 6.5. 2024-04-01 16:38:18 +00:00
update.php I18N: Fix plural usage in `wp_print_admin_notice_templates()`. 2024-04-30 08:55:04 +00:00
upgrade.php Docs: Add a description for the `$table_prefix` global. 2024-03-07 06:11:11 +00:00
user.php Docs: Improve some DocBlocks and inline comments per the documentation standards. 2023-11-17 13:29:26 +00:00
widgets.php Coding Standards: Use pre-increment/decrement for stand-alone statements. 2023-09-09 09:28:26 +00:00