From 09a92f34388042b9e3fe8f74c96cfe2718bad8c2 Mon Sep 17 00:00:00 2001
From: Roman Rizzi <rizziromanalejandro@gmail.com>
Date: Tue, 16 Jul 2019 11:35:16 -0300
Subject: [PATCH] DEV: migrate no_ads_for_groups to use IDs instead of group
 names (#77)

---
 .../discourse/components/ad-component.js.es6  | 19 ++++++++++++++-----
 plugin.rb                                     |  5 +++++
 2 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/assets/javascripts/discourse/components/ad-component.js.es6 b/assets/javascripts/discourse/components/ad-component.js.es6
index 52393bb..1cfd7a4 100644
--- a/assets/javascripts/discourse/components/ad-component.js.es6
+++ b/assets/javascripts/discourse/components/ad-component.js.es6
@@ -46,12 +46,21 @@ export default Ember.Component.extend({
       return true;
     }
 
-    const groupNames = groups.map(g => g.name.toLowerCase());
-    const noAdsGroupNames = this.siteSettings.no_ads_for_groups
-      .split("|")
-      .map(g => g.toLowerCase());
+    let noAdsGroups = this.siteSettings.no_ads_for_groups
+        .split("|")
 
-    return !groupNames.any(g => noAdsGroupNames.includes(g));
+    // TODO: Remove when 2.4 becomes the new stable. This is for backwards compatibility.
+    const groupListUseIDs = this.site.group_list_use_ids;
+
+    let currentGroups = groups;
+    if (groupListUseIDs) {
+      currentGroups = currentGroups.map(g => g.id.toString());
+    } else {
+      currentGroups = currentGroups.map(g => g.name.toLowerCase());
+      noAdsGroups = noAdsGroups.map(g => g.toLowerCase());
+    }
+
+    return !currentGroups.any(g => noAdsGroups.includes(g));
   },
 
   @computed(
diff --git a/plugin.rb b/plugin.rb
index 7c5aa5d..ea513bc 100755
--- a/plugin.rb
+++ b/plugin.rb
@@ -35,6 +35,11 @@ after_initialize do
   require_dependency File.expand_path('../app/controllers/house_ad_settings_controller', __FILE__)
   require_dependency 'application_controller'
 
+  # TODO: remove when 2.4 becomes the new stable
+  current_version = ActiveRecord::Migrator.current_version
+  min_version = 201_907_081_533_31
+  add_to_serializer(:site, :group_list_use_ids) { current_version >= min_version }
+
   add_to_serializer :site, :house_creatives do
     AdPlugin::HouseAdSetting.settings_and_ads
   end