From 71c51ebd8b088754f2dbb3bf806da991c80d2df5 Mon Sep 17 00:00:00 2001 From: Neil Lalonde Date: Wed, 17 Jul 2019 14:05:45 -0400 Subject: [PATCH] FIX: ads always showing in all placements for CodeFund and Carbon Ads Checkboxes used to choose which placements to have ads were not handled correctly. --- assets/javascripts/discourse/components/ad-slot.js.es6 | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/assets/javascripts/discourse/components/ad-slot.js.es6 b/assets/javascripts/discourse/components/ad-slot.js.es6 index e4f1ab6..02d3261 100644 --- a/assets/javascripts/discourse/components/ad-slot.js.es6 +++ b/assets/javascripts/discourse/components/ad-slot.js.es6 @@ -117,7 +117,11 @@ export default AdComponent.extend({ }${placeUnderscored}_code`; } - if (name !== false && !Ember.isBlank(this.siteSettings[name])) { + if ( + name !== false && + this.siteSettings[name] !== false && + !Ember.isBlank(this.siteSettings[name]) + ) { types.push(adNetwork); } }