mirror of
https://github.com/discourse/discourse-adplugin.git
synced 2025-03-09 13:19:11 +00:00
554f03f3da
# Description
This PR adds the ability to apply **group** and **category** restrictions to a **house ad**.
# What is included
- In order to get the group and category selectors to work within `admin/assets/javascripts/discourse/controllers/admin-plugins-house-ads-show.js` I needed to modernize the file.
- I dropped the `bufferedProperty` implementation in favor of a vanilla ember approach
- I added `category_ids` and `group_ids` to our house ads model
- I added tests for group / category restrictions
- I added a preview button to display the house ad
- `/site.json` would return a object called `house_creatives` and a list of key value pairs that matched the ad name with the html, like so:
```js
{ AD_KEY: ad.html }
```
I need access to the category ids on the client to conditionally render the house ads so the new format will be:
```js
{ AD_KEY: { html: ad.html, category_ids: ad.category_ids } }
```
# Screenshots
<img width="658" alt="Screenshot 2024-04-08 at 2 39 22 PM" src="https://github.com/discourse/discourse-adplugin/assets/50783505/b44b386d-65a1-4a2a-a487-d735b13357dd">
# Preview Video
https://github.com/discourse/discourse-adplugin/assets/50783505/6d0d8253-afef-4e15-b6fc-c6f696efd169
94 lines
2.7 KiB
Ruby
Executable File
94 lines
2.7 KiB
Ruby
Executable File
# frozen_string_literal: true
|
|
|
|
# name: discourse-adplugin
|
|
# about: Allows admins to configure advertisements, and integrates with external ad platforms.
|
|
# meta_topic_id: 33734
|
|
# version: 1.2.5
|
|
# authors: Vi and Sarah (@ladydanger and @cyberkoi)
|
|
# url: https://github.com/discourse/discourse-adplugin
|
|
|
|
register_asset "stylesheets/adplugin.scss"
|
|
|
|
add_admin_route "admin.adplugin.house_ads.title", "houseAds"
|
|
|
|
enabled_site_setting :discourse_adplugin_enabled
|
|
|
|
module ::AdPlugin
|
|
def self.plugin_name
|
|
"discourse-adplugin".freeze
|
|
end
|
|
|
|
def self.pstore_get(key)
|
|
PluginStore.get(AdPlugin.plugin_name, key)
|
|
end
|
|
|
|
def self.pstore_set(key, value)
|
|
PluginStore.set(AdPlugin.plugin_name, key, value)
|
|
end
|
|
|
|
def self.pstore_delete(key)
|
|
PluginStore.remove(AdPlugin.plugin_name, key)
|
|
end
|
|
end
|
|
|
|
after_initialize do
|
|
require_relative "app/models/house_ad"
|
|
require_relative "app/models/house_ad_setting"
|
|
require_relative "app/controllers/house_ads_controller"
|
|
require_relative "app/controllers/house_ad_settings_controller"
|
|
require_relative "app/controllers/adstxt_controller"
|
|
require_relative "lib/adplugin/guardian_extensions"
|
|
|
|
reloadable_patch { Guardian.prepend ::AdPlugin::GuardianExtensions }
|
|
|
|
add_to_serializer :site, :house_creatives do
|
|
AdPlugin::HouseAdSetting.settings_and_ads(for_anons: scope.anonymous?, scope: scope)
|
|
end
|
|
|
|
add_to_serializer :topic_view, :tags_disable_ads do
|
|
return false if !SiteSetting.tagging_enabled || !SiteSetting.no_ads_for_tags.present?
|
|
return false if object.topic.tags.empty?
|
|
!(SiteSetting.no_ads_for_tags.split("|") & object.topic.tags.map(&:name)).empty?
|
|
end
|
|
|
|
add_to_serializer :current_user, :show_dfp_ads do
|
|
scope.show_dfp_ads?
|
|
end
|
|
|
|
add_to_serializer :current_user, :show_adsense_ads do
|
|
scope.show_adsense_ads?
|
|
end
|
|
|
|
add_to_serializer :current_user, :show_carbon_ads do
|
|
scope.show_carbon_ads?
|
|
end
|
|
|
|
add_to_serializer :current_user, :show_amazon_ads do
|
|
scope.show_amazon_ads?
|
|
end
|
|
|
|
add_to_serializer :current_user, :show_adbutler_ads do
|
|
scope.show_adbutler_ads?
|
|
end
|
|
|
|
add_to_serializer :current_user, :show_to_groups do
|
|
scope.show_to_groups?
|
|
end
|
|
|
|
class AdPlugin::Engine < ::Rails::Engine
|
|
engine_name "adplugin"
|
|
isolate_namespace AdPlugin
|
|
end
|
|
|
|
AdPlugin::Engine.routes.draw do
|
|
root to: "house_ads#index"
|
|
resources :house_creatives, only: %i[index show create update destroy], controller: "house_ads"
|
|
resources :house_settings, only: [:update], controller: "house_ad_settings"
|
|
end
|
|
|
|
Discourse::Application.routes.append do
|
|
get "/ads.txt" => "adstxt#index"
|
|
mount ::AdPlugin::Engine, at: "/admin/plugins/pluginad", constraints: AdminConstraint.new
|
|
end
|
|
end
|