From 081231a6ebedca5685c6eef623434732a85ea24e Mon Sep 17 00:00:00 2001
From: Sam <sam.saffron@gmail.com>
Date: Tue, 6 Jun 2023 07:09:33 +1000
Subject: [PATCH] FIX: support multiple command executions (#85)

Previous to this change we were chaining stuff too late and would execute
commands serially leading to very unexpected results

This corrects this and allows us to run stuff like:

> Search google 3/4 times on various permutations of
QUERY and answer this question.

We limit at 5 commands to ensure there are not pathological user cases
where you lean on the LLM to flood us with results.
---
 lib/modules/ai_bot/bot.rb           | 50 +++++++++++++++++++++--------
 spec/lib/modules/ai_bot/bot_spec.rb |  6 +++-
 2 files changed, 41 insertions(+), 15 deletions(-)

diff --git a/lib/modules/ai_bot/bot.rb b/lib/modules/ai_bot/bot.rb
index fdd5923d..51265e25 100644
--- a/lib/modules/ai_bot/bot.rb
+++ b/lib/modules/ai_bot/bot.rb
@@ -34,6 +34,14 @@ module DiscourseAi
         )
       end
 
+      def max_commands_per_reply=(val)
+        @max_commands_per_reply = val
+      end
+
+      def max_commands_per_reply
+        @max_commands_per_reply || 5
+      end
+
       def reply_to(
         post,
         total_completions: 0,
@@ -103,26 +111,40 @@ module DiscourseAi
             skip_revision: true,
           )
 
-          cmd_text = reply.split("\n").detect { |l| l[0] == "!" }
+          cmd_texts = reply.split("\n").filter { |l| l[0] == "!" }
 
-          if cmd_text
+          chain = false
+          standalone = false
+
+          cmd_texts[0...max_commands_per_reply].each do |cmd_text|
             command_name, args = cmd_text[1..-1].strip.split(" ", 2)
 
             if command_klass = available_commands.detect { |cmd| cmd.invoked?(command_name) }
               command = command_klass.new(bot_user, args)
-              chain = command.invoke_and_attach_result_to(bot_reply_post)
-
-              if chain
-                reply_to(
-                  bot_reply_post,
-                  total_completions: total_completions + 1,
-                  bot_reply_post: bot_reply_post,
-                  prefer_low_cost: command.low_cost?,
-                  standalone: command.standalone?,
-                )
-              end
+              chain_intermediate = command.invoke_and_attach_result_to(bot_reply_post)
+              chain ||= chain_intermediate
+              standalone ||= command.standalone?
             end
-          elsif post_custom_prompt = bot_reply_post.post_custom_prompt
+          end
+
+          if cmd_texts.length > max_commands_per_reply
+            raw = +bot_reply_post.raw.dup
+            cmd_texts[max_commands_per_reply..-1].each { |cmd_text| raw.sub!(cmd_text, "") }
+
+            bot_reply_post.raw = raw
+            bot_reply_post.save!(validate: false)
+          end
+
+          if chain
+            reply_to(
+              bot_reply_post,
+              total_completions: total_completions + 1,
+              bot_reply_post: bot_reply_post,
+              standalone: standalone,
+            )
+          end
+
+          if cmd_texts.length == 0 && (post_custom_prompt = bot_reply_post.post_custom_prompt)
             prompt = post_custom_prompt.custom_prompt
             prompt << [reply, bot_user.username]
             post_custom_prompt.update!(custom_prompt: prompt)
diff --git a/spec/lib/modules/ai_bot/bot_spec.rb b/spec/lib/modules/ai_bot/bot_spec.rb
index 13c6f144..9f410431 100644
--- a/spec/lib/modules/ai_bot/bot_spec.rb
+++ b/spec/lib/modules/ai_bot/bot_spec.rb
@@ -42,8 +42,10 @@ RSpec.describe DiscourseAi::AiBot::Bot do
   describe "#reply_to" do
     it "can respond to !search" do
       bot.system_prompt_style!(:simple)
+      bot.max_commands_per_reply = 2
 
-      expected_response = "ok, searching...\n!search test search"
+      expected_response =
+        "ok, searching...\n!search test search\n!search test2 search\n!search test3 ignored"
 
       prompt = bot.bot_prompt_with_topic_context(second_post)
 
@@ -56,6 +58,8 @@ RSpec.describe DiscourseAi::AiBot::Bot do
 
       prompt << { role: "assistant", content: "!search test search" }
       prompt << { role: "user", content: "results: No results found" }
+      prompt << { role: "assistant", content: "!search test2 search" }
+      prompt << { role: "user", content: "results: No results found" }
 
       OpenAiCompletionsInferenceStubs.stub_streamed_response(
         prompt,