From 129ced9088e0d6ebff263ea2494aa3787fd86c3c Mon Sep 17 00:00:00 2001
From: Keegan George <kgeorge13@gmail.com>
Date: Wed, 9 Apr 2025 13:12:34 -0700
Subject: [PATCH] FIX: Split topic suggester fixes (#1253)

This update fixes a few issues in the split topic suggester. It fixes an issue where not all the category suggestions were appearing in the client. It also fixes an issue where the `move-post` request fails when creating a new topic with only one tag suggestion.
---
 .../components/ai-split-topic-suggester.gjs   | 12 ++++---
 .../ai_split_topic_suggestion_spec.rb         | 36 ++++++++-----------
 2 files changed, 23 insertions(+), 25 deletions(-)

diff --git a/assets/javascripts/discourse/components/ai-split-topic-suggester.gjs b/assets/javascripts/discourse/components/ai-split-topic-suggester.gjs
index 2e12c595..c851f103 100644
--- a/assets/javascripts/discourse/components/ai-split-topic-suggester.gjs
+++ b/assets/javascripts/discourse/components/ai-split-topic-suggester.gjs
@@ -49,9 +49,9 @@ export default class AiSplitTopicSuggester extends Component {
         if (this.args.mode === this.SUGGESTION_TYPES.title) {
           this.suggestions = result.suggestions;
         } else if (this.args.mode === this.SUGGESTION_TYPES.category) {
-          const suggestions = result.assistant.map((s) => s.name);
-          const suggestedCategories = this.site.categories.filter((item) =>
-            suggestions.includes(item.name.toLowerCase())
+          const suggestionIds = result.assistant.map((s) => s.id);
+          const suggestedCategories = this.site.categories.filter((category) =>
+            suggestionIds.includes(category.id)
           );
           this.suggestions = suggestedCategories;
         } else if (this.args.mode === this.SUGGESTION_TYPES.tag) {
@@ -95,7 +95,11 @@ export default class AiSplitTopicSuggester extends Component {
           this.args.updateAction([...new Set(updatedTags)]);
         }
       } else {
-        this.args.updateAction(suggestion);
+        if (Array.isArray(suggestion)) {
+          this.args.updateAction([...suggestion]);
+        } else {
+          this.args.updateAction([suggestion]);
+        }
       }
       return menu.close();
     }
diff --git a/spec/system/ai_helper/ai_split_topic_suggestion_spec.rb b/spec/system/ai_helper/ai_split_topic_suggestion_spec.rb
index 0ae6459d..12a1109d 100644
--- a/spec/system/ai_helper/ai_split_topic_suggestion_spec.rb
+++ b/spec/system/ai_helper/ai_split_topic_suggestion_spec.rb
@@ -86,28 +86,23 @@ RSpec.describe "AI Post helper", type: :system, js: true do
         SiteSetting.ai_embeddings_enabled = true
       end
 
-      skip "TODO: Category suggester only loading one category in test" do
-        it "updates the category with the suggested category" do
-          response =
-            Category
-              .take(3)
-              .pluck(:name)
-              .map { |s| { name: s, score: rand(0.0...45.0) } }
-              .sort { |h| h[:score] }
-          DiscourseAi::AiHelper::SemanticCategorizer
-            .any_instance
-            .stubs(:categories)
-            .returns(response)
+      it "updates the category with the suggested category" do
+        response =
+          Category
+            .take(3)
+            .pluck(:id, :name)
+            .map { |s| { id: s[0], name: s[1], score: rand(0.0...45.0) } }
+            .sort { |h| h[:score] }
+        DiscourseAi::AiHelper::SemanticCategorizer.any_instance.stubs(:categories).returns(response)
 
-          open_move_topic_modal
-          suggestion_menu.click_suggest_category_button
-          wait_for { suggestion_menu.has_dropdown? }
-          suggestion = category.name
-          suggestion_menu.select_suggestion_by_name(suggestion)
-          category_selector = page.find(".category-chooser summary")
+        open_move_topic_modal
+        suggestion_menu.click_suggest_category_button
+        wait_for { suggestion_menu.has_dropdown? }
+        suggestion = category.name
+        suggestion_menu.select_suggestion_by_name(suggestion)
+        category_selector = page.find(".category-chooser summary")
 
-          expect(category_selector["data-name"]).to eq(suggestion)
-        end
+        expect(category_selector["data-name"]).to eq(suggestion)
       end
     end
 
@@ -133,7 +128,6 @@ RSpec.describe "AI Post helper", type: :system, js: true do
         suggestion = suggestion_menu.suggestion_name(0)
         suggestion_menu.select_suggestion_by_value(0)
         tag_selector = page.find(".tag-chooser summary")
-
         expect(tag_selector["data-name"]).to eq(suggestion)
       end
     end