From 238538c405ff009378ca42734efe8f79c135553e Mon Sep 17 00:00:00 2001 From: Keegan George Date: Fri, 20 Jun 2025 12:42:08 -0700 Subject: [PATCH] DEV: Remove deprecated integer duration in toasts (#1453) This update replaces deprecated integer duration with standardized duration of either `short` or `long` throughout the plugin usages of `FloatKit` toasts. --- .../discourse/components/ai-composer-helper-menu.gjs | 2 +- .../javascripts/discourse/components/ai-embedding-editor.gjs | 2 +- .../javascripts/discourse/components/ai-llm-editor-form.gjs | 2 +- assets/javascripts/discourse/components/ai-persona-editor.gjs | 2 +- assets/javascripts/discourse/components/ai-spam.gjs | 4 ++-- .../javascripts/discourse/components/ai-tool-editor-form.gjs | 2 +- .../discourse/components/modal/share-full-topic-modal.gjs | 4 ++-- .../components/suggestion-menus/ai-tag-suggester.gjs | 2 +- assets/javascripts/initializers/ai-helper.js | 2 +- assets/javascripts/initializers/ai-image-caption.js | 2 +- 10 files changed, 12 insertions(+), 12 deletions(-) diff --git a/assets/javascripts/discourse/components/ai-composer-helper-menu.gjs b/assets/javascripts/discourse/components/ai-composer-helper-menu.gjs index cb1aa2e4..40a35e42 100644 --- a/assets/javascripts/discourse/components/ai-composer-helper-menu.gjs +++ b/assets/javascripts/discourse/components/ai-composer-helper-menu.gjs @@ -87,7 +87,7 @@ export default class AiComposerHelperMenu extends Component { const owner = getOwner(this); const options = { close: () => this.args.close(), - duration: 3000, + duration: "short", data: { theme: "error", icon: "triangle-exclamation", diff --git a/assets/javascripts/discourse/components/ai-embedding-editor.gjs b/assets/javascripts/discourse/components/ai-embedding-editor.gjs index 75a10bee..1edce858 100644 --- a/assets/javascripts/discourse/components/ai-embedding-editor.gjs +++ b/assets/javascripts/discourse/components/ai-embedding-editor.gjs @@ -223,7 +223,7 @@ export default class AiEmbeddingEditor extends Component { this.toasts.success({ data: { message: i18n("discourse_ai.embeddings.saved") }, - duration: 2000, + duration: "short", }); } } catch (e) { diff --git a/assets/javascripts/discourse/components/ai-llm-editor-form.gjs b/assets/javascripts/discourse/components/ai-llm-editor-form.gjs index 8676a6af..5657b492 100644 --- a/assets/javascripts/discourse/components/ai-llm-editor-form.gjs +++ b/assets/javascripts/discourse/components/ai-llm-editor-form.gjs @@ -209,7 +209,7 @@ export default class AiLlmEditorForm extends Component { } this.toasts.success({ data: { message: i18n("discourse_ai.llms.saved") }, - duration: 2000, + duration: "short", }); } catch (e) { popupAjaxError(e); diff --git a/assets/javascripts/discourse/components/ai-persona-editor.gjs b/assets/javascripts/discourse/components/ai-persona-editor.gjs index 80970b5b..f83b6cdf 100644 --- a/assets/javascripts/discourse/components/ai-persona-editor.gjs +++ b/assets/javascripts/discourse/components/ai-persona-editor.gjs @@ -129,7 +129,7 @@ export default class PersonaEditor extends Component { } this.toasts.success({ data: { message: i18n("discourse_ai.ai_persona.saved") }, - duration: 2000, + duration: "short", }); } catch (e) { popupAjaxError(e); diff --git a/assets/javascripts/discourse/components/ai-spam.gjs b/assets/javascripts/discourse/components/ai-spam.gjs index 829c8787..5c6d883a 100644 --- a/assets/javascripts/discourse/components/ai-spam.gjs +++ b/assets/javascripts/discourse/components/ai-spam.gjs @@ -73,7 +73,7 @@ export default class AiSpam extends Component { if (response.success) { this.toasts.success({ data: { message: i18n("discourse_ai.spam.errors.resolved") }, - duration: 2000, + duration: "short", }); } } catch (error) { @@ -145,7 +145,7 @@ export default class AiSpam extends Component { }); this.toasts.success({ data: { message: i18n("discourse_ai.spam.settings_saved") }, - duration: 2000, + duration: "short", }); } catch (error) { popupAjaxError(error); diff --git a/assets/javascripts/discourse/components/ai-tool-editor-form.gjs b/assets/javascripts/discourse/components/ai-tool-editor-form.gjs index 3dc16611..bea63c61 100644 --- a/assets/javascripts/discourse/components/ai-tool-editor-form.gjs +++ b/assets/javascripts/discourse/components/ai-tool-editor-form.gjs @@ -84,7 +84,7 @@ export default class AiToolEditorForm extends Component { this.toasts.success({ data: { message: i18n("discourse_ai.tools.saved") }, - duration: 2000, + duration: "short", }); if (!this.args.tools.any((tool) => tool.id === this.args.model.id)) { diff --git a/assets/javascripts/discourse/components/modal/share-full-topic-modal.gjs b/assets/javascripts/discourse/components/modal/share-full-topic-modal.gjs index f452053d..d2987578 100644 --- a/assets/javascripts/discourse/components/modal/share-full-topic-modal.gjs +++ b/assets/javascripts/discourse/components/modal/share-full-topic-modal.gjs @@ -82,7 +82,7 @@ export default class ShareModal extends Component { async share() { await clipboardCopyAsync(this.generateShareURL.bind(this)); this.toasts.success({ - duration: 3000, + duration: "short", data: { message: i18n("discourse_ai.ai_bot.conversation_shared"), }, @@ -109,7 +109,7 @@ export default class ShareModal extends Component { await clipboardCopyAsync(() => promise); this.toasts.success({ - duration: 3000, + duration: "short", data: { message: i18n("discourse_ai.ai_bot.embed_copied"), }, diff --git a/assets/javascripts/discourse/components/suggestion-menus/ai-tag-suggester.gjs b/assets/javascripts/discourse/components/suggestion-menus/ai-tag-suggester.gjs index dfaab7eb..32279820 100644 --- a/assets/javascripts/discourse/components/suggestion-menus/ai-tag-suggester.gjs +++ b/assets/javascripts/discourse/components/suggestion-menus/ai-tag-suggester.gjs @@ -140,7 +140,7 @@ export default class AiTagSuggester extends Component { if (tags?.length >= maxTags) { return this.toasts.error({ class: "ai-suggestion-error", - duration: 3000, + duration: "short", data: { message: i18n("discourse_ai.ai_helper.suggest_errors.too_many_tags", { count: maxTags, diff --git a/assets/javascripts/initializers/ai-helper.js b/assets/javascripts/initializers/ai-helper.js index 0ca6b78f..1f8ee067 100644 --- a/assets/javascripts/initializers/ai-helper.js +++ b/assets/javascripts/initializers/ai-helper.js @@ -35,7 +35,7 @@ function initializeAiHelperTrigger(api) { return toasts.error({ class: "ai-proofread-error-toast", - duration: 3000, + duration: "short", data: { message: i18n("discourse_ai.ai_helper.no_content_error"), }, diff --git a/assets/javascripts/initializers/ai-image-caption.js b/assets/javascripts/initializers/ai-image-caption.js index 32876e3b..9d31a863 100644 --- a/assets/javascripts/initializers/ai-image-caption.js +++ b/assets/javascripts/initializers/ai-image-caption.js @@ -116,7 +116,7 @@ export default apiInitializer("1.25.0", (api) => { } catch (error) { toasts.error({ class: "ai-image-caption-error-toast", - duration: 3000, + duration: "short", data: { message: extractError(error), },