discourse/discourse-ai
1
0
Fork 0
mirror of https://github.com/discourse/discourse-ai.git synced 2025-06-29 02:52:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Cleanup properties on closing DiffModal (#1442)

Browse Source 
This update ensures that we reset the tracked properties when closing the DiffModal so that the state doesn't leak when triggering the AI suggestions again. We also reset before suggesting new changes, thus if regeneration is called there shouldn't be any leaks either.

No tests in this PR as tests currently not working great due to streaming/animation issues. Will do a broader PR following up with various specs to improve test coverage here.
This commit is contained in:
Keegan George 2025-06-17 13:57:46 -07:00 committed by GitHub
parent 9dccc1eb93
commit 62d746662a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
assets/javascripts/discourse/components/modal/diff-modal.gjs
View File

@ -114,8 +114,7 @@ export default class ModalDiffModal extends Component {
@action
async suggestChanges() {
this.smoothStreamer.resetStreaming();
this.diffStreamer.reset();
this.#resetState();
try {
this.loading = true;
@ -159,11 +158,25 @@ export default class ModalDiffModal extends Component {
}
}
@action
cleanupAndClose() {
this.#resetState();
this.loading = false;
this.args.closeModal();
}
#resetState() {
this.suggestion = "";
this.finalResult = "";
this.smoothStreamer.resetStreaming();
this.diffStreamer.reset();
}
<template>
<DModal
class="composer-ai-helper-modal"
@title={{i18n "discourse_ai.ai_helper.context_menu.changes"}}
@closeModal={{@closeModal}}
@closeModal={{this.cleanupAndClose}}
>
<:body>
<div
@ -218,7 +231,7 @@ export default class ModalDiffModal extends Component {
</DButton>
<DButton
class="btn-flat discard"
@action={{@closeModal}}
@action={{this.cleanupAndClose}}
@label="discourse_ai.ai_helper.context_menu.discard"
/>
<DButton