discourse/discourse-ai
1
0
Fork 0
mirror of https://github.com/discourse/discourse-ai.git synced 2025-06-26 09:32:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: properly spin down unused streamer threads (#1035)

Browse Source 
Previous version was prone to the bug:

https://github.com/ruby-concurrency/concurrent-ruby/issues/1075

This is particularly bad cause we could have a DB connection
attached to the thread and we never clear it up, so after N hours
this could start exhibiting weird connection issues.
This commit is contained in:
Sam 2024-12-20 12:09:42 +11:00 committed by GitHub
parent ac705b694b
commit 6a7a45fd4f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/ai_bot/response_http_streamer.rb
View File

@ -8,21 +8,19 @@ module DiscourseAi
class << self class << self
def thread_pool def thread_pool
# we use our thread pool implementation here for a few reasons:
#
# 1. Free multisite support
# 2. Unlike Concurrent::CachedThreadPool, we spin back down to 0 threads automatiaclly see: https://github.com/ruby-concurrency/concurrent-ruby/issues/1075
# 3. Better internal error handling
@thread_pool ||= @thread_pool ||=
Concurrent::CachedThreadPool.new(min_threads: 0, max_threads: POOL_SIZE, idletime: 30) Scheduler::ThreadPool.new(min_threads: 0, max_threads: POOL_SIZE, idle_time: 30)
end end
def schedule_block(&block) def schedule_block(&block)
# think about a better way to handle cross thread connections
if Rails.env.test?
block.call
return
end
db = RailsMultisite::ConnectionManagement.current_db
thread_pool.post do thread_pool.post do
begin begin
RailsMultisite::ConnectionManagement.with_connection(db) { block.call } block.call
rescue StandardError => e rescue StandardError => e
Discourse.warn_exception(e, message: "Discourse AI: Unable to stream reply") Discourse.warn_exception(e, message: "Discourse AI: Unable to stream reply")
end end