discourse/discourse-ai
1
0
Fork 0
mirror of https://github.com/discourse/discourse-ai.git synced 2025-06-23 16:12:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: when tool options are added they should be available (#1406)

Browse Source 
Fixes a regression where tool option editor was not showing
all tools
This commit is contained in:
Sam 2025-06-05 12:05:55 +10:00 committed by GitHub
parent c885e5697f
commit b3d78a6a10
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
assets/javascripts/discourse/components/ai-persona-tool-options.gjs
View File

@ -33,6 +33,19 @@ export default class AiPersonaToolOptions extends Component {
return toolOptions ? Object.keys(toolOptions) : [];
}
@action
toolOptionKeys(toolId) {
// this is important, some tools may not have all options defined (for example if a tool option is added)
const metadata = this.toolsMetadata[toolId];
if (!metadata) {
return [];
}
// a bit more verbose for clarity of our selection
const availableOptions = Object.keys(metadata).filter((k) => k !== "name");
return availableOptions;
}
<template>
{{#if this.showToolOptions}}
<@form.Container
@ -51,8 +64,8 @@ export default class AiPersonaToolOptions extends Component {
<div class="ai-persona-editor__tool-options-name">
{{toolMeta.name}}
</div>
<toolObj.Object @name={{toolId}} as |optionsObj optionData|>
{{#each (this.formObjectKeys optionData) as |optionName|}}
<toolObj.Object @name={{toolId}} as |optionsObj|>
{{#each (this.toolOptionKeys toolId) as |optionName|}}
{{#let (get toolMeta optionName) as |optionMeta|}}
<optionsObj.Field
@name={{optionName}}

9
spec/system/admin_ai_persona_spec.rb
View File

@ -51,6 +51,15 @@ RSpec.describe "Admin AI persona configuration", type: :system, js: true do
expected_tools = [["Read", { "read_private" => nil }, true], ["ListCategories", {}, true]]
expect(persona.tools).to contain_exactly(*expected_tools)
# lets also test upgrades here... particularly one options was deleted and another added
# this ensurse that we can still edit the tool correctly and all options are present
persona.update!(tools: [["Read", { "got_deleted" => true }]])
visit "/admin/plugins/discourse-ai/ai-personas/#{persona_id}/edit"
expect(page).to have_selector("input[name='toolOptions.Read.read_private']")
expect(page).not_to have_selector("input[name='toolOptions.Read.got_deleted']")
end
it "will not allow deletion or editing of system personas" do