mirror of
https://github.com/discourse/discourse-ai.git
synced 2025-06-30 19:42:17 +00:00
5b6d39a206
* DEV: refactor bot internals This introduces a proper object for bot context, this makes it simpler to improve context management as we go cause we have a nice object to work with Starts refactoring allowing for a single message to have multiple uploads throughout * transplant method to message builder * chipping away at inline uploads * image support is improved but not fully fixed yet partially working in anthropic, still got quite a few dialects to go * open ai and claude are now working * Gemini is now working as well * fix nova * more dialects... * fix ollama * fix specs * update artifact fixed * more tests * spam scanner * pass more specs * bunch of specs improved * more bug fixes. * all the rest of the tests are working * improve tests coverage and ensure custom tools are aware of new context object * tests are working, but we need more tests * resolve merge conflict * new preamble and expanded specs on ai tool * remove concept of "standalone tools" This is no longer needed, we can set custom raw, tool details are injected into tool calls
87 lines
3.1 KiB
Ruby
87 lines
3.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe DiscourseAi::Completions::Prompt do
|
|
subject(:prompt) { described_class.new(system_insts) }
|
|
|
|
let(:system_insts) { "These are the system instructions." }
|
|
let(:user_msg) { "Write something nice" }
|
|
let(:username) { "username1" }
|
|
let(:image100x100) { plugin_file_from_fixtures("100x100.jpg") }
|
|
|
|
describe ".new" do
|
|
it "raises for invalid attributes" do
|
|
expect { described_class.new("a bot", messages: {}) }.to raise_error(ArgumentError)
|
|
expect { described_class.new("a bot", tools: {}) }.to raise_error(ArgumentError)
|
|
|
|
bad_messages = [{ type: :user, content: "a system message", unknown_attribute: :random }]
|
|
expect { described_class.new("a bot", messages: bad_messages) }.to raise_error(ArgumentError)
|
|
|
|
bad_messages2 = [{ type: :user }]
|
|
expect { described_class.new("a bot", messages: bad_messages2) }.to raise_error(ArgumentError)
|
|
|
|
bad_messages3 = [{ content: "some content associated to no one" }]
|
|
expect { described_class.new("a bot", messages: bad_messages3) }.to raise_error(ArgumentError)
|
|
end
|
|
end
|
|
|
|
describe "image support" do
|
|
it "allows adding uploads inline in messages" do
|
|
upload = UploadCreator.new(image100x100, "image.jpg").create_for(Discourse.system_user.id)
|
|
|
|
prompt.max_pixels = 300
|
|
prompt.push(
|
|
type: :user,
|
|
content: ["this is an image", { upload_id: upload.id }, "this was an image"],
|
|
)
|
|
|
|
encoded = prompt.content_with_encoded_uploads(prompt.messages.last[:content])
|
|
|
|
expect(encoded.length).to eq(3)
|
|
expect(encoded[0]).to eq("this is an image")
|
|
expect(encoded[1][:mime_type]).to eq("image/jpeg")
|
|
expect(encoded[2]).to eq("this was an image")
|
|
end
|
|
end
|
|
|
|
describe "#push" do
|
|
describe "turn validations" do
|
|
it "validates that tool messages have a previous tool_call message" do
|
|
prompt.push(type: :user, content: user_msg, id: username)
|
|
prompt.push(type: :model, content: "I'm a model msg")
|
|
|
|
expect { prompt.push(type: :tool, content: "I'm the tool call results") }.to raise_error(
|
|
DiscourseAi::Completions::Prompt::INVALID_TURN,
|
|
)
|
|
end
|
|
|
|
it "validates that model messages have either a previous tool or user messages" do
|
|
prompt.push(type: :user, content: user_msg, id: username)
|
|
prompt.push(type: :model, content: "I'm a model msg")
|
|
|
|
expect { prompt.push(type: :model, content: "I'm a second model msg") }.to raise_error(
|
|
DiscourseAi::Completions::Prompt::INVALID_TURN,
|
|
)
|
|
end
|
|
end
|
|
|
|
it "system message is always first" do
|
|
prompt.push(type: :user, content: user_msg, id: username)
|
|
|
|
system_message = prompt.messages.first
|
|
|
|
expect(system_message[:type]).to eq(:system)
|
|
expect(system_message[:content]).to eq(system_insts)
|
|
end
|
|
|
|
it "includes the pushed message" do
|
|
prompt.push(type: :user, content: user_msg, id: username)
|
|
|
|
system_message = prompt.messages.last
|
|
|
|
expect(system_message[:type]).to eq(:user)
|
|
expect(system_message[:content]).to eq(user_msg)
|
|
expect(system_message[:id]).to eq(username)
|
|
end
|
|
end
|
|
end
|