mirror of
https://github.com/discourse/discourse-ai.git
synced 2025-07-01 12:02:16 +00:00
d7a2af5505
We're seeing an aggressive number of translations being enqueued for a single post and locale. Historically, we trigger translation on `cooked` not `raw`, but that has changed a while back. ``` # from AiApiAuditLog, the same post is getting translated to the same locale within a few secs of each other zh_CN - 2025-06-17 13:02:31 UTC zh_CN - 2025-06-17 13:02:34 UTC zh_CN - 2025-06-17 13:02:35 UTC zh_CN - 2025-06-17 13:02:36 UTC zh_CN - 2025-06-17 13:02:38 UTC zh_CN - 2025-06-17 13:02:39 UTC zh_CN - 2025-06-17 13:02:40 UTC zh_CN - 2025-06-17 13:02:40 UTC zh_CN - 2025-06-17 13:02:43 UTC zh_CN - 2025-06-17 13:02:44 UTC ``` This PR prevents this from happening.
82 lines
2.5 KiB
Ruby
82 lines
2.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe DiscourseAi::Translation::EntryPoint do
|
|
before do
|
|
SiteSetting.discourse_ai_enabled = true
|
|
Fabricate(:fake_model).tap do |fake_llm|
|
|
SiteSetting.public_send("ai_translation_model=", "custom:#{fake_llm.id}")
|
|
end
|
|
SiteSetting.ai_translation_enabled = true
|
|
end
|
|
|
|
describe "upon post process cooked" do
|
|
it "enqueues detect post locale and translate post job" do
|
|
post =
|
|
PostCreator.create!(Fabricate(:user), raw: "post", title: "topic", skip_validations: true)
|
|
expect_job_enqueued(job: :detect_translate_post, args: { post_id: post.id })
|
|
end
|
|
|
|
it "does not enqueue if setting disabled" do
|
|
SiteSetting.ai_translation_enabled = false
|
|
post = Fabricate(:post)
|
|
CookedPostProcessor.new(post).post_process
|
|
|
|
expect(job_enqueued?(job: :detect_translate_post, args: { post_id: post.id })).to eq false
|
|
end
|
|
end
|
|
|
|
describe "upon topic created" do
|
|
it "enqueues detect topic locale and translate topic job" do
|
|
topic =
|
|
PostCreator.create!(
|
|
Fabricate(:admin),
|
|
raw: "post",
|
|
title: "topic",
|
|
skip_validations: true,
|
|
).topic
|
|
|
|
expect_job_enqueued(job: :detect_translate_topic, args: { topic_id: topic.id })
|
|
end
|
|
|
|
it "does not enqueue if setting disabled" do
|
|
SiteSetting.ai_translation_enabled = false
|
|
topic =
|
|
PostCreator.create!(
|
|
Fabricate(:admin),
|
|
raw: "post",
|
|
title: "topic",
|
|
skip_validations: true,
|
|
).topic
|
|
|
|
expect(job_enqueued?(job: :detect_translate_topic, args: { topic_id: topic.id })).to eq false
|
|
end
|
|
end
|
|
|
|
describe "upon first post (topic) edited" do
|
|
fab!(:post) { Fabricate(:post, post_number: 1) }
|
|
fab!(:non_first_post) { Fabricate(:post, post_number: 2) }
|
|
|
|
it "enqueues detect topic locale and translate topic job" do
|
|
SiteSetting.ai_translation_enabled = true
|
|
topic = post.topic
|
|
revisor = PostRevisor.new(post, topic)
|
|
revisor.revise!(
|
|
post.user,
|
|
{ title: "A whole new hole" },
|
|
{ validate_post: false, bypass_bump: false },
|
|
)
|
|
revisor.post_process_post
|
|
|
|
expect_job_enqueued(job: :detect_translate_topic, args: { topic_id: topic.id })
|
|
end
|
|
|
|
it "does not enqueue if setting disabled" do
|
|
SiteSetting.ai_translation_enabled = false
|
|
|
|
expect(
|
|
job_enqueued?(job: :detect_translate_topic, args: { topic_id: post.topic_id }),
|
|
).to eq false
|
|
end
|
|
end
|
|
end
|