mirror of
https://github.com/discourse/discourse-ai.git
synced 2025-07-07 15:02:25 +00:00
a94daa14e2
When an invalid model is set for embeddings, topics do not load even if embeddings is disabled. Error: ## RuntimeError in TopicsController#show Invalid embeddings selected model This commit checks for valid settings before attempting to load related topics.
96 lines
2.9 KiB
Ruby
96 lines
2.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe DiscourseAi::Embeddings::SemanticRelated do
|
|
subject(:semantic_related) { described_class.new }
|
|
|
|
fab!(:target) { Fabricate(:topic) }
|
|
fab!(:normal_topic_1) { Fabricate(:topic) }
|
|
fab!(:normal_topic_2) { Fabricate(:topic) }
|
|
fab!(:normal_topic_3) { Fabricate(:topic) }
|
|
fab!(:unlisted_topic) { Fabricate(:topic, visible: false) }
|
|
fab!(:private_topic) { Fabricate(:private_message_topic) }
|
|
fab!(:secured_category) { Fabricate(:category, read_restricted: true) }
|
|
fab!(:secured_category_topic) { Fabricate(:topic, category: secured_category) }
|
|
fab!(:closed_topic) { Fabricate(:topic, closed: true) }
|
|
|
|
fab!(:vector_def) { Fabricate(:embedding_definition) }
|
|
|
|
before do
|
|
SiteSetting.ai_embeddings_semantic_related_topics_enabled = true
|
|
SiteSetting.ai_embeddings_selected_model = vector_def.id
|
|
SiteSetting.ai_embeddings_enabled = true
|
|
end
|
|
|
|
describe "#related_topic_ids_for" do
|
|
it "returns empty array if AI embeddings are disabled" do
|
|
SiteSetting.ai_embeddings_enabled = false
|
|
SiteSetting.ai_embeddings_selected_model = 1234
|
|
|
|
expect(semantic_related.related_topic_ids_for(normal_topic_1)).to eq([])
|
|
end
|
|
|
|
it "returns empty array if AI embeddings model is invalid" do
|
|
SiteSetting.ai_embeddings_enabled = true
|
|
SiteSetting.ai_embeddings_selected_model = 1234
|
|
|
|
expect(semantic_related.related_topic_ids_for(normal_topic_1)).to eq([])
|
|
end
|
|
|
|
context "when embeddings do not exist" do
|
|
let(:topic) do
|
|
post = Fabricate(:post)
|
|
topic = post.topic
|
|
described_class.clear_cache_for(target)
|
|
topic
|
|
end
|
|
|
|
it "properly generates embeddings if missing" do
|
|
Jobs.run_immediately!
|
|
|
|
embedding = Array.new(1024) { 1 }
|
|
|
|
WebMock.stub_request(:post, vector_def.url).to_return(
|
|
status: 200,
|
|
body: JSON.dump([embedding]),
|
|
)
|
|
|
|
# miss first
|
|
ids = semantic_related.related_topic_ids_for(topic)
|
|
|
|
# clear cache so we lookup
|
|
described_class.clear_cache_for(topic)
|
|
|
|
# hit cause we queued generation
|
|
ids = semantic_related.related_topic_ids_for(topic)
|
|
|
|
# at this point though the only embedding is ourselves
|
|
expect(ids).to eq([topic.id])
|
|
end
|
|
|
|
it "queues job only once per 15 minutes" do
|
|
results = nil
|
|
|
|
expect_enqueued_with(
|
|
job: :generate_embeddings,
|
|
args: {
|
|
target_id: topic.id,
|
|
target_type: "Topic",
|
|
},
|
|
) { results = semantic_related.related_topic_ids_for(topic) }
|
|
|
|
expect(results).to eq([])
|
|
|
|
expect_not_enqueued_with(
|
|
job: :generate_embeddings,
|
|
args: {
|
|
target_id: topic.id,
|
|
target_type: "Topic",
|
|
},
|
|
) { results = semantic_related.related_topic_ids_for(topic) }
|
|
|
|
expect(results).to eq([])
|
|
end
|
|
end
|
|
end
|
|
end
|