mirror of
				https://github.com/discourse/discourse-ai.git
				synced 2025-10-31 06:28:48 +00:00 
			
		
		
		
	* FIX: Made bot more robust This is a collection of small fixes - Display "Searching for: ..." while searching instead of showing found 0 results. - Only allow 5 commands in lang chain - 6 feels like too much - On the 5th command stop informing the engine about functions, so it is forced to complete - Add another 30 tokens of buffer and explain why - Typo in command prompt Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
		
			
				
	
	
		
			398 lines
		
	
	
		
			11 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			398 lines
		
	
	
		
			11 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # frozen_string_literal: true
 | |
| 
 | |
| module DiscourseAi
 | |
|   module AiBot
 | |
|     class Bot
 | |
|       class FunctionCalls
 | |
|         def initialize
 | |
|           @functions = []
 | |
|           @current_function = nil
 | |
|           @found = false
 | |
|           @cancel_completion = false
 | |
|         end
 | |
| 
 | |
|         def found?
 | |
|           !@functions.empty? || @found
 | |
|         end
 | |
| 
 | |
|         def found!
 | |
|           @found = true
 | |
|         end
 | |
| 
 | |
|         def cancel_completion?
 | |
|           @cancel_completion
 | |
|         end
 | |
| 
 | |
|         def cancel_completion!
 | |
|           @cancel_completion = true
 | |
|         end
 | |
| 
 | |
|         def add_function(name)
 | |
|           @current_function = { name: name, arguments: +"" }
 | |
|           @functions << @current_function
 | |
|         end
 | |
| 
 | |
|         def add_argument_fragment(fragment)
 | |
|           @current_function[:arguments] << fragment
 | |
|         end
 | |
| 
 | |
|         def length
 | |
|           @functions.length
 | |
|         end
 | |
| 
 | |
|         def each
 | |
|           @functions.each { |function| yield function }
 | |
|         end
 | |
| 
 | |
|         def to_a
 | |
|           @functions
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       attr_reader :bot_user
 | |
| 
 | |
|       BOT_NOT_FOUND = Class.new(StandardError)
 | |
|       MAX_COMPLETIONS = 5
 | |
| 
 | |
|       def self.as(bot_user)
 | |
|         available_bots = [DiscourseAi::AiBot::OpenAiBot, DiscourseAi::AiBot::AnthropicBot]
 | |
| 
 | |
|         bot =
 | |
|           available_bots.detect(-> { raise BOT_NOT_FOUND }) do |bot_klass|
 | |
|             bot_klass.can_reply_as?(bot_user)
 | |
|           end
 | |
| 
 | |
|         bot.new(bot_user)
 | |
|       end
 | |
| 
 | |
|       def initialize(bot_user)
 | |
|         @bot_user = bot_user
 | |
|         @persona = DiscourseAi::AiBot::Personas::General.new
 | |
|       end
 | |
| 
 | |
|       def update_pm_title(post)
 | |
|         prompt = title_prompt(post)
 | |
| 
 | |
|         new_title = get_updated_title(prompt).strip.split("\n").last
 | |
| 
 | |
|         PostRevisor.new(post.topic.first_post, post.topic).revise!(
 | |
|           bot_user,
 | |
|           title: new_title.sub(/\A"/, "").sub(/"\Z/, ""),
 | |
|         )
 | |
|         post.topic.custom_fields.delete(DiscourseAi::AiBot::EntryPoint::REQUIRE_TITLE_UPDATE)
 | |
|         post.topic.save_custom_fields
 | |
|       end
 | |
| 
 | |
|       def reply_to(
 | |
|         post,
 | |
|         total_completions: 0,
 | |
|         bot_reply_post: nil,
 | |
|         prefer_low_cost: false,
 | |
|         standalone: false
 | |
|       )
 | |
|         return if total_completions > MAX_COMPLETIONS
 | |
| 
 | |
|         # do not allow commands when we are at the end of chain (total completions == MAX_COMPLETIONS)
 | |
|         allow_commands = (total_completions < MAX_COMPLETIONS)
 | |
| 
 | |
|         @persona = DiscourseAi::AiBot::Personas::General.new(allow_commands: allow_commands)
 | |
|         if persona_name = post.topic.custom_fields["ai_persona"]
 | |
|           persona_class =
 | |
|             DiscourseAi::AiBot::Personas.all.find { |current| current.name == persona_name }
 | |
|           @persona = persona_class.new(allow_commands: allow_commands) if persona_class
 | |
|         end
 | |
| 
 | |
|         prompt =
 | |
|           if standalone && post.post_custom_prompt
 | |
|             username, standalone_prompt = post.post_custom_prompt.custom_prompt.last
 | |
|             [build_message(username, standalone_prompt)]
 | |
|           else
 | |
|             bot_prompt_with_topic_context(post)
 | |
|           end
 | |
| 
 | |
|         redis_stream_key = nil
 | |
|         partial_reply = +""
 | |
|         reply = +(bot_reply_post ? bot_reply_post.raw.dup : "")
 | |
|         start = Time.now
 | |
| 
 | |
|         setup_cancel = false
 | |
|         context = {}
 | |
|         functions = FunctionCalls.new
 | |
| 
 | |
|         submit_prompt(prompt, prefer_low_cost: prefer_low_cost) do |partial, cancel|
 | |
|           current_delta = get_delta(partial, context)
 | |
|           partial_reply << current_delta
 | |
| 
 | |
|           if !available_functions.empty?
 | |
|             populate_functions(
 | |
|               partial: partial,
 | |
|               reply: partial_reply,
 | |
|               functions: functions,
 | |
|               done: false,
 | |
|             )
 | |
| 
 | |
|             cancel&.call if functions.cancel_completion?
 | |
|           end
 | |
| 
 | |
|           reply << current_delta if !functions.found?
 | |
| 
 | |
|           if redis_stream_key && !Discourse.redis.get(redis_stream_key)
 | |
|             cancel&.call
 | |
| 
 | |
|             bot_reply_post.update!(raw: reply, cooked: PrettyText.cook(reply)) if bot_reply_post
 | |
|           end
 | |
| 
 | |
|           next if reply.length < SiteSetting.min_personal_message_post_length
 | |
|           # Minor hack to skip the delay during tests.
 | |
|           next if (Time.now - start < 0.5) && !Rails.env.test?
 | |
| 
 | |
|           if bot_reply_post
 | |
|             Discourse.redis.expire(redis_stream_key, 60)
 | |
|             start = Time.now
 | |
| 
 | |
|             publish_update(bot_reply_post, raw: reply.dup)
 | |
|           else
 | |
|             bot_reply_post =
 | |
|               PostCreator.create!(
 | |
|                 bot_user,
 | |
|                 topic_id: post.topic_id,
 | |
|                 raw: reply,
 | |
|                 skip_validations: false,
 | |
|               )
 | |
|           end
 | |
| 
 | |
|           if !setup_cancel && bot_reply_post
 | |
|             redis_stream_key = "gpt_cancel:#{bot_reply_post.id}"
 | |
|             Discourse.redis.setex(redis_stream_key, 60, 1)
 | |
|             setup_cancel = true
 | |
|           end
 | |
|         end
 | |
| 
 | |
|         if bot_reply_post
 | |
|           publish_update(bot_reply_post, done: true)
 | |
| 
 | |
|           bot_reply_post.revise(
 | |
|             bot_user,
 | |
|             { raw: reply },
 | |
|             skip_validations: true,
 | |
|             skip_revision: true,
 | |
|           )
 | |
| 
 | |
|           bot_reply_post.post_custom_prompt ||= post.build_post_custom_prompt(custom_prompt: [])
 | |
|           prompt = post.post_custom_prompt.custom_prompt || []
 | |
| 
 | |
|           prompt << [partial_reply, bot_user.username]
 | |
| 
 | |
|           post.post_custom_prompt.update!(custom_prompt: prompt)
 | |
|         end
 | |
| 
 | |
|         if !available_functions.empty?
 | |
|           populate_functions(partial: nil, reply: partial_reply, functions: functions, done: true)
 | |
|         end
 | |
| 
 | |
|         if functions.length > 0
 | |
|           chain = false
 | |
|           standalone = false
 | |
| 
 | |
|           functions.each do |function|
 | |
|             name, args = function[:name], function[:arguments]
 | |
| 
 | |
|             if command_klass = available_commands.detect { |cmd| cmd.invoked?(name) }
 | |
|               command =
 | |
|                 command_klass.new(
 | |
|                   bot_user: bot_user,
 | |
|                   args: args,
 | |
|                   post: bot_reply_post,
 | |
|                   parent_post: post,
 | |
|                 )
 | |
|               chain_intermediate, bot_reply_post = command.invoke!
 | |
|               chain ||= chain_intermediate
 | |
|               standalone ||= command.standalone?
 | |
|             end
 | |
|           end
 | |
| 
 | |
|           if chain
 | |
|             reply_to(
 | |
|               bot_reply_post,
 | |
|               total_completions: total_completions + 1,
 | |
|               bot_reply_post: bot_reply_post,
 | |
|               standalone: standalone,
 | |
|             )
 | |
|           end
 | |
|         end
 | |
|       rescue => e
 | |
|         if Rails.env.development?
 | |
|           p e
 | |
|           puts e.backtrace
 | |
|         end
 | |
|         raise e if Rails.env.test?
 | |
|         Discourse.warn_exception(e, message: "ai-bot: Reply failed")
 | |
|       end
 | |
| 
 | |
|       def extra_tokens_per_message
 | |
|         0
 | |
|       end
 | |
| 
 | |
|       def bot_prompt_with_topic_context(post, prompt: "topic")
 | |
|         messages = []
 | |
|         conversation = conversation_context(post)
 | |
| 
 | |
|         rendered_system_prompt = system_prompt(post)
 | |
| 
 | |
|         total_prompt_tokens = tokenize(rendered_system_prompt).length + extra_tokens_per_message
 | |
| 
 | |
|         messages =
 | |
|           conversation.reduce([]) do |memo, (raw, username, function)|
 | |
|             break(memo) if total_prompt_tokens >= prompt_limit
 | |
| 
 | |
|             tokens = tokenize(raw.to_s)
 | |
| 
 | |
|             while !raw.blank? &&
 | |
|                     tokens.length + total_prompt_tokens + extra_tokens_per_message > prompt_limit
 | |
|               raw = raw[0..-100] || ""
 | |
|               tokens = tokenize(raw.to_s)
 | |
|             end
 | |
| 
 | |
|             next(memo) if raw.blank?
 | |
| 
 | |
|             total_prompt_tokens += tokens.length + extra_tokens_per_message
 | |
|             memo.unshift(build_message(username, raw, function: !!function))
 | |
|           end
 | |
| 
 | |
|         messages.unshift(build_message(bot_user.username, rendered_system_prompt, system: true))
 | |
| 
 | |
|         messages
 | |
|       end
 | |
| 
 | |
|       def prompt_limit
 | |
|         raise NotImplemented
 | |
|       end
 | |
| 
 | |
|       def title_prompt(post)
 | |
|         [build_message(bot_user.username, <<~TEXT)]
 | |
|           You are titlebot. Given a topic you will figure out a title.
 | |
|           You will never respond with anything but a topic title.
 | |
|           Suggest a 7 word title for the following topic without quoting any of it:
 | |
| 
 | |
|           #{post.topic.posts[1..-1].map(&:raw).join("\n\n")[0..prompt_limit]}
 | |
|         TEXT
 | |
|       end
 | |
| 
 | |
|       def available_commands
 | |
|         @persona.available_commands
 | |
|       end
 | |
| 
 | |
|       def system_prompt_style!(style)
 | |
|         @style = style
 | |
|       end
 | |
| 
 | |
|       def system_prompt(post)
 | |
|         return "You are a helpful Bot" if @style == :simple
 | |
| 
 | |
|         @persona.render_system_prompt(
 | |
|           topic: post.topic,
 | |
|           render_function_instructions: include_function_instructions_in_system_prompt?,
 | |
|         )
 | |
|       end
 | |
| 
 | |
|       def include_function_instructions_in_system_prompt?
 | |
|         true
 | |
|       end
 | |
| 
 | |
|       def function_list
 | |
|         @persona.function_list
 | |
|       end
 | |
| 
 | |
|       def tokenizer
 | |
|         raise NotImplemented
 | |
|       end
 | |
| 
 | |
|       def tokenize(text)
 | |
|         tokenizer.tokenize(text)
 | |
|       end
 | |
| 
 | |
|       def submit_prompt(prompt, prefer_low_cost: false, &blk)
 | |
|         raise NotImplemented
 | |
|       end
 | |
| 
 | |
|       def get_delta(partial, context)
 | |
|         raise NotImplemented
 | |
|       end
 | |
| 
 | |
|       def populate_functions(partial:, reply:, functions:, done:)
 | |
|         if !done
 | |
|           if functions.found?
 | |
|             functions.cancel_completion! if reply.split("\n")[-1].match?(/^\s*[^!]+/)
 | |
|           end
 | |
|           functions.found! if reply.match?(/^!/i)
 | |
|         else
 | |
|           reply
 | |
|             .scan(/^!.*$/i)
 | |
|             .each do |line|
 | |
|               function_list
 | |
|                 .parse_prompt(line)
 | |
|                 .each do |function|
 | |
|                   functions.add_function(function[:name])
 | |
|                   functions.add_argument_fragment(function[:arguments].to_json)
 | |
|                 end
 | |
|             end
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       def available_functions
 | |
|         @persona.available_functions
 | |
|       end
 | |
| 
 | |
|       protected
 | |
| 
 | |
|       def get_updated_title(prompt)
 | |
|         raise NotImplemented
 | |
|       end
 | |
| 
 | |
|       def model_for(bot)
 | |
|         raise NotImplemented
 | |
|       end
 | |
| 
 | |
|       def conversation_context(post)
 | |
|         context =
 | |
|           post
 | |
|             .topic
 | |
|             .posts
 | |
|             .includes(:user)
 | |
|             .joins("LEFT JOIN post_custom_prompts ON post_custom_prompts.post_id = posts.id")
 | |
|             .where("post_number <= ?", post.post_number)
 | |
|             .order("post_number desc")
 | |
|             .where("post_type = ?", Post.types[:regular])
 | |
|             .limit(50)
 | |
|             .pluck(:raw, :username, "post_custom_prompts.custom_prompt")
 | |
| 
 | |
|         result = []
 | |
| 
 | |
|         first = true
 | |
|         context.each do |raw, username, custom_prompt|
 | |
|           if custom_prompt.present?
 | |
|             if first
 | |
|               custom_prompt.reverse_each { |message| result << message }
 | |
|               first = false
 | |
|             else
 | |
|               result << custom_prompt.first
 | |
|             end
 | |
|           else
 | |
|             result << [raw, username]
 | |
|           end
 | |
|         end
 | |
| 
 | |
|         result
 | |
|       end
 | |
| 
 | |
|       def publish_update(bot_reply_post, payload)
 | |
|         MessageBus.publish(
 | |
|           "discourse-ai/ai-bot/topic/#{bot_reply_post.topic_id}",
 | |
|           payload.merge(post_id: bot_reply_post.id, post_number: bot_reply_post.post_number),
 | |
|           user_ids: bot_reply_post.topic.allowed_user_ids,
 | |
|         )
 | |
|       end
 | |
|     end
 | |
|   end
 | |
| end
 |