mirror of
https://github.com/discourse/discourse-ai.git
synced 2025-03-09 11:48:47 +00:00
5b5edb22c6
Introduces a UI to manage customizable personas (admin only feature)
Part of the change was some extensive internal refactoring:
- AIBot now has a persona set in the constructor, once set it never changes
- Command now takes in bot as a constructor param, so it has the correct persona and is not generating AIBot objects on the fly
- Added a .prettierignore file, due to the way ALE is configured in nvim it is a pre-req for prettier to work
- Adds a bunch of validations on the AIPersona model, system personas (artist/creative etc...) are all seeded. We now ensure
- name uniqueness, and only allow certain properties to be touched for system personas.
- (JS note) the client side design takes advantage of nested routes, the parent route for personas gets all the personas via this.store.findAll("ai-persona") then child routes simply reach into this model to find a particular persona.
- (JS note) data is sideloaded into the ai-persona model the meta property supplied from the controller, resultSetMeta
- This removes ai_bot_enabled_personas and ai_bot_enabled_chat_commands, both should be controlled from the UI on a per persona basis
- Fixes a long standing bug in token accounting ... we were doing to_json.length instead of to_json.to_s.length
- Amended it so {commands} are always inserted at the end unconditionally, no need to add it to the template of the system message as it just confuses things
- Adds a concept of required_commands to stock personas, these are commands that must be configured for this stock persona to show up.
- Refactored tests so we stop requiring inference_stubs, it was very confusing to need it, added to plugin.rb for now which at least is clearer
- Migrates the persona selector to gjs
---------
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Martin Brennan <martin@discourse.org>
50 lines
1.9 KiB
Ruby
50 lines
1.9 KiB
Ruby
# frozen_string_literal: true
|
|
RSpec.describe "AI personas", type: :system, js: true do
|
|
fab!(:admin)
|
|
|
|
before do
|
|
SiteSetting.ai_bot_enabled = true
|
|
SiteSetting.ai_bot_enabled_chat_bots = "gpt-4|gpt-3.5-turbo"
|
|
sign_in(admin)
|
|
end
|
|
|
|
it "allows creation of a persona" do
|
|
visit "/admin/plugins/discourse-ai/ai_personas"
|
|
find(".ai-persona-list-editor__header .btn-primary").click()
|
|
find(".ai-persona-editor__name").set("Test Persona")
|
|
find(".ai-persona-editor__description").fill_in(with: "I am a test persona")
|
|
find(".ai-persona-editor__system_prompt").fill_in(with: "You are a helpful bot")
|
|
find(".ai-persona-editor__save").click()
|
|
|
|
expect(page).not_to have_current_path("/admin/plugins/discourse-ai/ai_personas/new")
|
|
|
|
persona_id = page.current_path.split("/").last.to_i
|
|
|
|
persona = AiPersona.find(persona_id)
|
|
expect(persona.name).to eq("Test Persona")
|
|
expect(persona.description).to eq("I am a test persona")
|
|
expect(persona.system_prompt).to eq("You are a helpful bot")
|
|
end
|
|
|
|
it "will not allow deletion or editing of system personas" do
|
|
visit "/admin/plugins/discourse-ai/ai_personas/#{DiscourseAi::AiBot::Personas.system_personas.values.first}"
|
|
expect(page).not_to have_selector(".ai-persona-editor__delete")
|
|
expect(find(".ai-persona-editor__system_prompt")).to be_disabled
|
|
end
|
|
|
|
it "will enable persona right away when you click on enable but does not save side effects" do
|
|
persona = Fabricate(:ai_persona, enabled: false)
|
|
|
|
visit "/admin/plugins/discourse-ai/ai_personas/#{persona.id}"
|
|
|
|
find(".ai-persona-editor__name").set("Test Persona 1")
|
|
PageObjects::Components::DToggleSwitch.new(".ai-persona-editor__enabled").toggle
|
|
|
|
try_until_success { expect(persona.reload.enabled).to eq(true) }
|
|
|
|
persona.reload
|
|
expect(persona.enabled).to eq(true)
|
|
expect(persona.name).not_to eq("Test Persona 1")
|
|
end
|
|
end
|