mirror of
https://github.com/discourse/discourse-ai.git
synced 2025-10-26 20:18:39 +00:00
This commit introduces a new feature for AI Personas called the "Question Consolidator LLM". The purpose of the Question Consolidator is to consolidate a user's latest question into a self-contained, context-rich question before querying the vector database for relevant fragments. This helps improve the quality and relevance of the retrieved fragments.
Previous to this change we used the last 10 interactions, this is not ideal cause the RAG would "lock on" to an answer.
EG:
- User: how many cars are there in europe
- Model: detailed answer about cars in europe including the term car and vehicle many times
- User: Nice, what about trains are there in the US
In the above example "trains" and "US" becomes very low signal given there are pages and pages talking about cars and europe. This mean retrieval is sub optimal.
Instead, we pass the history to the "question consolidator", it would simply consolidate the question to "How many trains are there in the United States", which would make it fare easier for the vector db to find relevant content.
The llm used for question consolidator can often be less powerful than the model you are talking to, we recommend using lighter weight and fast models cause the task is very simple. This is configurable from the persona ui.
This PR also removes support for {uploads} placeholder, this is too complicated to get right and we want freedom to shift RAG implementation.
Key changes:
1. Added a new `question_consolidator_llm` column to the `ai_personas` table to store the LLM model used for question consolidation.
2. Implemented the `QuestionConsolidator` module which handles the logic for consolidating the user's latest question. It extracts the relevant user and model messages from the conversation history, truncates them if needed to fit within the token limit, and generates a consolidated question prompt.
3. Updated the `Persona` class to use the Question Consolidator LLM (if configured) when crafting the RAG fragments prompt. It passes the conversation context to the consolidator to generate a self-contained question.
4. Added UI elements in the AI Persona editor to allow selecting the Question Consolidator LLM. Also made some UI tweaks to conditionally show/hide certain options based on persona configuration.
5. Wrote unit tests for the QuestionConsolidator module and updated existing persona tests to cover the new functionality.
This feature enables AI Personas to better understand the context and intent behind a user's question by consolidating the conversation history into a single, focused question. This can lead to more relevant and accurate responses from the AI assistant.
181 lines
5.1 KiB
Ruby
181 lines
5.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module DiscourseAi
|
|
module Admin
|
|
class AiPersonasController < ::Admin::AdminController
|
|
requires_plugin ::DiscourseAi::PLUGIN_NAME
|
|
|
|
before_action :find_ai_persona,
|
|
only: %i[show update destroy create_user indexing_status_check]
|
|
|
|
def index
|
|
ai_personas =
|
|
AiPersona.ordered.map do |persona|
|
|
# we use a special serializer here cause names and descriptions are
|
|
# localized for system personas
|
|
LocalizedAiPersonaSerializer.new(persona, root: false)
|
|
end
|
|
tools =
|
|
DiscourseAi::AiBot::Personas::Persona.all_available_tools.map do |tool|
|
|
AiToolSerializer.new(tool, root: false)
|
|
end
|
|
llms =
|
|
DiscourseAi::Configuration::LlmEnumerator.values.map do |hash|
|
|
{ id: hash[:value], name: hash[:name] }
|
|
end
|
|
render json: { ai_personas: ai_personas, meta: { commands: tools, llms: llms } }
|
|
end
|
|
|
|
def show
|
|
render json: LocalizedAiPersonaSerializer.new(@ai_persona)
|
|
end
|
|
|
|
def create
|
|
ai_persona = AiPersona.new(ai_persona_params.except(:rag_uploads))
|
|
if ai_persona.save
|
|
RagDocumentFragment.link_persona_and_uploads(ai_persona, attached_upload_ids)
|
|
|
|
render json: { ai_persona: ai_persona }, status: :created
|
|
else
|
|
render_json_error ai_persona
|
|
end
|
|
end
|
|
|
|
def create_user
|
|
user = @ai_persona.create_user!
|
|
render json: BasicUserSerializer.new(user, root: "user")
|
|
end
|
|
|
|
def update
|
|
if @ai_persona.update(ai_persona_params.except(:rag_uploads))
|
|
RagDocumentFragment.update_persona_uploads(@ai_persona, attached_upload_ids)
|
|
|
|
render json: @ai_persona
|
|
else
|
|
render_json_error @ai_persona
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
if @ai_persona.destroy
|
|
head :no_content
|
|
else
|
|
render_json_error @ai_persona
|
|
end
|
|
end
|
|
|
|
def upload_file
|
|
file = params[:file] || params[:files].first
|
|
|
|
if !SiteSetting.ai_embeddings_enabled?
|
|
raise Discourse::InvalidAccess.new("Embeddings not enabled")
|
|
end
|
|
|
|
validate_extension!(file.original_filename)
|
|
validate_file_size!(file.tempfile.size)
|
|
|
|
hijack do
|
|
upload =
|
|
UploadCreator.new(
|
|
file.tempfile,
|
|
file.original_filename,
|
|
type: "discourse_ai_rag_upload",
|
|
skip_validations: true,
|
|
).create_for(current_user.id)
|
|
|
|
if upload.persisted?
|
|
render json: UploadSerializer.new(upload)
|
|
else
|
|
render json: failed_json.merge(errors: upload.errors.full_messages), status: 422
|
|
end
|
|
end
|
|
end
|
|
|
|
def indexing_status_check
|
|
render json: RagDocumentFragment.indexing_status(@ai_persona, @ai_persona.uploads)
|
|
end
|
|
|
|
private
|
|
|
|
def find_ai_persona
|
|
@ai_persona = AiPersona.find(params[:id])
|
|
end
|
|
|
|
def attached_upload_ids
|
|
ai_persona_params[:rag_uploads].to_a.map { |h| h[:id] }
|
|
end
|
|
|
|
def ai_persona_params
|
|
permitted =
|
|
params.require(:ai_persona).permit(
|
|
:name,
|
|
:description,
|
|
:enabled,
|
|
:system_prompt,
|
|
:priority,
|
|
:top_p,
|
|
:temperature,
|
|
:default_llm,
|
|
:user_id,
|
|
:mentionable,
|
|
:max_context_posts,
|
|
:vision_enabled,
|
|
:vision_max_pixels,
|
|
:rag_chunk_tokens,
|
|
:rag_chunk_overlap_tokens,
|
|
:rag_conversation_chunks,
|
|
:question_consolidator_llm,
|
|
allowed_group_ids: [],
|
|
rag_uploads: [:id],
|
|
)
|
|
|
|
if commands = params.dig(:ai_persona, :commands)
|
|
permitted[:commands] = permit_commands(commands)
|
|
end
|
|
|
|
permitted
|
|
end
|
|
|
|
def permit_commands(commands)
|
|
return [] if !commands.is_a?(Array)
|
|
|
|
commands.filter_map do |command, options|
|
|
break nil if !command.is_a?(String)
|
|
options&.permit! if options && options.is_a?(ActionController::Parameters)
|
|
|
|
if options
|
|
[command, options]
|
|
else
|
|
command
|
|
end
|
|
end
|
|
end
|
|
|
|
def validate_extension!(filename)
|
|
extension = File.extname(filename)[1..-1] || ""
|
|
authorized_extensions = %w[txt md]
|
|
if !authorized_extensions.include?(extension)
|
|
raise Discourse::InvalidParameters.new(
|
|
I18n.t(
|
|
"upload.unauthorized",
|
|
authorized_extensions: authorized_extensions.join(" "),
|
|
),
|
|
)
|
|
end
|
|
end
|
|
|
|
def validate_file_size!(filesize)
|
|
max_size_bytes = 20.megabytes
|
|
if filesize > max_size_bytes
|
|
raise Discourse::InvalidParameters.new(
|
|
I18n.t(
|
|
"upload.attachments.too_large_humanized",
|
|
max_size: ActiveSupport::NumberHelper.number_to_human_size(max_size_bytes),
|
|
),
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|