mirror of
https://github.com/discourse/discourse-data-explorer.git
synced 2025-07-07 06:52:30 +00:00
FIX: allow query to be explained (#371)
Bug introduced during refactoring in this PR: https://github.com/discourse/discourse-data-explorer/pull/318 Explain parameter must be passed to `ResultFormatConverter`.
This commit is contained in:
parent
08a01b23fe
commit
f3ecd52b94
@ -194,6 +194,7 @@ module ::DiscourseDataExplorer
|
|||||||
result,
|
result,
|
||||||
query_params:,
|
query_params:,
|
||||||
download: params[:download],
|
download: params[:download],
|
||||||
|
explain: params[:explain] == "true",
|
||||||
)
|
)
|
||||||
end
|
end
|
||||||
format.csv do
|
format.csv do
|
||||||
|
@ -126,9 +126,13 @@ describe DiscourseDataExplorer::QueryController do
|
|||||||
end
|
end
|
||||||
|
|
||||||
describe "#run" do
|
describe "#run" do
|
||||||
def run_query(id, params = {})
|
def run_query(id, params = {}, explain = false)
|
||||||
params = Hash[params.map { |a| [a[0], a[1].to_s] }]
|
params = Hash[params.map { |a| [a[0], a[1].to_s] }]
|
||||||
post "/admin/plugins/explorer/queries/#{id}/run.json", params: { params: params.to_json }
|
post "/admin/plugins/explorer/queries/#{id}/run.json",
|
||||||
|
params: {
|
||||||
|
params: params.to_json,
|
||||||
|
explain: explain,
|
||||||
|
}
|
||||||
end
|
end
|
||||||
|
|
||||||
it "can run queries" do
|
it "can run queries" do
|
||||||
@ -139,6 +143,18 @@ describe DiscourseDataExplorer::QueryController do
|
|||||||
expect(response_json["errors"]).to eq([])
|
expect(response_json["errors"]).to eq([])
|
||||||
expect(response_json["columns"]).to eq(["my_value"])
|
expect(response_json["columns"]).to eq(["my_value"])
|
||||||
expect(response_json["rows"]).to eq([[23]])
|
expect(response_json["rows"]).to eq([[23]])
|
||||||
|
expect(response_json["explain"]).to be_nil
|
||||||
|
end
|
||||||
|
|
||||||
|
it "can run and explain queries" do
|
||||||
|
query = make_query("SELECT 23 as my_value")
|
||||||
|
run_query query.id, {}, true
|
||||||
|
expect(response.status).to eq(200)
|
||||||
|
expect(response_json["success"]).to eq(true)
|
||||||
|
expect(response_json["errors"]).to eq([])
|
||||||
|
expect(response_json["columns"]).to eq(["my_value"])
|
||||||
|
expect(response_json["rows"]).to eq([[23]])
|
||||||
|
expect(response_json["explain"]).to match("Result ")
|
||||||
end
|
end
|
||||||
|
|
||||||
it "can process parameters" do
|
it "can process parameters" do
|
||||||
|
Loading…
x
Reference in New Issue
Block a user