mirror of
https://github.com/discourse/discourse-placeholder-theme-component.git
synced 2025-07-31 08:03:26 +00:00
be75773375
* FIX: fully rely on keyValueStore to prevent error
The component was generating errors for some users due to direct access to `localStorage`:
```
TypeError: Cannot convert undefined or null to object
at Function.keys (<anonymous>)
at Object.expireOldValues (https://d3bpeqsaub0i6y.cloudfront.net/theme-javascripts/33bf35dc19b970a42f8c1e7d57d8cc72d6205bbd.js?__ws=meta.discourse.org:157:14)
at Object.initialize (https://d3bpeqsaub0i6y.cloudfront.net/theme-javascripts/33bf35dc19b970a42f8c1e7d57d8cc72d6205bbd.js?__ws=meta.discourse.org:193:12)
at o.initialize (https://d11a6trkgmumsb.cloudfront.net/assets/discourse-2bd9a9aa6b5c9cbee990a03159f5bff41fe503fe74814c3b66b3770876913dd5.gz.js:68:38)
```
This commits removes old unnecessary code using cookies and uses latest API from core `removeKeys`. Old discourse instances will just not evict old keys which is a minor annoyance.
* linting
discourse-placeholder-theme-component
https://meta.discourse.org/t/discourse-placeholder-theme-component/113533
Usage
[wrap=placeholder key=NAME][/wrap]
[wrap=placeholder key=COUNTRY default=FR][/wrap]
[wrap=placeholder key=SECRET description="Used to open the bank"][/wrap]
I'm =NAME=, I come from =COUNTRY= let me tell you my secret: =SECRET==
Feedback
If you have issues or suggestions for the plugin, please bring them up on Discourse Meta.