From 66ec74bf2be3a1071ad109eb1796d111af3a99b2 Mon Sep 17 00:00:00 2001
From: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Date: Fri, 13 Dec 2024 17:00:17 +0100
Subject: [PATCH] DEV: move to an ember component

---
 README.md                                     |  7 +---
 .../rewinds_assets_controller.rb              | 32 -------------------
 .../discourse_rewind/rewinds_controller.rb    |  7 +---
 .../discourse_rewind/rewinds_helper.rb        | 25 ---------------
 .../rewind/action/{base.rb => base_report.rb} |  4 +--
 .../discourse_rewind/rewind/action/fbff.rb    |  2 +-
 .../rewind/action/posting_calendar.rb         |  2 +-
 .../rewind/action/reactions.rb                |  2 +-
 .../rewind/action/reading_time.rb             |  6 ++--
 app/services/discourse_rewind/rewind/fetch.rb | 32 ++++++-------------
 .../discourse_rewind/rewinds/show.html.erb    | 31 ------------------
 .../discourse/components/rewind.gjs           | 27 ++++++++++++++++
 .../user-activity-bottom/rewind-tab.gjs       | 17 ++++++++++
 .../javascripts/discourse/rewind-route-map.js | 11 +++++++
 .../discourse/routes/user-activity-rewind.js  |  5 +++
 .../discourse/templates/user/rewind.hbs       |  1 +
 assets/stylesheets/common/index.scss          |  1 +
 assets/stylesheets/common/rewind.scss         |  6 ++++
 assets/stylesheets/desktop/index.scss         |  0
 assets/stylesheets/mobile/index.scss          |  0
 config/routes.rb                              |  5 +--
 lib/discourse_rewind/engine.rb                |  6 ++++
 plugin.rb                                     |  6 ++++
 public/css/rewind.css                         | 16 ----------
 24 files changed, 101 insertions(+), 150 deletions(-)
 delete mode 100644 app/controllers/discourse_rewind/rewinds_assets_controller.rb
 delete mode 100644 app/helpers/discourse_rewind/rewinds_helper.rb
 rename app/services/discourse_rewind/rewind/action/{base.rb => base_report.rb} (68%)
 delete mode 100644 app/views/discourse_rewind/rewinds/show.html.erb
 create mode 100644 assets/javascripts/discourse/components/rewind.gjs
 create mode 100644 assets/javascripts/discourse/connectors/user-activity-bottom/rewind-tab.gjs
 create mode 100644 assets/javascripts/discourse/rewind-route-map.js
 create mode 100644 assets/javascripts/discourse/routes/user-activity-rewind.js
 create mode 100644 assets/javascripts/discourse/templates/user/rewind.hbs
 create mode 100644 assets/stylesheets/common/index.scss
 create mode 100644 assets/stylesheets/common/rewind.scss
 create mode 100644 assets/stylesheets/desktop/index.scss
 create mode 100644 assets/stylesheets/mobile/index.scss
 delete mode 100644 public/css/rewind.css

diff --git a/README.md b/README.md
index 7144774..7632898 100644
--- a/README.md
+++ b/README.md
@@ -4,9 +4,4 @@ Display stats on your last year of Discourse usage.
 
 ## Usage
 
-- add `http://127.0.0.1:4200/rewinds?` in `SiteSetting.allowed_iframes`
-- example embed of a rewind in a post:
-
-```
-<iframe src="http://127.0.0.1:4200/rewinds?year=2024&username=j.jaffeux" width="320" height="500" frameborder="0" style="border:0;" allowfullscreen="" aria-hidden="false" tabindex="0" />
-```
+Navigate to `/my/activity/rewind`
diff --git a/app/controllers/discourse_rewind/rewinds_assets_controller.rb b/app/controllers/discourse_rewind/rewinds_assets_controller.rb
deleted file mode 100644
index d6ddbba..0000000
--- a/app/controllers/discourse_rewind/rewinds_assets_controller.rb
+++ /dev/null
@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-module ::DiscourseRewind
-  class RewindsAssetsController < ::ApplicationController
-    requires_plugin PLUGIN_NAME
-
-    skip_before_action :preload_json, :check_xhr, only: %i[show]
-    skip_before_action :verify_authenticity_token, only: %i[show]
-
-    def show
-      no_cookies
-
-      name = params[:name]
-      path, content_type =
-        if name == "rewind"
-          %w[rewind.css text/css]
-        else
-          raise Discourse::NotFound
-        end
-
-      content = File.read(DiscourseRewind.public_asset_path("css/#{path}"))
-
-      # note, path contains a ":version" which automatically busts the cache
-      # based on file content, so this is safe
-      response.headers["Last-Modified"] = 10.years.ago.httpdate
-      response.headers["Content-Length"] = content.bytesize.to_s
-      immutable_for 1.year
-
-      render plain: content, disposition: :nil, content_type: content_type
-    end
-  end
-end
diff --git a/app/controllers/discourse_rewind/rewinds_controller.rb b/app/controllers/discourse_rewind/rewinds_controller.rb
index 9b57adf..f1a9cf7 100644
--- a/app/controllers/discourse_rewind/rewinds_controller.rb
+++ b/app/controllers/discourse_rewind/rewinds_controller.rb
@@ -4,16 +4,11 @@ module ::DiscourseRewind
   class RewindsController < ::ApplicationController
     requires_plugin PLUGIN_NAME
 
-    skip_before_action :preload_json, :check_xhr, :redirect_to_login_if_required, only: %i[show]
-
     def show
-      # expires_in 1.minute, public: false
-      response.headers["X-Robots-Tag"] = "noindex"
-
       DiscourseRewind::Rewind::Fetch.call(service_params) do
         on_success do |reports:|
           @reports = reports
-          render "show", layout: false
+          render json: MultiJson.dump(reports), status: 200
         end
       end
     end
diff --git a/app/helpers/discourse_rewind/rewinds_helper.rb b/app/helpers/discourse_rewind/rewinds_helper.rb
deleted file mode 100644
index 9d2c9a6..0000000
--- a/app/helpers/discourse_rewind/rewinds_helper.rb
+++ /dev/null
@@ -1,25 +0,0 @@
-# frozen_string_literal: true
-
-module DiscourseRewind
-  module RewindsHelper
-    # keeping it here for caching
-    def self.rewind_asset_url(asset_name)
-      if !%w[rewind.css].include?(asset_name)
-        raise StandardError, "unknown asset type #{asset_name}"
-      end
-
-      @urls ||= {}
-      url = @urls[asset_name]
-      return url if url
-
-      content = File.read(DiscourseRewind.public_asset_path("css/#{asset_name}"))
-      sha1 = Digest::SHA1.hexdigest(content)
-      url = "/rewinds/assets/#{sha1}/#{asset_name}"
-      @urls[asset_name] = GlobalPath.cdn_path(url)
-    end
-
-    def rewind_asset_url(asset_name)
-      DiscourseRewind::RewindsHelper.rewind_asset_url(asset_name)
-    end
-  end
-end
diff --git a/app/services/discourse_rewind/rewind/action/base.rb b/app/services/discourse_rewind/rewind/action/base_report.rb
similarity index 68%
rename from app/services/discourse_rewind/rewind/action/base.rb
rename to app/services/discourse_rewind/rewind/action/base_report.rb
index 4c39f70..2e66c66 100644
--- a/app/services/discourse_rewind/rewind/action/base.rb
+++ b/app/services/discourse_rewind/rewind/action/base_report.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module DiscourseRewind
-  class Rewind::Action::Base < Service::ActionBase
+  class Rewind::Action::BaseReport < Service::ActionBase
     option :user
     option :date
 
@@ -9,7 +9,7 @@ module DiscourseRewind
       raise NotImplementedError
     end
 
-    def enabled?
+    def self.enabled?
       true
     end
   end
diff --git a/app/services/discourse_rewind/rewind/action/fbff.rb b/app/services/discourse_rewind/rewind/action/fbff.rb
index 93e499c..14de726 100644
--- a/app/services/discourse_rewind/rewind/action/fbff.rb
+++ b/app/services/discourse_rewind/rewind/action/fbff.rb
@@ -3,7 +3,7 @@
 # Forum Best Friend Forever ranking
 # Score is informative only, do not show in UI
 module DiscourseRewind
-  class Rewind::Action::Fbff < Action::Base
+  class Rewind::Action::Fbff < Rewind::Action::BaseReport
     MAX_SUMMARY_RESULTS = 50
     LIKE_SCORE = 1
     REPLY_SCORE = 10
diff --git a/app/services/discourse_rewind/rewind/action/posting_calendar.rb b/app/services/discourse_rewind/rewind/action/posting_calendar.rb
index a55dd30..51921e7 100644
--- a/app/services/discourse_rewind/rewind/action/posting_calendar.rb
+++ b/app/services/discourse_rewind/rewind/action/posting_calendar.rb
@@ -3,7 +3,7 @@
 # For a GitHub like calendar
 # https://docs.github.com/assets/cb-35216/mw-1440/images/help/profile/contributions-graph.webp
 module DiscourseRewind
-  class Rewind::Action::PostingCalendar < Action::Base
+  class Rewind::Action::PostingCalendar < Rewind::Action::BaseReport
     def call
       calendar =
         Post
diff --git a/app/services/discourse_rewind/rewind/action/reactions.rb b/app/services/discourse_rewind/rewind/action/reactions.rb
index 59859b2..1bd03b2 100644
--- a/app/services/discourse_rewind/rewind/action/reactions.rb
+++ b/app/services/discourse_rewind/rewind/action/reactions.rb
@@ -2,7 +2,7 @@
 
 # For a most user / received reactions cards
 module DiscourseRewind
-  class Rewind::Action::Reactions < Action::Base
+  class Rewind::Action::Reactions < Rewind::Action::BaseReport
     def call
       post_used_reactions = {}
       post_received_reactions = {}
diff --git a/app/services/discourse_rewind/rewind/action/reading_time.rb b/app/services/discourse_rewind/rewind/action/reading_time.rb
index ebeeb41..c5d1fd9 100644
--- a/app/services/discourse_rewind/rewind/action/reading_time.rb
+++ b/app/services/discourse_rewind/rewind/action/reading_time.rb
@@ -3,9 +3,9 @@
 # For showcasing the reading time of a user
 # Should we show book covers or just the names?
 module DiscourseRewind
-  class Rewind::Action::ReadingTime < Action::Base
+  class Rewind::Action::ReadingTime < Rewind::Action::BaseReport
     def call
-      reading_time = UserVisit.where(user: user).where(visited_at: date).sum(:time_read)
+      reading_time = UserVisit.where(user_id: user.id).where(visited_at: date).sum(:time_read)
 
       {
         data: {
@@ -38,7 +38,7 @@ module DiscourseRewind
         "And Then There Were None" => 16_200,
         "The Alchemist" => 10_800,
         "The Hitchhiker's Guide to the Galaxy" => 12_600,
-      }
+      }.symbolize_keys
     end
 
     def best_book_fit(reading_time)
diff --git a/app/services/discourse_rewind/rewind/fetch.rb b/app/services/discourse_rewind/rewind/fetch.rb
index 0933721..830a58d 100644
--- a/app/services/discourse_rewind/rewind/fetch.rb
+++ b/app/services/discourse_rewind/rewind/fetch.rb
@@ -5,11 +5,7 @@ module DiscourseRewind
   #
   # @example
   #  ::DiscourseRewind::Rewind::Fetch.call(
-  #    guardian: guardian,
-  #    params: {
-  #      username: "falco",
-  #      year: 2024,
-  #    }
+  #    guardian: guardian
   #  )
   #
   class Rewind::Fetch
@@ -22,18 +18,9 @@ module DiscourseRewind
     #   @option params [Integer] :username of the rewind
     #   @return [Service::Base::Context]
 
-    # Do we need a custom order?
-    available_reports = DiscourseRewind::Rewind::Action::Base.descendants
-
     CACHE_DURATION = 5.minutes
 
-    params do
-      attribute :year, :integer
-      attribute :username, :string
-
-      validates :year, presence: true
-      validates :username, presence: true
-    end
+    YEAR = 2024
 
     model :user
     model :date
@@ -41,23 +28,24 @@ module DiscourseRewind
 
     private
 
-    def fetch_user(params:)
-      User.find_by_username(params.username)
+    def fetch_user(guardian:)
+      User.find_by_username(guardian.user.username)
     end
 
     def fetch_date(params:)
-      Date.new(params.year).all_year
+      Date.new(YEAR).all_year
     end
 
-    def fetch_reports(params:, date:, user:, guardian:)
-      key = "rewind:#{params.username}:#{params.year}"
+    def fetch_reports(date:, user:, guardian:)
+      key = "rewind:#{guardian.user.username}:#{YEAR}"
       reports = Discourse.redis.get(key)
 
       if Rails.env.development? || !reports
         reports =
-          available_reports
+          ::DiscourseRewind::Rewind::Action::BaseReport
+            .descendants
             .filter { _1.enabled? }
-            .map { |report| report.call(params:, date:, user:, guardian:) }
+            .map { |report| report.call(date:, user:, guardian:) }
         Discourse.redis.setex(key, CACHE_DURATION, MultiJson.dump(reports))
       else
         reports = MultiJson.load(reports, symbolize_keys: true)
diff --git a/app/views/discourse_rewind/rewinds/show.html.erb b/app/views/discourse_rewind/rewinds/show.html.erb
deleted file mode 100644
index ca5e6a3..0000000
--- a/app/views/discourse_rewind/rewinds/show.html.erb
+++ /dev/null
@@ -1,31 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <head>
-    <title><%= I18n.t("discourse_rewind.title", title: "RETRO TITLE", site_name: SiteSetting.title) %></title>
-    <meta property="og:title" content="<%= I18n.t("discourse_rewind.title", title: "RETRO TITLE", site_name: SiteSetting.title) %>">
-    <meta property="og:description" content="DESC">
-    <meta property="og:type" content="website">
-    <meta property="og:url" content="<%= request.original_url %>">
-    <meta name="twitter:card" content="summary">
-    <meta name="twitter:title" content="<%= I18n.t("discourse_rewind.title", title: "RETRO TITLE", site_name: SiteSetting.title) %>">
-    <meta name="twitter:description" content="DESC">
-    <meta name="viewport" content="width=device-width">
-    <link rel="stylesheet" href="<%= rewind_asset_url("rewind.css")  %>">
-  </head>
-  <body>
-    <div class="rewind__wrapper">
-      <div class="rewind">
-        <%- @reports.each do |report| %>
-          <div class="rewind__report">
-            <div class="rewind__report__header">
-              <%= report[:identifier] %>
-            </div>
-            <div class="rewind__report__body">
-              <%= report[:data][:count] %>
-            </div>
-          </div>
-        <%- end %>
-      </div>
-    </div>
-  </body>
-</html>
diff --git a/assets/javascripts/discourse/components/rewind.gjs b/assets/javascripts/discourse/components/rewind.gjs
new file mode 100644
index 0000000..fb6409e
--- /dev/null
+++ b/assets/javascripts/discourse/components/rewind.gjs
@@ -0,0 +1,27 @@
+import Component from "@glimmer/component";
+import { tracked } from "@glimmer/tracking";
+import { action } from "@ember/object";
+import didInsert from "@ember/render-modifiers/modifiers/did-insert";
+import { ajax } from "discourse/lib/ajax";
+import { popupAjaxError } from "discourse/lib/ajax-error";
+
+export default class Rewind extends Component {
+  @tracked rewind = [];
+
+  @action
+  async loadRewind() {
+    try {
+      this.rewind = await ajax("/rewinds");
+    } catch (e) {
+      popupAjaxError(e);
+    }
+  }
+
+  <template>
+    <div class="rewind" {{didInsert this.loadRewind}}>
+      {{#each this.rewind as |report|}}
+        <p>{{report.identifier}}</p>
+      {{/each}}
+    </div>
+  </template>
+}
diff --git a/assets/javascripts/discourse/connectors/user-activity-bottom/rewind-tab.gjs b/assets/javascripts/discourse/connectors/user-activity-bottom/rewind-tab.gjs
new file mode 100644
index 0000000..e095f40
--- /dev/null
+++ b/assets/javascripts/discourse/connectors/user-activity-bottom/rewind-tab.gjs
@@ -0,0 +1,17 @@
+import Component from "@glimmer/component";
+import DNavigationItem from "discourse/components/d-navigation-item";
+import icon from "discourse-common/helpers/d-icon";
+import { i18n } from "discourse-i18n";
+
+export default class RewindTab extends Component {
+  <template>
+    <DNavigationItem
+      @route="userActivity.rewind"
+      @ariaCurrentContext="subNav"
+      class="user-nav__activity-rewind"
+    >
+      {{icon "repeat"}}
+      <span>{{i18n "rewind.title"}}</span>
+    </DNavigationItem>
+  </template>
+}
diff --git a/assets/javascripts/discourse/rewind-route-map.js b/assets/javascripts/discourse/rewind-route-map.js
new file mode 100644
index 0000000..b914651
--- /dev/null
+++ b/assets/javascripts/discourse/rewind-route-map.js
@@ -0,0 +1,11 @@
+export default function () {
+  this.route(
+    "user",
+    { path: "/u/:username", resetNamespace: true },
+    function () {
+      this.route("userActivity", function () {
+        this.route("rewind");
+      });
+    }
+  );
+}
diff --git a/assets/javascripts/discourse/routes/user-activity-rewind.js b/assets/javascripts/discourse/routes/user-activity-rewind.js
new file mode 100644
index 0000000..4e82dae
--- /dev/null
+++ b/assets/javascripts/discourse/routes/user-activity-rewind.js
@@ -0,0 +1,5 @@
+import DiscourseRoute from "discourse/routes/discourse";
+
+export default class UserActivityRewind extends DiscourseRoute {
+  templateName = "user/rewind";
+}
diff --git a/assets/javascripts/discourse/templates/user/rewind.hbs b/assets/javascripts/discourse/templates/user/rewind.hbs
new file mode 100644
index 0000000..ff83916
--- /dev/null
+++ b/assets/javascripts/discourse/templates/user/rewind.hbs
@@ -0,0 +1 @@
+<Rewind />
diff --git a/assets/stylesheets/common/index.scss b/assets/stylesheets/common/index.scss
new file mode 100644
index 0000000..27e640f
--- /dev/null
+++ b/assets/stylesheets/common/index.scss
@@ -0,0 +1 @@
+@import "rewind";
diff --git a/assets/stylesheets/common/rewind.scss b/assets/stylesheets/common/rewind.scss
new file mode 100644
index 0000000..5e7021c
--- /dev/null
+++ b/assets/stylesheets/common/rewind.scss
@@ -0,0 +1,6 @@
+.rewind {
+  width: 280px;
+  height: 400px;
+  background-color: var(--secondary-high);
+  border-radius: var(--d-border-radius);
+}
diff --git a/assets/stylesheets/desktop/index.scss b/assets/stylesheets/desktop/index.scss
new file mode 100644
index 0000000..e69de29
diff --git a/assets/stylesheets/mobile/index.scss b/assets/stylesheets/mobile/index.scss
new file mode 100644
index 0000000..e69de29
diff --git a/config/routes.rb b/config/routes.rb
index 0d50f93..5ee0cbe 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-DiscourseRewind::Engine.routes.draw do
-  get "/rewinds" => "rewinds#show"
-  get "/rewinds/assets/:version/:name" => "rewinds_assets#show"
-end
+DiscourseRewind::Engine.routes.draw { get "/rewinds" => "rewinds#show" }
 
 Discourse::Application.routes.draw { mount ::DiscourseRewind::Engine, at: "/" }
diff --git a/lib/discourse_rewind/engine.rb b/lib/discourse_rewind/engine.rb
index fbe2499..5e5f584 100644
--- a/lib/discourse_rewind/engine.rb
+++ b/lib/discourse_rewind/engine.rb
@@ -9,5 +9,11 @@ module ::DiscourseRewind
     config.to_prepare do
       Rails.autoloaders.main.eager_load_dir(scheduled_job_dir) if Dir.exist?(scheduled_job_dir)
     end
+
+    Rails.application.reloader.to_prepare do
+      Dir[
+        "#{Rails.root}/plugins/discourse-rewind/app/services/discourse_rewind/rewind/action/*.rb"
+      ].each { |file| require_dependency file }
+    end
   end
 end
diff --git a/plugin.rb b/plugin.rb
index 20acf71..84e9ce9 100644
--- a/plugin.rb
+++ b/plugin.rb
@@ -10,6 +10,12 @@
 
 enabled_site_setting :discourse_rewind_enabled
 
+register_svg_icon "repeat"
+
+register_asset "stylesheets/common/index.scss"
+register_asset "stylesheets/desktop/index.scss", :desktop
+register_asset "stylesheets/mobile/index.scss", :mobile
+
 module ::DiscourseRewind
   PLUGIN_NAME = "discourse-rewind"
 
diff --git a/public/css/rewind.css b/public/css/rewind.css
deleted file mode 100644
index 9d35916..0000000
--- a/public/css/rewind.css
+++ /dev/null
@@ -1,16 +0,0 @@
-/* RESET CSS */
-*, *::before, *::after { box-sizing: border-box; }
-* { margin: 0; padding: 0; }
-ul[role='list'], ol[role='list'] { list-style: none; }
-html:focus-within { scroll-behavior: smooth; }
-a:not([class]) { text-decoration-skip-ink: auto; }
-input, button, textarea, select { font: inherit; }
-body, html { height: 100%; scroll-behavior: smooth; }
-/* END RESET CSS */
-
-.rewind {
-  display: flex;
-  height: 100vh;
-  background-color: #f5f5f5;
-  border-radius: 5px;
-}