discourse/discourse-signatures
1
0
Fork 0
mirror of https://github.com/discourse/discourse-signatures.git synced 2025-12-15 03:13:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

DEV: fix flakey spec (#95)

Browse Source 
Creating the post ahead of time ensures it's ready when we want to visit it. There's also no need to reload the user as we do a visit which triggers a full page refresh.
This commit is contained in:
Joffrey JAFFEUX 2025-09-23 15:52:42 +02:00 committed by GitHub
parent 675089accb
commit 8a2e7fbbdf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
spec/system/image_signatures_spec.rb
View File

@ -2,7 +2,7 @@
RSpec.describe "Image signatures", type: :system do RSpec.describe "Image signatures", type: :system do
fab!(:user) fab!(:user)
fab!(:topic) fab!(:topic) { Fabricate(:topic, category: Fabricate(:category)) }
fab!(:post) { Fabricate(:post, topic:) } fab!(:post) { Fabricate(:post, topic:) }
let(:signature_image_url) { "https://example.com/signature.png" } let(:signature_image_url) { "https://example.com/signature.png" }
@ -16,6 +16,8 @@ RSpec.describe "Image signatures", type: :system do
context "when signatures are visible by default" do context "when signatures are visible by default" do
before { SiteSetting.signatures_visible_by_default = true } before { SiteSetting.signatures_visible_by_default = true }
fab!(:post) { Fabricate(:post, topic:, user:, raw: "This is a test post with signature") }
it "allows user to set an image signature and displays it below posts" do it "allows user to set an image signature and displays it below posts" do
sign_in(user) sign_in(user)
@ -26,15 +28,12 @@ RSpec.describe "Image signatures", type: :system do
expect(page).to have_field(placeholder: I18n.t("js.signatures.signature_placeholder")) expect(page).to have_field(placeholder: I18n.t("js.signatures.signature_placeholder"))
check I18n.t("js.signatures.show_signatures") check I18n.t("js.signatures.show_signatures")
fill_in placeholder: I18n.t("js.signatures.signature_placeholder"), with: signature_image_url fill_in placeholder: I18n.t("js.signatures.signature_placeholder"),
with: signature_image_url
click_button I18n.t("js.save") click_button I18n.t("js.save")
expect(page).to have_content(I18n.t("js.saved")) expect(page).to have_content(I18n.t("js.saved"))
user.reload
post = Fabricate(:post, topic:, user:, raw: "This is a test post with signature")
visit post.url visit post.url
expect(page).to have_css("img.signature-img[src='#{signature_image_url}']") expect(page).to have_css("img.signature-img[src='#{signature_image_url}']")