mirror of
https://github.com/discourse/discourse-solved.git
synced 2025-07-03 12:22:14 +00:00
9e9ac2862c
As part of https://github.com/discourse/discourse-solved/pull/342, some discrepancies in the old implementation resulted in solved topics linking to posts that do not exist (dangling custom field value). Causing us to see the following when there are no `answer_post` ``` NoMethodError (undefined method `user' for nil) ``` This PR prevents the error.
56 lines
1.3 KiB
Ruby
56 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module DiscourseSolved::TopicViewSerializerExtension
|
|
extend ActiveSupport::Concern
|
|
|
|
prepended { attributes :accepted_answer }
|
|
|
|
def include_accepted_answer?
|
|
SiteSetting.solved_enabled? && object.topic.solved.present? &&
|
|
object.topic.solved.answer_post.present?
|
|
end
|
|
|
|
def accepted_answer
|
|
accepted_answer_post_info
|
|
end
|
|
|
|
private
|
|
|
|
def accepted_answer_post_info
|
|
solved = object.topic.solved
|
|
answer_post = solved.answer_post
|
|
answer_post_user = answer_post.user
|
|
accepter = solved.accepter
|
|
|
|
excerpt =
|
|
if SiteSetting.solved_quote_length > 0
|
|
PrettyText.excerpt(
|
|
answer_post.cooked,
|
|
SiteSetting.solved_quote_length,
|
|
keep_emoji_images: true,
|
|
)
|
|
else
|
|
nil
|
|
end
|
|
|
|
accepted_answer = {
|
|
post_number: answer_post.post_number,
|
|
username: answer_post_user.username,
|
|
name: answer_post_user.name,
|
|
excerpt:,
|
|
}
|
|
|
|
if SiteSetting.show_who_marked_solved
|
|
accepted_answer[:accepter_name] = accepter.name
|
|
accepted_answer[:accepter_username] = accepter.username
|
|
end
|
|
|
|
if !SiteSetting.enable_names || !SiteSetting.display_name_on_posts
|
|
accepted_answer[:name] = nil
|
|
accepted_answer[:accepter_name] = nil
|
|
end
|
|
|
|
accepted_answer
|
|
end
|
|
end
|