discourse/discourse-subscriptions
1
0
Fork 0
mirror of https://github.com/discourse/discourse-subscriptions.git synced 2025-03-08 18:49:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Translation missing for Norway (#196)

Browse Source 
Turns out in YAML `NO` is interpreted as a boolean value, so we need to
wrap it in quotes.
This commit is contained in:
Blake Erickson 2024-03-27 15:50:15 -06:00 committed by GitHub
parent 0d28c9a56d
commit 9190001a3c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config/locales/client.en.yml
View File

@ -298,7 +298,7 @@ en:
NU: "Niue" NU: "Niue"
NF: "Norfolk Island" NF: "Norfolk Island"
MP: "Northern Mariana Islands" MP: "Northern Mariana Islands"
NO: "Norway" "NO": "Norway"
OM: "Oman" OM: "Oman"
PK: "Pakistan" PK: "Pakistan"
PW: "Palau" PW: "Palau"

14
test/javascripts/acceptance/subscribe-test.js
View File

@ -2,6 +2,7 @@ import { click, visit } from "@ember/test-helpers";
import { test } from "qunit"; import { test } from "qunit";
import pretender, { response } from "discourse/tests/helpers/create-pretender"; import pretender, { response } from "discourse/tests/helpers/create-pretender";
import { acceptance, count } from "discourse/tests/helpers/qunit-helpers"; import { acceptance, count } from "discourse/tests/helpers/qunit-helpers";
import I18n from "discourse-i18n";
import { stubStripe } from "discourse/plugins/discourse-subscriptions/helpers/stripe"; import { stubStripe } from "discourse/plugins/discourse-subscriptions/helpers/stripe";
function singleProductPretender() { function singleProductPretender() {
@ -49,4 +50,17 @@ acceptance("Discourse Subscriptions", function (needs) {
assert.dom("input.subscribe-promo-code").exists(); assert.dom("input.subscribe-promo-code").exists();
assert.dom("button.btn-payment").exists(); assert.dom("button.btn-payment").exists();
}); });
// In YAML `NO:` is a boolean, so we need quotes around `"NO":`.
test("Norway is translated correctly", async function (assert) {
assert.equal(
I18n.t("discourse_subscriptions.subscribe.countries.NO"),
"Norway"
);
assert.equal(
I18n.t("discourse_subscriptions.subscribe.countries.NG"),
"Nigeria"
);
});
}); });