From aaff445019091b0e226e62da4986de2f90c51c12 Mon Sep 17 00:00:00 2001
From: Rimian Perkins <hello@rimian.com.au>
Date: Tue, 4 Apr 2017 14:34:33 +1000
Subject: [PATCH] check email is not empty

---
 app/controllers/discourse_donations/charges_controller.rb | 2 +-
 .../discourse_donations/charges_controller_spec.rb        | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/app/controllers/discourse_donations/charges_controller.rb b/app/controllers/discourse_donations/charges_controller.rb
index df91aeb..8cf51f2 100644
--- a/app/controllers/discourse_donations/charges_controller.rb
+++ b/app/controllers/discourse_donations/charges_controller.rb
@@ -7,7 +7,7 @@ module DiscourseDonations
     skip_before_filter :verify_authenticity_token, only: [:create]
 
     def create
-      if email.nil?
+      if email.nil? || email.empty?
         response = {'message' => 'Please enter your email address'}
       elsif create_account && params[:username].nil?
         response = {'message' => 'Please enter a username'}
diff --git a/spec/controllers/discourse_donations/charges_controller_spec.rb b/spec/controllers/discourse_donations/charges_controller_spec.rb
index a6a73c1..2153aed 100644
--- a/spec/controllers/discourse_donations/charges_controller_spec.rb
+++ b/spec/controllers/discourse_donations/charges_controller_spec.rb
@@ -17,7 +17,13 @@ module DiscourseDonations
     end
 
     it 'responds ok when the email is empty' do
-      post :create, { }
+      post :create, { create_account: 'true', email: '' }
+      expect(body['message']).to eq('Please enter your email address')
+      expect(response).to have_http_status(200)
+    end
+
+    it 'responds ok when the email is empty' do
+      post :create, { create_account: 'false' }
       expect(body['message']).to eq('Please enter your email address')
       expect(response).to have_http_status(200)
     end