mirror of
https://github.com/discourse/discourse-subscriptions.git
synced 2025-08-12 23:43:25 +00:00
46759c90cd
Duplicate payments were showing up in the discourse ui for users. Actual transactions in stripe were not being duplicated. This fix ensures that when parsing the api response we don't append any duplicates. Added a duplicate entry to the specs to test for this. I do think there can be some improvements made to this controller endpoint, but I'd like to save those for a different and larger PR and just get this fix out first.
108 lines
2.6 KiB
Ruby
108 lines
2.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
module DiscourseSubscriptions
|
|
RSpec.describe User::PaymentsController do
|
|
it 'is a subclass of ApplicationController' do
|
|
expect(DiscourseSubscriptions::User::PaymentsController < ::ApplicationController).to eq(true)
|
|
end
|
|
|
|
context "not authenticated" do
|
|
it "does not get the payment intents" do
|
|
::Stripe::PaymentIntent.expects(:list).never
|
|
get "/s/user/payments.json"
|
|
expect(response.status).to eq(403)
|
|
end
|
|
end
|
|
|
|
context "authenticated" do
|
|
let(:user) { Fabricate(:user, email: 'zasch@example.com') }
|
|
|
|
before do
|
|
sign_in(user)
|
|
Fabricate(:customer, customer_id: 'c_345678', user_id: user.id)
|
|
Fabricate(:product, external_id: 'prod_8675309')
|
|
Fabricate(:product, external_id: 'prod_8675310')
|
|
end
|
|
|
|
it "gets payment intents" do
|
|
created_time = Time.now
|
|
::Stripe::Invoice.expects(:list).with(
|
|
customer: 'c_345678'
|
|
).returns(
|
|
data: [
|
|
{
|
|
id: "inv_900007",
|
|
lines: {
|
|
data: [
|
|
plan: {
|
|
product: "prod_8675309"
|
|
}
|
|
]
|
|
}
|
|
},
|
|
{
|
|
id: "inv_900008",
|
|
lines: {
|
|
data: [
|
|
plan: {
|
|
product: "prod_8675310"
|
|
}
|
|
]
|
|
}
|
|
},
|
|
{
|
|
id: "inv_900008",
|
|
lines: {
|
|
data: [
|
|
plan: {
|
|
product: "prod_8675310"
|
|
}
|
|
]
|
|
}
|
|
},
|
|
]
|
|
)
|
|
|
|
::Stripe::PaymentIntent.expects(:list).with(
|
|
customer: 'c_345678',
|
|
).returns(
|
|
data: [
|
|
{
|
|
id: "pi_900008",
|
|
invoice: "inv_900008",
|
|
created: created_time
|
|
},
|
|
{
|
|
id: "pi_900008",
|
|
invoice: "inv_900008",
|
|
created: created_time
|
|
},
|
|
{
|
|
id: "pi_900007",
|
|
invoice: "inv_900007",
|
|
created: Time.now
|
|
},
|
|
{
|
|
id: "pi_007",
|
|
invoice: "inv_007",
|
|
created: Time.now
|
|
}
|
|
]
|
|
)
|
|
|
|
get "/s/user/payments.json"
|
|
|
|
parsed_body = response.parsed_body
|
|
invoice = parsed_body[0]["invoice"]
|
|
|
|
expect(invoice).to eq("inv_900007")
|
|
expect(parsed_body.count).to eq(2)
|
|
|
|
end
|
|
|
|
end
|
|
end
|
|
end
|