discourse/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-06 11:19:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

UX: Rename Most Disagreed Flaggers report to "User Flagging Ratio"

Browse Source
This commit is contained in:
Robin Ward 2018-11-12 16:23:10 -05:00
parent dda1824270
commit 0cb33d2b52
7 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/admin/controllers/admin-dashboard-next-moderation.js.es6
View File

@ -13,7 +13,7 @@ export default Ember.Controller.extend(PeriodComputationMixin, {
}, },
@computed @computed
mostDisagreedFlaggersOptions() { userFlaggingRatioOptions() {
return { return {
table: { table: {
total: false, total: false,

4
app/assets/javascripts/admin/templates/dashboard_next_moderation.hbs
View File

@ -34,9 +34,9 @@
filters=lastWeekfilters}} filters=lastWeekfilters}}
{{admin-report {{admin-report
dataSourceName="most_disagreed_flaggers" dataSourceName="user_flagging_ratio"
filters=lastWeekfilters filters=lastWeekfilters
reportOptions=mostDisagreedFlaggersOptions}} reportOptions=userFlaggingRatioOptions}}
{{plugin-outlet name="admin-dashboard-moderation-bottom"}} {{plugin-outlet name="admin-dashboard-moderation-bottom"}}
</div> </div>

14
app/models/report.rb
View File

@ -1170,7 +1170,7 @@ class Report
end end
end end
def self.report_most_disagreed_flaggers(report) def self.report_user_flagging_ratio(report)
report.data = [] report.data = []
report.modes = [:table] report.modes = [:table]
@ -1185,27 +1185,27 @@ class Report
id: :user_id, id: :user_id,
avatar: :avatar_template, avatar: :avatar_template,
}, },
title: I18n.t("reports.most_disagreed_flaggers.labels.user") title: I18n.t("reports.user_flagging_ratio.labels.user")
}, },
{ {
type: :number, type: :number,
property: :disagreed_flags, property: :disagreed_flags,
title: I18n.t("reports.most_disagreed_flaggers.labels.disagreed_flags") title: I18n.t("reports.user_flagging_ratio.labels.disagreed_flags")
}, },
{ {
type: :number, type: :number,
property: :agreed_flags, property: :agreed_flags,
title: I18n.t("reports.most_disagreed_flaggers.labels.agreed_flags") title: I18n.t("reports.user_flagging_ratio.labels.agreed_flags")
}, },
{ {
type: :number, type: :number,
property: :ignored_flags, property: :ignored_flags,
title: I18n.t("reports.most_disagreed_flaggers.labels.ignored_flags") title: I18n.t("reports.user_flagging_ratio.labels.ignored_flags")
}, },
{ {
type: :number, type: :number,
property: :score, property: :score,
title: I18n.t("reports.most_disagreed_flaggers.labels.score") title: I18n.t("reports.user_flagging_ratio.labels.score")
}, },
] ]
@ -1224,7 +1224,7 @@ class Report
WHERE u.id <> -1 WHERE u.id <> -1
AND flags_disagreed > flags_agreed AND flags_disagreed > flags_agreed
ORDER BY score DESC ORDER BY score DESC
LIMIT 20 LIMIT 100
SQL SQL
DB.query(sql).each do |row| DB.query(sql).each do |row|

2
config/locales/server.de.yml
View File

@ -797,7 +797,7 @@ de:
editor: Bearbeiter editor: Bearbeiter
author: Ersteller author: Ersteller
edit_reason: Grund edit_reason: Grund
most_disagreed_flaggers: user_flagging_ratio:
title: "Melder mit höchster Ablehnung" title: "Melder mit höchster Ablehnung"
labels: labels:
user: Benutzer user: Benutzer

4
config/locales/server.en.yml
View File

@ -894,8 +894,8 @@ en:
editor: Editor editor: Editor
author: Author author: Author
edit_reason: Reason edit_reason: Reason
most_disagreed_flaggers: user_flagging_ratio:
title: "Most disagreed flaggers" title: "User Flagging Ratio"
labels: labels:
user: User user: User
agreed_flags: Agreed flags agreed_flags: Agreed flags

2
config/locales/server.es.yml
View File

@ -796,7 +796,7 @@ es:
editor: Editor editor: Editor
author: Autor author: Autor
edit_reason: Motivo edit_reason: Motivo
most_disagreed_flaggers: user_flagging_ratio:
title: "Most disagreed flaggers" title: "Most disagreed flaggers"
labels: labels:
user: Usuari user: Usuari

4
spec/models/report_spec.rb
View File

@ -936,7 +936,7 @@ describe Report do
end end
end end
describe 'most_disagreed_flaggers' do describe 'user_flagging_ratio' do
let(:joffrey) { Fabricate(:user, username: "joffrey") } let(:joffrey) { Fabricate(:user, username: "joffrey") }
let(:robin) { Fabricate(:user, username: "robin") } let(:robin) { Fabricate(:user, username: "robin") }
let(:moderator) { Fabricate(:moderator) } let(:moderator) { Fabricate(:moderator) }
@ -958,7 +958,7 @@ describe Report do
PostAction.act(robin, post_agreed, PostActionType.types[:off_topic]) PostAction.act(robin, post_agreed, PostActionType.types[:off_topic])
PostAction.agree_flags!(post_agreed, moderator) PostAction.agree_flags!(post_agreed, moderator)
report = Report.find('most_disagreed_flaggers') report = Report.find('user_flagging_ratio')
first = report.data[0] first = report.data[0]
expect(first[:username]).to eq("joffrey") expect(first[:username]).to eq("joffrey")