discourse/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-09 14:34:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: prevents user-tips to interfere with widget (#23066)

Browse Source 
Prior to this fix the user tip was rendered with panels and interfering with widget code. I suspect it was causing the widget node  (revamped-hamburger-menu-wrapper) to not be removed, as a result clickOutside would be called two times, negating the effect of the click.

This fix is just rendering the tip in a different node, preventing the interference, it shouldn't impact behavior as the positioning is absolute.
This commit is contained in:
Joffrey JAFFEUX 2023-08-11 10:41:39 +02:00 committed by GitHub
parent 8053cb0c21
commit 31626ce85d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/widgets/header.js
View File

@ -163,7 +163,7 @@ createWidget("header-notifications", {
reference: document reference: document
.querySelector(".d-header .badge-notification") .querySelector(".d-header .badge-notification")
?.parentElement?.querySelector(".avatar"), ?.parentElement?.querySelector(".avatar"),
appendTo: document.querySelector(".d-header .panel"), appendTo: document.querySelector(".d-header"),
placement: "bottom-end", placement: "bottom-end",
}); });