From 82222e8d18842451b4bd3e1b5b138d9333d54d47 Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Fri, 24 Nov 2017 09:32:44 +0800 Subject: [PATCH] Improve specs to test for the right response status. --- spec/controllers/user_badges_controller_spec.rb | 2 +- spec/requests/users_controller_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/controllers/user_badges_controller_spec.rb b/spec/controllers/user_badges_controller_spec.rb index 161809bdb51..0d9dd609eff 100644 --- a/spec/controllers/user_badges_controller_spec.rb +++ b/spec/controllers/user_badges_controller_spec.rb @@ -22,7 +22,7 @@ describe UserBadgesController do it "fails when badges are disabled" do SiteSetting.enable_badges = false get :index, params: { badge_id: badge.id }, format: :json - expect(response).not_to be_success + expect(response.status).to eq(404) end end diff --git a/spec/requests/users_controller_spec.rb b/spec/requests/users_controller_spec.rb index b6e3184c1c5..7f3da8e9e42 100644 --- a/spec/requests/users_controller_spec.rb +++ b/spec/requests/users_controller_spec.rb @@ -35,7 +35,7 @@ RSpec.describe UsersController do it "fails if badges are disabled" do SiteSetting.enable_badges = false get "/u/#{user.username}/badges" - expect(response).not_to be_success + expect(response.status).to eq(404) end end