discourse/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-06 19:29:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Prevent group requests from loading infinitely (#28544)

Browse Source 
In GroupRequestsController, request_count is incorrectly written as
user_count, which causes group member requests to be loaded infinitely
when user_count is greater than request_count.
This commit is contained in:
锦心 2024-08-26 17:54:30 +08:00 committed by GitHub
parent 3eb7aa866c
commit a2dbade55d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/app/controllers/group-requests.js
View File

@ -16,7 +16,9 @@ export default class GroupRequestsController extends Controller {
loading = false; loading = false;
get canLoadMore() { get canLoadMore() {
return this.get("model.requesters")?.length < this.get("model.user_count"); return (
this.get("model.requesters")?.length < this.get("model.request_count")
);
} }
@observes("filterInput") @observes("filterInput")

2
app/assets/javascripts/discourse/tests/acceptance/group-requests-test.js
View File

@ -19,7 +19,7 @@ acceptance("Group Requests", function (needs) {
id: 42, id: 42,
automatic: false, automatic: false,
name: "Macdonald", name: "Macdonald",
user_count: 1, user_count: 10,
mentionable_level: 0, mentionable_level: 0,
messageable_level: 0, messageable_level: 0,
visibility_level: 0, visibility_level: 0,