discourse/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-09 14:34:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Incorrect URL for bookmark quick action menu (#16932)

Browse Source 
The bookmarkable_type instead of the bookmarkable_url
was being used for the link to the bookmark for the quick
access menu, leading to links like /ChatMessage. This
fixes the issue, follow up PR with tests for the quick
access menu to follow.
This commit is contained in:
Martin Brennan 2022-05-27 14:33:24 +10:00 committed by GitHub
parent d001093f83
commit ac59168dde
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/widgets/quick-access-bookmarks.js
View File

@ -62,7 +62,7 @@ createWidgetFrom(QuickAccessPanel, "quick-access-bookmarks", {
) {
href = postUrl(bookmark.slug, bookmark.topic_id, postNumber);
} else {
href = bookmark.bookmarkable_type;
href = bookmark.bookmarkable_url;
}
return this.attach("quick-access-item", {