discourse/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-06 11:19:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

UX: Convert bookmark icon from CSS to a proper icon using our helper

Browse Source
This commit is contained in:
Robin Ward 2017-09-07 11:41:19 -04:00
parent 0ba789de17
commit afc075d93b
2 changed files with 11 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/assets/javascripts/discourse/widgets/post-menu.js.es6
View File

@ -173,20 +173,18 @@ registerButton('reply', attrs => {
registerButton('bookmark', attrs => { registerButton('bookmark', attrs => {
if (!attrs.canBookmark) { return; } if (!attrs.canBookmark) { return; }
let iconClass = 'read-icon'; let className = 'bookmark';
let buttonClass = 'bookmark';
let tooltip = 'bookmarks.not_bookmarked';
if (attrs.bookmarked) { if (attrs.bookmarked) {
iconClass += ' bookmarked'; className += ' bookmarked';
buttonClass += ' bookmarked';
tooltip = 'bookmarks.created';
} }
return { action: 'toggleBookmark', return {
title: tooltip, action: 'toggleBookmark',
className: buttonClass, title: attrs.bookmarked ? "bookmarks.created" : "bookmarks.not_bookmarked",
contents: h('div', { className: iconClass }) }; className,
icon: 'bookmark'
};
}); });
registerButton('admin', attrs => { registerButton('admin', attrs => {

16
app/assets/stylesheets/desktop/topic-post.scss
View File

@ -161,25 +161,13 @@ nav.post-controls {
box-shadow: none; box-shadow: none;
} }
&.bookmark {padding: 8px 11px; } &.bookmark {
padding: 8px 11px;
.read-icon {
&:before {
font-family: "FontAwesome";
content: "\f02e";
}
&.unseen {
&:before {
content: "\f097";
}
}
&.bookmarked { &.bookmarked {
&:before {
color: $tertiary; color: $tertiary;
} }
} }
} }
}
.post-admin-menu { .post-admin-menu {
background-color: $secondary; background-color: $secondary;