discourse/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-06 19:29:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correct failing test

Browse Source 
WARNING: forEach is a trap when async is involved cause it leaks promises

for X of Y is a very clean workaround that keeps the code ver readable
This commit is contained in:
Sam 2019-02-20 16:15:10 +11:00
parent 10dad7d013
commit fa35b555b7
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/javascripts/lib/user-search-test.js.es6
View File

@ -80,10 +80,10 @@ QUnit.test("it skips a search depending on punctuations", async assert => {
"@sam:"
];
skippedTerms.forEach(async term => {
for (let term of skippedTerms) {
let results = await userSearch({ term });
assert.equal(results.length, 0);
});
}
let allowedTerms = [
"@sam sam", // double space is not allowed
@ -93,8 +93,8 @@ QUnit.test("it skips a search depending on punctuations", async assert => {
let topicId = 100;
allowedTerms.forEach(async term => {
for (let term of allowedTerms) {
let results = await userSearch({ term, topicId });
assert.equal(results.length, 6);
});
}
});