diff --git a/app/assets/javascripts/admin/addon/controllers/admin-badges/show.js b/app/assets/javascripts/admin/addon/controllers/admin-badges/show.js index caa4f632694..4f522673344 100644 --- a/app/assets/javascripts/admin/addon/controllers/admin-badges/show.js +++ b/app/assets/javascripts/admin/addon/controllers/admin-badges/show.js @@ -2,6 +2,7 @@ import { cached, tracked } from "@glimmer/tracking"; import Controller, { inject as controller } from "@ember/controller"; import { action, getProperties } from "@ember/object"; import { service } from "@ember/service"; +import { isNone } from "@ember/utils"; import { ajax } from "discourse/lib/ajax"; import { popupAjaxError } from "discourse/lib/ajax-error"; import getURL from "discourse-common/lib/get-url"; @@ -83,15 +84,15 @@ export default class AdminBadgesShowController extends Controller { // this is needed because the model doesnt have default values // Using `set` here isn't ideal, but we don't know that tracking is set up on the model yet. if (this.model) { - if (!this.model.badge_type_id) { + if (isNone(this.model.badge_type_id)) { this.model.set("badge_type_id", this.badgeTypes?.[0]?.id); } - if (!this.model.badge_grouping_id) { + if (isNone(this.model.badge_grouping_id)) { this.model.set("badge_grouping_id", this.badgeGroupings?.[0]?.id); } - if (!this.model.trigger) { + if (isNone(this.model.trigger)) { this.model.set("trigger", this.badgeTriggers?.[0]?.id); } } diff --git a/app/assets/javascripts/discourse/app/form-kit/components/fk/control/select/option.gjs b/app/assets/javascripts/discourse/app/form-kit/components/fk/control/select/option.gjs index 9604be417ce..f334f11bdcf 100644 --- a/app/assets/javascripts/discourse/app/form-kit/components/fk/control/select/option.gjs +++ b/app/assets/javascripts/discourse/app/form-kit/components/fk/control/select/option.gjs @@ -1,12 +1,11 @@ import Component from "@glimmer/component"; +import { isNone } from "@ember/utils"; import { eq } from "truth-helpers"; import { NO_VALUE_OPTION } from "discourse/form-kit/lib/constants"; export default class FKControlSelectOption extends Component { get value() { - return typeof this.args.value === "undefined" - ? NO_VALUE_OPTION - : this.args.value; + return isNone(this.args.value) ? NO_VALUE_OPTION : this.args.value; }