From 01d1cb0ce6023b70c1a81714f96ddd6c65634361 Mon Sep 17 00:00:00 2001 From: Ryan Bogan <10944539+ryanbogan@users.noreply.github.com> Date: Thu, 11 Nov 2021 18:24:26 -0500 Subject: [PATCH] Updated links for linkchecker (#1539) Signed-off-by: Ryan Bogan --- MAINTAINERS.md | 2 +- plugins/repository-hdfs/licenses/avro-NOTICE.txt | 2 +- qa/os/README.md | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 7c374cc9096..3429d8bd0f9 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -7,7 +7,7 @@ | Harold Wang | [harold-wang](https://github.com/harold-wang) | Amazon | | Himanshu Setia | [setiah](https://github.com/setiah) | Amazon | | Nick Knize | [nknize](https://github.com/nknize) | Amazon | -| Rabi Panda | [adnapibar](adnapibar) | Amazon | +| Rabi Panda | [adnapibar](https://github.com/adnapibar) | Amazon | | Sarat Vemulapalli | [saratvemulapalli](https://github.com/saratvemulapalli) | Amazon | | Tianli Feng | [tlfeng](https://github.com/tlfeng) | Amazon | | Gopala Krishna Ambareesh | [krishna-ggk](https://github.com/krishna-ggk) |Amazon | diff --git a/plugins/repository-hdfs/licenses/avro-NOTICE.txt b/plugins/repository-hdfs/licenses/avro-NOTICE.txt index 16b3989d046..59e4273dfe5 100644 --- a/plugins/repository-hdfs/licenses/avro-NOTICE.txt +++ b/plugins/repository-hdfs/licenses/avro-NOTICE.txt @@ -46,7 +46,7 @@ Apache Ivy includes the following in its NOTICE file: | The Apache Software Foundation (https://www.apache.org/). | | Portions of Ivy were originally developed by -| Jayasoft SARL (http://www.jayasoft.fr/) +| Jayasoft SARL (http://www.jaya.free.fr/about.html) | and are licensed to the Apache Software Foundation under the | "Software Grant License Agreement" | diff --git a/qa/os/README.md b/qa/os/README.md index 5c958252858..a9b7ee269c4 100644 --- a/qa/os/README.md +++ b/qa/os/README.md @@ -23,14 +23,14 @@ See the section in [TESTING.md](../../TESTING.md#testing-packaging) When gradle runs the packaging tests on a VM, it runs the full suite by default. To add a test class to the suite, add its `class` to the -`@SuiteClasses` annotation in [PackagingTests.java](src/main/java/org/opensearch/packaging/PackagingTests.java). +`@SuiteClasses` annotation in [PackageTests.java](src/test/java/org/opensearch/packaging/test/PackageTests.java). If a test class is added to the project but not to this annotation, it will not run in CI jobs. The test classes are run in the order they are listed in the annotation. ## Choosing which distributions to test -Distributions are represented by [enum values](src/main/java/org/opensearch/packaging/util/Distribution.java) +Distributions are represented by [enum values](src/test/java/org/opensearch/packaging/util/Distribution.java) which know if they are compatible with the platform the tests are currently running on. To skip a test if the distribution it's using isn't compatible with the current platform, put this [assumption](https://github.com/junit-team/junit4/wiki/assumptions-with-assume) @@ -41,7 +41,7 @@ assumeTrue(distribution.packaging.compatible); ``` Similarly if you write a test that is intended only for particular platforms, -you can make an assumption using the constants and methods in [Platforms.java](src/main/java/org/opensearch/packaging/util/Platforms.java) +you can make an assumption using the constants and methods in [Platforms.java](src/test/java/org/opensearch/packaging/util/Platforms.java) ```java assumeTrue("only run on windows", Platforms.WINDOWS); @@ -73,14 +73,14 @@ public class MyTestDefaultTar extends MyTestCase { ``` That way when a test fails the user gets told explicitly that `MyTestDefaultTar` -failed, and to reproduce it they should run that class. See [ArchiveTestCase](src/main/java/org/opensearch/packaging/test/ArchiveTestCase.java) +failed, and to reproduce it they should run that class. See [ArchiveTests](src/test/java/org/opensearch/packaging/test/ArchiveTests.java) and its children for an example of this. ## Running external commands In general it's probably best to avoid running external commands when a good Java alternative exists. For example most filesystem operations can be done with -the java.nio.file APIs. For those that aren't, use an instance of [Shell](src/main/java/org/opensearch/packaging/util/Shell.java) +the java.nio.file APIs. For those that aren't, use an instance of [Shell](src/test/java/org/opensearch/packaging/util/Shell.java) This class runs scripts in either bash with the `bash -c