honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rebooted master-ineligibles should not bootstrap (#55302) 

In #55298 we saw a failure of `CoordinationStateTests#testSafety` in which a
single master-eligible node is bootstrapped, then rebooted as a
master-ineligible node (losing its persistent state) and then rebooted as a
master-eligible node and bootstrapped again.

This happens because this test loses too much of the persistent state; in fact
once bootstrapped the node would not allow itself to be bootstrapped again.
This commit adjusts the test logic to reflect this.

Closes #55298
This commit is contained in:
David Turner 2020-04-20 09:10:04 +01:00
parent 9ecb222bfa
commit 0458770556
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/framework/src/main/java/org/elasticsearch/cluster/coordination/CoordinationStateTestCluster.java
View File

@ -106,10 +106,14 @@ public class CoordinationStateTestCluster {
void reboot() { void reboot() {
if (localNode.isMasterNode() == false && rarely()) { if (localNode.isMasterNode() == false && rarely()) {
// master-ineligible nodes can't be trusted to persist the cluster state properly // master-ineligible nodes can't be trusted to persist the cluster state properly, but will not lose the fact that they
persistedState = new InMemoryPersistedState(0L, // were bootstrapped
clusterState(0L, 0L, localNode, CoordinationMetadata.VotingConfiguration.EMPTY_CONFIG, final CoordinationMetadata.VotingConfiguration votingConfiguration
CoordinationMetadata.VotingConfiguration.EMPTY_CONFIG, 0L)); = persistedState.getLastAcceptedState().getLastAcceptedConfiguration().isEmpty()
? CoordinationMetadata.VotingConfiguration.EMPTY_CONFIG
: CoordinationMetadata.VotingConfiguration.MUST_JOIN_ELECTED_MASTER;
persistedState
= new InMemoryPersistedState(0L, clusterState(0L, 0L, localNode, votingConfiguration, votingConfiguration, 0L));
} }
final Set<DiscoveryNodeRole> roles = new HashSet<>(localNode.getRoles()); final Set<DiscoveryNodeRole> roles = new HashSet<>(localNode.getRoles());