honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Search - enable low_level_cancellation by default. (#42291) (#42857) 

Benchmarking on worst-case queries (max agg on match_all or popular-term query with large index) was not noticeably slower.

Closes #26258
This commit is contained in:
markharwood 2019-06-07 14:53:17 +01:00 committed by GitHub
parent b77be89c9a
commit 0719779a48
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/src/main/java/org/elasticsearch/search/SearchService.java
View File

@ -134,11 +134,11 @@ public class SearchService extends AbstractLifecycleComponent implements IndexEv
/** /**
* Enables low-level, frequent search cancellation checks. Enabling low-level checks will make long running searches to react * Enables low-level, frequent search cancellation checks. Enabling low-level checks will make long running searches to react
* to the cancellation request faster. However, since it will produce more cancellation checks it might slow the search performance * to the cancellation request faster. It will produce more cancellation checks but benchmarking has shown these did not
* down. * noticeably slow down searches.
*/ */
public static final Setting<Boolean> LOW_LEVEL_CANCELLATION_SETTING = public static final Setting<Boolean> LOW_LEVEL_CANCELLATION_SETTING =
Setting.boolSetting("search.low_level_cancellation", false, Property.Dynamic, Property.NodeScope); Setting.boolSetting("search.low_level_cancellation", true, Property.Dynamic, Property.NodeScope);
public static final TimeValue NO_TIMEOUT = timeValueMillis(-1); public static final TimeValue NO_TIMEOUT = timeValueMillis(-1);
public static final Setting<TimeValue> DEFAULT_SEARCH_TIMEOUT_SETTING = public static final Setting<TimeValue> DEFAULT_SEARCH_TIMEOUT_SETTING =