honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ML] changing ngram loop order for minor performance improvement (#63033) (#63059) 

This is a very minor optimization but trivial to implement, so might as well. 

```
Benchmark                               (nGramStrs)  Mode  Cnt        Score        Error  Units
NGramProcessorBenchmark.ngramInnerLoop        1,2,3  avgt   20  4415092.443 ±  31302.115  ns/op
NGramProcessorBenchmark.ngramOuterLoop        1,2,3  avgt   20  4235550.340 ± 103393.465  ns/op
```

This measurement is in nanoseconds, consequently, the overall performance of inference is dominated by other factors (i.e. map#put). But, this optimization adds up overtime and is simple.
This commit is contained in:
Benjamin Trent 2020-09-30 07:51:31 -04:00 committed by GitHub
parent b7c47b1717
commit 0860746bf2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/inference/preprocessing/NGram.java
View File

@ -184,8 +184,8 @@ public class NGram implements LenientlyParsedPreProcessor, StrictlyParsedPreProc
} }
final int startPos = start < 0 ? (stringValue.length() + start) : start; final int startPos = start < 0 ? (stringValue.length() + start) : start;
final int len = Math.min(startPos + length, stringValue.length()); final int len = Math.min(startPos + length, stringValue.length());
for (int i = 0; i < len; i++) { for (int nGram : nGrams) {
for (int nGram : nGrams) { for (int i = 0; i < len; i++) {
if (startPos + i + nGram > len) { if (startPos + i + nGram > len) {
break; break;
} }