From 0a702502017877fea1f28a88adc9364daed4fba4 Mon Sep 17 00:00:00 2001 From: Armin Braun Date: Wed, 25 Mar 2020 12:13:52 +0100 Subject: [PATCH] Fix BlobStoreIncrementalityIT Assertion (#54149) (#54155) We are using this assertion for identical shard snapshots for situations where `snapshot1` wasn't the first snapshot for the tested shard. Hence, we can't assume that it will not share any files with previous snapshots. This showed up in failing tests when `snapshot1` was equivalent to a previous snapshot because no documents were deleted from the repo randomly in the failing test but even if documents are deleted there is no guarantee that no files will be shared. => I removed this assertion since its immaterial for what is tested here anyway. Closes #54034 --- .../org/elasticsearch/snapshots/BlobStoreIncrementalityIT.java | 1 - 1 file changed, 1 deletion(-) diff --git a/server/src/test/java/org/elasticsearch/snapshots/BlobStoreIncrementalityIT.java b/server/src/test/java/org/elasticsearch/snapshots/BlobStoreIncrementalityIT.java index 73dd952cca1..44672792caa 100644 --- a/server/src/test/java/org/elasticsearch/snapshots/BlobStoreIncrementalityIT.java +++ b/server/src/test/java/org/elasticsearch/snapshots/BlobStoreIncrementalityIT.java @@ -191,7 +191,6 @@ public class BlobStoreIncrementalityIT extends AbstractSnapshotIntegTestCase { final SnapshotStats firstSnapshotShardStatus = getStats(repo, snapshot1).getIndices().get(indexName).getShards().get(0).getStats(); final int totalFilesInShard = firstSnapshotShardStatus.getTotalFileCount(); assertThat(totalFilesInShard, greaterThan(0)); - assertThat(firstSnapshotShardStatus.getIncrementalFileCount(), is(totalFilesInShard)); final SnapshotStats secondSnapshotShardStatus = getStats(repo, snapshot2).getIndices().get(indexName).getShards().get(0).getStats(); assertThat(secondSnapshotShardStatus.getTotalFileCount(), is(totalFilesInShard));