honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Restore assertion on discount overlaps in SimilarityTests 

This assertion was commented out as the getDiscountOverlaps getter was
missing from LegacyBm25Similarity. That has been fixed in lucene.
This commit is contained in:
Luca Cavanna 2019-01-15 16:42:55 +01:00
parent 1a1dbf705f
commit 0b396a0c5e
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
server/src/test/java/org/elasticsearch/index/similarity/SimilarityTests.java
View File

@ -99,8 +99,7 @@ public class SimilarityTests extends ESSingleNodeTestCase {
LegacyBM25Similarity similarity = (LegacyBM25Similarity) mapperService.fullName("field1").similarity().get(); LegacyBM25Similarity similarity = (LegacyBM25Similarity) mapperService.fullName("field1").similarity().get();
assertThat(similarity.getK1(), equalTo(2.0f)); assertThat(similarity.getK1(), equalTo(2.0f));
assertThat(similarity.getB(), equalTo(0.5f)); assertThat(similarity.getB(), equalTo(0.5f));
// TODO: re-enable when we switch back to BM25Similarity assertThat(similarity.getDiscountOverlaps(), equalTo(false));
// assertThat(similarity.getDiscountOverlaps(), equalTo(false));
} }
public void testResolveSimilaritiesFromMapping_boolean() throws IOException { public void testResolveSimilaritiesFromMapping_boolean() throws IOException {