honeymoose/OpenSearch
1
0
Fork 0
mirror of https://github.com/honeymoose/OpenSearch.git synced 2025-02-17 10:25:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[TEST] Add better assertion messages

Browse Source
This commit is contained in:
Simon Willnauer 2015-05-20 13:00:26 +02:00
parent 42ad677127
commit 0bc5b35a59
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/java/org/elasticsearch/test/ElasticsearchIntegrationTest.java
View File

@ -1177,17 +1177,17 @@ public abstract class ElasticsearchIntegrationTest extends ElasticsearchTestCase
byte[] localClusterStateBytes = ClusterState.Builder.toBytes(localClusterState); byte[] localClusterStateBytes = ClusterState.Builder.toBytes(localClusterState);
// remove local node reference // remove local node reference
localClusterState = ClusterState.Builder.fromBytes(localClusterStateBytes, null); localClusterState = ClusterState.Builder.fromBytes(localClusterStateBytes, null);
Map<String, Object> localStateMap = convertToMap(localClusterState); final Map<String, Object> localStateMap = convertToMap(localClusterState);
int localClusterStateSize = localClusterState.toString().length(); final int localClusterStateSize = localClusterState.toString().length();
// Check that the non-master node has the same version of the cluster state as the master and that this node didn't disconnect from the master // Check that the non-master node has the same version of the cluster state as the master and that this node didn't disconnect from the master
if (masterClusterState.version() == localClusterState.version() && localClusterState.nodes().nodes().containsKey(masterId)) { if (masterClusterState.version() == localClusterState.version() && localClusterState.nodes().nodes().containsKey(masterId)) {
try { try {
assertThat(masterClusterState.uuid(), equalTo(localClusterState.uuid())); assertEquals("clusterstate UUID does not match", masterClusterState.uuid(), localClusterState.uuid());
// We cannot compare serialization bytes since serialization order of maps is not guaranteed // We cannot compare serialization bytes since serialization order of maps is not guaranteed
// but we can compare serialization sizes - they should be the same // but we can compare serialization sizes - they should be the same
assertThat(masterClusterStateSize, equalTo(localClusterStateSize)); assertEquals("clusterstate size does not match", masterClusterStateSize, localClusterStateSize);
// Compare JSON serialization // Compare JSON serialization
assertThat(mapsEqualIgnoringArrayOrder(masterStateMap, localStateMap), equalTo(true)); assertTrue("clusterstate JSON serialization does not match", mapsEqualIgnoringArrayOrder(masterStateMap, localStateMap));
} catch (AssertionError error) { } catch (AssertionError error) {
logger.error("Cluster state from master:\n{}\nLocal cluster state:\n{}", masterClusterState.toString(), localClusterState.toString()); logger.error("Cluster state from master:\n{}\nLocal cluster state:\n{}", masterClusterState.toString(), localClusterState.toString());
throw error; throw error;