honeymoose/OpenSearch
1
0
Fork 0
mirror of https://github.com/honeymoose/OpenSearch.git synced 2025-02-24 22:09:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Docs] Minor fix for SubmitAsyncSearchRequest.keepOnCompletion javadoc (#54325)

Browse Source 
The semantics and the default value for this parameter have changed, adapting
the javadoc accordingly.
This commit is contained in:
Christoph Büscher 2020-03-27 16:01:38 +01:00
parent 2984a54b7f
commit 0d17295601
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
client/rest-high-level/src/main/java/org/elasticsearch/client/asyncsearch/SubmitAsyncSearchRequest.java
View File

@ -77,14 +77,14 @@ public class SubmitAsyncSearchRequest implements Validatable {
}
/**
* Returns whether the resource resource should be removed on completion or failure (defaults to true).
* Returns whether the resource resource should be kept on completion or failure (defaults to false).
*/
public Boolean isKeepOnCompletion() {
return keepOnCompletion;
}
/**
* Determines if the resource should be removed on completion or failure (defaults to true).
* Determines if the resource should be kept on completion or failure (defaults to false).
*/
public void setKeepOnCompletion(boolean keepOnCompletion) {
this.keepOnCompletion = keepOnCompletion;

10
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/search/action/SubmitAsyncSearchRequest.java
View File

@ -113,7 +113,7 @@ public class SubmitAsyncSearchRequest extends ActionRequest {
}
/**
* Should the resource be removed on completion or failure (defaults to true).
* Should the resource be kept on completion or failure (defaults to false).
*/
public SubmitAsyncSearchRequest setKeepOnCompletion(boolean value) {
this.keepOnCompletion = value;
@ -162,8 +162,12 @@ public class SubmitAsyncSearchRequest extends ActionRequest {
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
if (this == o) {
return true;
}
if (o == null || getClass() != o.getClass()) {
return false;
}
SubmitAsyncSearchRequest request1 = (SubmitAsyncSearchRequest) o;
return keepOnCompletion == request1.keepOnCompletion &&
waitForCompletionTimeout.equals(request1.waitForCompletionTimeout) &&