honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Tests: Fix test to not collide on same ports 

The build at https://build.elasticsearch.com/job/es_shield_plugin/5302/ failed
due to both tests running on the same port.
This cleans up a the test a bit to not have any static components and more independent behaviour.

Original commit: elastic/x-pack-elasticsearch@89db247d3d
This commit is contained in:
Alexander Reelsen 2015-01-05 10:30:16 +01:00
parent 4efe6f1640
commit 112b6a0e57
1 changed files with 75 additions and 81 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

86
src/test/java/org/elasticsearch/shield/transport/netty/HandshakeWaitingHandlerTests.java
View File

@ -20,6 +20,8 @@ import org.junit.*;
import javax.net.ssl.SSLContext;
import javax.net.ssl.SSLEngine;
import javax.net.ssl.SSLException;
import java.io.PrintWriter;
import java.io.StringWriter;
import java.net.InetSocketAddress;
import java.nio.file.Paths;
import java.security.SecureRandom;
@ -32,18 +34,28 @@ import static org.elasticsearch.common.settings.ImmutableSettings.settingsBuilde
import static org.hamcrest.Matchers.*;
public class HandshakeWaitingHandlerTests extends ElasticsearchTestCase {
private static final int CONCURRENT_CLIENT_REQUESTS = 20;
private static ServerBootstrap serverBootstrap;
private static ClientBootstrap clientBootstrap;
private static SSLContext sslContext;
private static int iterations;
private static int randomPort;
private ServerBootstrap serverBootstrap;
private ClientBootstrap clientBootstrap;
private SSLContext sslContext;
private final AtomicBoolean failed = new AtomicBoolean(false);
private volatile Throwable failureCause = null;
private ExecutorService threadPoolExecutor;
@BeforeClass
public static void setup() throws Exception {
public static void generatePort() {
randomPort = randomIntBetween(49000, 65500);
iterations = randomIntBetween(10, 100);
}
@Before
public void setup() throws Exception {
SSLService sslService = new SSLService(settingsBuilder()
.put("shield.ssl.keystore.path", Paths.get(HandshakeWaitingHandlerTests.class.getResource("/org/elasticsearch/shield/transport/ssl/certs/simple/testnode.jks").toURI()))
.put("shield.ssl.keystore.password", "testnode")
@ -51,30 +63,31 @@ public class HandshakeWaitingHandlerTests extends ElasticsearchTestCase {
sslContext = sslService.getSslContext();
ChannelFactory factory = new NioServerSocketChannelFactory(
Executors.newFixedThreadPool(1),
Executors.newFixedThreadPool(1));
serverBootstrap = new ServerBootstrap(factory);
serverBootstrap = new ServerBootstrap(new NioServerSocketChannelFactory());
serverBootstrap.setPipelineFactory(getServerFactory());
serverBootstrap.bind(new InetSocketAddress("localhost", randomPort));
ChannelFactory clientFactory = new NioClientSocketChannelFactory(
Executors.newCachedThreadPool(),
Executors.newCachedThreadPool());
clientBootstrap = new ClientBootstrap(clientFactory);
clientBootstrap = new ClientBootstrap(new NioClientSocketChannelFactory());
iterations = randomIntBetween(10, 100);
threadPoolExecutor = Executors.newFixedThreadPool(CONCURRENT_CLIENT_REQUESTS);
}
@After
public void reset() {
threadPoolExecutor.shutdown();
clientBootstrap.shutdown();
clientBootstrap.releaseExternalResources();
serverBootstrap.shutdown();
serverBootstrap.releaseExternalResources();
failed.set(false);
failureCause = null;
}
@Test
public void testWriteBeforeHandshakeFailsWithoutHandler() throws Exception {
serverBootstrap.setPipelineFactory(getServerFactory());
final int randomPort = randomIntBetween(49000, 65500);
serverBootstrap.bind(new InetSocketAddress("localhost", randomPort));
clientBootstrap.setPipelineFactory(new ChannelPipelineFactory() {
@Override
@ -86,8 +99,6 @@ public class HandshakeWaitingHandlerTests extends ElasticsearchTestCase {
}
});
ExecutorService threadPoolExecutor = Executors.newFixedThreadPool(CONCURRENT_CLIENT_REQUESTS);
try {
List<Callable<ChannelFuture>> callables = new ArrayList<>(CONCURRENT_CLIENT_REQUESTS);
for (int i = 0; i < CONCURRENT_CLIENT_REQUESTS; i++) {
callables.add(new WriteBeforeHandshakeCompletedCallable(clientBootstrap, randomPort));
@ -107,19 +118,11 @@ public class HandshakeWaitingHandlerTests extends ElasticsearchTestCase {
}
}
if (!failed.get()) {
fail("Expected this test to fail with an SSLException or AssertionError");
}
} finally {
threadPoolExecutor.shutdown();
}
assertThat("Expected this test to fail with an SSLException or AssertionError", failed.get(), is(true));
}
@Test
public void testWriteBeforeHandshakePassesWithHandshakeWaitingHandler() throws Exception {
serverBootstrap.setPipelineFactory(getServerFactory());
final int randomPort = randomIntBetween(49000, 65500);
serverBootstrap.bind(new InetSocketAddress("localhost", randomPort));
clientBootstrap.setPipelineFactory(new ChannelPipelineFactory() {
@Override
@ -132,8 +135,6 @@ public class HandshakeWaitingHandlerTests extends ElasticsearchTestCase {
}
});
ExecutorService threadPoolExecutor = Executors.newFixedThreadPool(CONCURRENT_CLIENT_REQUESTS);
try {
List<Callable<ChannelFuture>> callables = new ArrayList<>(CONCURRENT_CLIENT_REQUESTS);
for (int i = 0; i < CONCURRENT_CLIENT_REQUESTS; i++) {
callables.add(new WriteBeforeHandshakeCompletedCallable(clientBootstrap, randomPort));
@ -149,20 +150,24 @@ public class HandshakeWaitingHandlerTests extends ElasticsearchTestCase {
Channel channel = handshakeFuture.getChannel();
HandshakeWaitingHandler handler = channel.getPipeline().get(HandshakeWaitingHandler.class);
while (handler != null && handler.hasPendingWrites()) {
Thread.sleep(10);
sleep(10);
}
channel.close();
}
if (failed.get()) {
failureCause.printStackTrace();
fail("Expected this test to always pass with the HandshakeWaitingHandler in pipeline");
assertNotFailed();
}
}
} finally {
threadPoolExecutor.shutdown();
private void assertNotFailed() {
if (failed.get()) {
StringWriter writer = new StringWriter();
if (failed.get()) {
failureCause.printStackTrace(new PrintWriter(writer));
}
assertThat("Expected this test to always pass with the HandshakeWaitingHandler in pipeline\n" + writer.toString(), failed.get(), is(false));
}
}
@ -193,17 +198,6 @@ public class HandshakeWaitingHandlerTests extends ElasticsearchTestCase {
};
}
@AfterClass
public static void cleanUp() {
clientBootstrap.shutdown();
serverBootstrap.shutdown();
clientBootstrap.releaseExternalResources();
serverBootstrap.releaseExternalResources();
clientBootstrap = null;
serverBootstrap = null;
sslContext = null;
}
private static class WriteBeforeHandshakeCompletedCallable implements Callable<ChannelFuture> {
private final ClientBootstrap bootstrap;