honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Painless: Disable java-9 indy string thing 

It is breaking some of the doc tests. Also add a unit test that
shows the failure.

Relates to #18929
This commit is contained in:
Nik Everett 2016-06-16 15:06:01 -04:00
parent b665d8a187
commit 13d16fbf41
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/lang-painless/src/main/java/org/elasticsearch/painless/WriterConstants.java
View File

@ -131,7 +131,7 @@ public final class WriterConstants {
// not Java 9 - we set it null, so MethodWriter uses StringBuilder: // not Java 9 - we set it null, so MethodWriter uses StringBuilder:
bs = null; bs = null;
} }
INDY_STRING_CONCAT_BOOTSTRAP_HANDLE = bs; INDY_STRING_CONCAT_BOOTSTRAP_HANDLE = null; // Disabled until https://github.com/elastic/elasticsearch/issues/18929
} }
public final static int MAX_INDY_STRING_CONCAT_ARGS = 200; public final static int MAX_INDY_STRING_CONCAT_ARGS = 200;

4
modules/lang-painless/src/test/java/org/elasticsearch/painless/StringTests.java
View File

@ -221,4 +221,8 @@ public class StringTests extends ScriptTestCase {
exec("def x = null; def y = null; x += y"); exec("def x = null; def y = null; x += y");
}); });
} }
public void testAppendStringIntoMap() {
assertEquals("nullcat", exec("def a = new HashMap(); a.cat += 'cat'"));
}
} }