From 17b7d2efcb5f94596f2bc9bd6d8710db7beceab1 Mon Sep 17 00:00:00 2001 From: javanna Date: Tue, 6 Nov 2018 13:36:22 +0100 Subject: [PATCH] [TEST] increase await timeout in RemoteClusterConnectionTests We have seen an improvement when we bumped the timeout from 1s to 5s, but there are still a few failures for this tests. With this commit we bump the timeout to 10 seconds hoping it will stop all the failures. --- .../transport/RemoteClusterConnectionTests.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/server/src/test/java/org/elasticsearch/transport/RemoteClusterConnectionTests.java b/server/src/test/java/org/elasticsearch/transport/RemoteClusterConnectionTests.java index e6f7b449b43..72722ff10b5 100644 --- a/server/src/test/java/org/elasticsearch/transport/RemoteClusterConnectionTests.java +++ b/server/src/test/java/org/elasticsearch/transport/RemoteClusterConnectionTests.java @@ -672,7 +672,7 @@ public class RemoteClusterConnectionTests extends ESTestCase { AtomicReference failReference = new AtomicReference<>(); connection.fetchSearchShards(searchShardsRequest, new LatchedActionListener<>(ActionListener.wrap(reference::set, failReference::set), responseLatch)); - assertTrue(responseLatch.await(5, TimeUnit.SECONDS)); + assertTrue(responseLatch.await(10, TimeUnit.SECONDS)); assertNull(failReference.get()); assertNotNull(reference.get()); ClusterSearchShardsResponse response = reference.get(); @@ -703,7 +703,7 @@ public class RemoteClusterConnectionTests extends ESTestCase { new LatchedActionListener<>(ActionListener.wrap((s) -> { reference.set(s); }, failReference::set), responseLatch)); - assertTrue(responseLatch.await(1, TimeUnit.SECONDS)); + assertTrue(responseLatch.await(10, TimeUnit.SECONDS)); assertNotNull(failReference.get()); assertNull(reference.get()); assertThat(failReference.get(), instanceOf(TransportException.class)); @@ -716,7 +716,7 @@ public class RemoteClusterConnectionTests extends ESTestCase { AtomicReference failReference = new AtomicReference<>(); connection.fetchSearchShards(searchShardsRequest, new LatchedActionListener<>(ActionListener.wrap(reference::set, failReference::set), responseLatch)); - assertTrue(responseLatch.await(1, TimeUnit.SECONDS)); + assertTrue(responseLatch.await(10, TimeUnit.SECONDS)); assertNull(failReference.get()); assertNotNull(reference.get()); ClusterSearchShardsResponse response = reference.get(); @@ -725,7 +725,7 @@ public class RemoteClusterConnectionTests extends ESTestCase { //give transport service enough time to realize that the node is down, and to notify the connection listeners //so that RemoteClusterConnection is left with no connected nodes, hence it will retry connecting next - assertTrue(disconnectedLatch.await(1, TimeUnit.SECONDS)); + assertTrue(disconnectedLatch.await(10, TimeUnit.SECONDS)); if (randomBoolean()) { connection.updateSkipUnavailable(false); @@ -739,7 +739,7 @@ public class RemoteClusterConnectionTests extends ESTestCase { AtomicReference failReference = new AtomicReference<>(); connection.fetchSearchShards(searchShardsRequest, new LatchedActionListener<>(ActionListener.wrap(reference::set, failReference::set), responseLatch)); - assertTrue(responseLatch.await(1, TimeUnit.SECONDS)); + assertTrue(responseLatch.await(10, TimeUnit.SECONDS)); assertNull(failReference.get()); assertNotNull(reference.get()); ClusterSearchShardsResponse response = reference.get();