honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added refCount assertion due to LUCENE-5362

This commit is contained in:
Simon Willnauer 2013-12-08 20:55:57 +01:00
parent 11e2b1bef3
commit 191887dd08
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/test/java/org/elasticsearch/test/engine/MockRobinEngine.java
View File

@ -97,10 +97,13 @@ public final class MockRobinEngine extends RobinEngine implements Engine {
private final ShardId shardId; private final ShardId shardId;
private RuntimeException firstReleaseStack; private RuntimeException firstReleaseStack;
private final Object lock = new Object(); private final Object lock = new Object();
private final int initialRefCount;
public AssertingSearcher(Searcher searcher, ShardId shardId) { public AssertingSearcher(Searcher searcher, ShardId shardId) {
this.searcher = searcher; this.searcher = searcher;
this.shardId = shardId; this.shardId = shardId;
initialRefCount = searcher.reader().getRefCount();
assert initialRefCount > 0 : "IndexReader#getRefCount() was [" + initialRefCount + "] expected a value > [0] - reader is already closed";
INFLIGHT_ENGINE_SEARCHERS.put(this, new RuntimeException("Unreleased Searcher, source [" + searcher.source() + "]")); INFLIGHT_ENGINE_SEARCHERS.put(this, new RuntimeException("Unreleased Searcher, source [" + searcher.source() + "]"));
} }
@ -124,6 +127,10 @@ public final class MockRobinEngine extends RobinEngine implements Engine {
firstReleaseStack = new RuntimeException("Searcher Released first here, source [" + searcher.source() + "]"); firstReleaseStack = new RuntimeException("Searcher Released first here, source [" + searcher.source() + "]");
} }
} }
final int refCount = searcher.reader().getRefCount();
// this assert seems to be paranoid but given LUCENE-5362 we better add some assertions here to make sure we catch any potential
// problems.
assert refCount > 0 : "IndexReader#getRefCount() was [" + refCount + "] expected a value > [0] - reader is already closed. Initial refCount was: [" + initialRefCount + "]";
try { try {
return searcher.release(); return searcher.release();
} catch (RuntimeException ex) { } catch (RuntimeException ex) {