From 1abecad21be5dcdcbcc252eb93f78350646b9581 Mon Sep 17 00:00:00 2001 From: Nik Everett Date: Fri, 3 Jan 2020 10:58:15 -0500 Subject: [PATCH] Mark some constants in decay functions final (#50569) (#50575) This marks a couple of constants in the `DecayFunctionBuilder` as final. They are written in CONSTANT_CASE and used as constants but not final which is a little confusing and might lead to sneaky bugs. --- .../index/query/functionscore/DecayFunctionBuilder.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/src/main/java/org/elasticsearch/index/query/functionscore/DecayFunctionBuilder.java b/server/src/main/java/org/elasticsearch/index/query/functionscore/DecayFunctionBuilder.java index 7bca4ac9206..e31e646200a 100644 --- a/server/src/main/java/org/elasticsearch/index/query/functionscore/DecayFunctionBuilder.java +++ b/server/src/main/java/org/elasticsearch/index/query/functionscore/DecayFunctionBuilder.java @@ -65,8 +65,8 @@ public abstract class DecayFunctionBuilder protected static final String DECAY = "decay"; protected static final String OFFSET = "offset"; - public static double DEFAULT_DECAY = 0.5; - public static MultiValueMode DEFAULT_MULTI_VALUE_MODE = MultiValueMode.MIN; + public static final double DEFAULT_DECAY = 0.5; + public static final MultiValueMode DEFAULT_MULTI_VALUE_MODE = MultiValueMode.MIN; private final String fieldName; //parsing of origin, scale, offset and decay depends on the field type, delayed to the data node that has the mapping for it